Re: [PATCH] gnu: Add myrepos.
Ricardo Wurmus writes:
[...]
> You should add a ‘(file-name ...)’ expression here, because the tarball
> does not include the name of the package:
>
>(file-name (string-append name "-" version ".tar.gz"))
OK.
>> + #:make-flags (list (string-append "DESTDIR=" (assoc-ref %outputs
>> "out"))
>> + "PREFIX=")))
>
> Is it really correct to set DESTDIR and unset PREFIX? I thought setting
> PREFIX would be sufficient.
Right, setting PREFIX works fine. Myrepo's Makefile forms the path as
"${DESTDIR}${PREFIX}", so the end result should be the same. I'm not
sure why I decided setting DESTDIR would be better.
Sending an updated patch. Thanks for the comments.
--
Kyle
Re: [PATCH] gnu: Add myrepos.
Hi Kyle,
thanks for the patch!
> * gnu/packages/version-control.scm (myrepos): New variable.
> ---
> gnu/packages/version-control.scm | 30 ++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/version-control.scm
> b/gnu/packages/version-control.scm
> index b132663..d7c4f8c 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -7,6 +7,7 @@
> ;;; Copyright © 2014, 2015 Mark H Weaver
> ;;; Copyright © 2014 Eric Bavier
> ;;; Copyright © 2015 Efraim Flashner
> +;;; Copyright © 2015 Kyle Meyer
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -925,3 +926,32 @@ any project with more than one developer, is one of
> Aegis's major functions.")
> a history browser. It can also stage hunks for commit, or colorize the
> output of the 'git' command.")
> (license gpl2+)))
> +
> +(define-public myrepos
> + (package
> +(name "myrepos")
> +(version "1.20151022")
> +(source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/joeyh/myrepos/archive/";
> + version ".tar.gz"))
You should add a ‘(file-name ...)’ expression here, because the tarball
does not include the name of the package:
(file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> +(base32 "0c93lqsngpsxsca7nygk4qhidr40ijgih86q81x1mfcwbs0gbds8"
> +(build-system gnu-build-system)
> +(inputs
> + `(("perl" ,perl)))
> +(arguments
> + `(#:test-target "test"
> + #:phases (alist-delete 'configure %standard-phases)
> + #:make-flags (list (string-append "DESTDIR=" (assoc-ref %outputs
> "out"))
> + "PREFIX=")))
Is it really correct to set DESTDIR and unset PREFIX? I thought setting
PREFIX would be sufficient.
> +(home-page "http://myrepos.branchable.com/";)
> +(synopsis "Multiple repository management tool")
> +(description
> + "Myrepos provides the @code{mr} command, which maps an operation (e.g.,
> +fetching updates) over a collection of version control repositories. It
> +supports a large number of version control systems: git, svn, mercurial, bzr,
> +darcs, cvs, fossil and veracity.")
> +(license gpl2+)))
The rest looks fine to me. Thanks!
~~ Ricardo
[PATCH] gnu: Add myrepos.
* gnu/packages/version-control.scm (myrepos): New variable.
---
gnu/packages/version-control.scm | 30 ++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index b132663..d7c4f8c 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -7,6 +7,7 @@
;;; Copyright © 2014, 2015 Mark H Weaver
;;; Copyright © 2014 Eric Bavier
;;; Copyright © 2015 Efraim Flashner
+;;; Copyright © 2015 Kyle Meyer
;;;
;;; This file is part of GNU Guix.
;;;
@@ -925,3 +926,32 @@ any project with more than one developer, is one of
Aegis's major functions.")
a history browser. It can also stage hunks for commit, or colorize the
output of the 'git' command.")
(license gpl2+)))
+
+(define-public myrepos
+ (package
+(name "myrepos")
+(version "1.20151022")
+(source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/joeyh/myrepos/archive/";
+ version ".tar.gz"))
+ (sha256
+(base32 "0c93lqsngpsxsca7nygk4qhidr40ijgih86q81x1mfcwbs0gbds8"
+(build-system gnu-build-system)
+(inputs
+ `(("perl" ,perl)))
+(arguments
+ `(#:test-target "test"
+ #:phases (alist-delete 'configure %standard-phases)
+ #:make-flags (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
+ "PREFIX=")))
+(home-page "http://myrepos.branchable.com/";)
+(synopsis "Multiple repository management tool")
+(description
+ "Myrepos provides the @code{mr} command, which maps an operation (e.g.,
+fetching updates) over a collection of version control repositories. It
+supports a large number of version control systems: git, svn, mercurial, bzr,
+darcs, cvs, fossil and veracity.")
+(license gpl2+)))
--
2.6.2
