Re: [PATCH] gnu: mail: Add notifymuch.

[Christopher Baines]

On 14/10/16 10:30, Hartmut Goebel wrote:
> Am 13.10.2016 um 22:10 schrieb Ludovic Courtès:
>> Hartmut, since the rest of the patch looked non controversial, and if
>> ‘guix lint’ doesn’t complain, you can push to ‘master’ with the synopsis
>> above.
> 
> Done with minor adjustments.
> 0350a8bb1eef12927964fb6ce62ae64f10fa6f8d

Great, thanks for your review and help Hartmut :)




signature.asc
Description: OpenPGP digital signature

Re: [PATCH] gnu: mail: Add notifymuch.

[Hartmut Goebel]

Am 13.10.2016 um 22:10 schrieb Ludovic Courtès:
> Hartmut, since the rest of the patch looked non controversial, and if
> ‘guix lint’ doesn’t complain, you can push to ‘master’ with the synopsis
> above.

Done with minor adjustments.
0350a8bb1eef12927964fb6ce62ae64f10fa6f8d

-- 
Regards
Hartmut Goebel

| Hartmut Goebel  | h.goe...@crazy-compilers.com   |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH] gnu: mail: Add notifymuch.

[Ludovic Courtès]

Hartmut Goebel  skribis:

> Am 12.10.2016 um 20:17 schrieb Christopher Baines:
 +(description "notifymuch displays desktop notifications for
 messages in
 +the notmuch database.  The notifications are sent using libnotify to a
>>>
>>> May I ask you to ass some words about what notmuch is? This saves the
>>> ingenuous reader to recherché what notmuch is. Thanks.
>>
>> I'm not quite sure how to improve on this. Copying in the full package
>> description for notmuch looks out of place to me, and I'm not sure if
>> just saying "the notmuch email database" instead of "the notmuch
>> database" is sufficient?
>>
>
> IC, this is a complicated one, since notmuch seems to be a framework. I
> have to admit that I did not know about notmuch until just now.
> Explaining about what notmuch is would indeed disrupt the description.
> So I'd say your suggestion is okay, since it give the ingenuous reader
> at least a hint.
>
> (synopsis "Displays notifications for changes in the notmuch email
> database")

Sounds good (without the newline though).

Hartmut, since the rest of the patch looked non controversial, and if
‘guix lint’ doesn’t complain, you can push to ‘master’ with the synopsis
above.

The ‘license’ field may also need to be fixed: it says ‘gpl3’, which
means GPLv3-only, but the odds are that it’s in fact GPLv3-or-later,
aka. ‘gpl3+’.

Thanks,
Ludo’.

Re: [PATCH] gnu: mail: Add notifymuch.

[Hartmut Goebel]

Am 12.10.2016 um 20:17 schrieb Christopher Baines:
>>> +(description "notifymuch displays desktop notifications for
>>> messages in
>>> +the notmuch database.  The notifications are sent using libnotify to a
>>
>> May I ask you to ass some words about what notmuch is? This saves the
>> ingenuous reader to recherché what notmuch is. Thanks.
>
> I'm not quite sure how to improve on this. Copying in the full package
> description for notmuch looks out of place to me, and I'm not sure if
> just saying "the notmuch email database" instead of "the notmuch
> database" is sufficient?
>

IC, this is a complicated one, since notmuch seems to be a framework. I
have to admit that I did not know about notmuch until just now.
Explaining about what notmuch is would indeed disrupt the description.
So I'd say your suggestion is okay, since it give the ingenuous reader
at least a hint.

(synopsis "Displays notifications for changes in the notmuch email
database")


-- 
Regards
Hartmut Goebel

| Hartmut Goebel  | h.goe...@crazy-compilers.com   |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH] gnu: mail: Add notifymuch.

[Christopher Baines]

On 10/10/16 08:40, Hartmut Goebel wrote:

Am 09.10.2016 um 23:33 schrieb Christopher Baines:

+(description "notifymuch displays desktop notifications for messages in
+the notmuch database.  The notifications are sent using libnotify to a


May I ask you to ass some words about what notmuch is? This saves the
ingenuous reader to recherché what notmuch is. Thanks.


I'm not quite sure how to improve on this. Copying in the full package 
description for notmuch looks out of place to me, and I'm not sure if 
just saying "the notmuch email database" instead of "the notmuch 
database" is sufficient?

Re: [PATCH] gnu: mail: Add notifymuch.

[Hartmut Goebel]

Am 10.10.2016 um 09:52 schrieb Alex Kost:
> Nice typo, I think it ment to be "add", right?  :-)

Of course :-)

-- 
Regards
Hartmut Goebel

| Hartmut Goebel  | h.goe...@crazy-compilers.com   |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH] gnu: mail: Add notifymuch.

[Alex Kost]

Hartmut Goebel (2016-10-10 09:40 +0200) wrote:

> Am 09.10.2016 um 23:33 schrieb Christopher Baines:
>> +(description "notifymuch displays desktop notifications for messages in
>> +the notmuch database.  The notifications are sent using libnotify to a
>
> May I ask you to ass some words about what notmuch is? This saves the
   ^^^

Nice typo, I think it ment to be "add", right?  :-)

> ingenuous reader to recherché what notmuch is. Thanks.

-- 
Alex

Re: [PATCH] gnu: mail: Add notifymuch.

[Hartmut Goebel]

Am 09.10.2016 um 23:33 schrieb Christopher Baines:
> +(description "notifymuch displays desktop notifications for messages in
> +the notmuch database.  The notifications are sent using libnotify to a

May I ask you to ass some words about what notmuch is? This saves the
ingenuous reader to recherché what notmuch is. Thanks.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel  | h.goe...@crazy-compilers.com   |
| www.crazy-compilers.com | compilers which you thought are impossible |

[PATCH] gnu: mail: Add notifymuch.

[Christopher Baines]

Thanks for your review. The version (0.1) is specified in the setup.py file,
but your right in saying that there is no "real" 0.1 version release. I've also
removed inputs from the wrap-binary stage.

[PATCH] gnu: mail: Add notifymuch.

[Christopher Baines]

* gnu/packages/mail.scm (notifymuch): New variable.
---
 gnu/packages/mail.scm | 50 ++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index baa5a96..02dd72a 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -443,6 +443,56 @@ attachments, create new maildirs, and so on.")
 @code{notmuch} mail.  It is written in Python using the @code{urwid} toolkit.")
 (license gpl3+)))
 
+(define-public notifymuch
+  (let
+  ((commit "9d4aaf54599282ce80643b38195ff501120807f0")
+   (revision "1"))
+(package
+  (name "notifymuch")
+  (version (string-append "0.1-"
+  revision
+  "."
+  (string-take commit 7)))
+  (source
+   (origin
+ (method git-fetch)
+ (uri (git-reference
+   (url "https://github.com/kspi/notifymuch.git;)
+   (commit commit)))
+ (sha256
+  (base32
+   "1lssr7iv43mp5v6nzrfbqlfzx8jcc7m636wlfyhhnd8ydd39n6k4"))
+ (file-name (string-append name "-" version "-checkout"
+  (build-system python-build-system)
+  (inputs `(("python-notmuch" ,python-notmuch)
+("gobject-introspection" ,gobject-introspection)
+("libnotify" ,libnotify)
+("gtk+" ,gtk+)
+("python-pygobject" ,python-pygobject)))
+  (arguments
+   `(#:phases
+ (modify-phases %standard-phases
+   (add-after 'install 'wrap-binary
+ (lambda* (#:key outputs #:allow-other-keys)
+   (let* ((out (assoc-ref outputs "out"))
+  (bin (string-append out "/bin/notifymuch")))
+ (wrap-program bin
+   `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")))
+   `("GI_TYPELIB_PATH" ":" prefix
+ (,(getenv "GI_TYPELIB_PATH")
+  ,(string-append out "/lib/girepository-1.0")
+   #t)
+  (home-page "https://github.com/kspi/notifymuch;)
+  (synopsis "Displays notifications for changes in the notmuch database")
+  (description "notifymuch displays desktop notifications for messages in
+the notmuch database.  The notifications are sent using libnotify to a
+notification daemon.  The query to find messages to send a notification about
+is configurable, and a notification for the same message will not be send
+within a configurable period (defaults to 48 hours).  To use notifymuch, run
+@command{notifymuch} after new mail is indexed, this can be automated by
+invoking @command{notifymuch} from the post-new hook.")
+  (license gpl3
+
 (define-public notmuch
   (package
 (name "notmuch")
-- 
2.10.1

Re: [PATCH] gnu: mail: Add notifymuch.

[Leo Famulari]

On Sun, Oct 09, 2016 at 10:33:18PM +0100, Christopher Baines wrote:
> * gnu/packages/mail.scm (notifymuch): New variable.

Thanks for this patch!

> +(version "0.1")
> +(source
> + (origin
> +   (method git-fetch)
> +   (uri (git-reference
> + (url "https://github.com/kspi/notifymuch.git;)
> + (commit "9d4aaf54599282ce80643b38195ff501120807f0")))

There are no "real" releases, right? I didn't see a 0.1 version on the
home-page.

If so, can you revise this patch to use the versioning method described
in the manual, section 7.6.3 Version Numbers [0]?

So, the resulting version string would be 0.0.0-1.9d4aaf5.

There is a recent example in 4b51b21ccf (gnu: Add cl-clx.).

By the way, for anyone reading along, the commit chosen by Christopher
is the current HEAD of the master branch.

> + (add-after 'install 'wrap-binary
> +   (lambda* (#:key inputs outputs #:allow-other-keys)

I think 'inputs' can be removed since it isn't used here.

Looks good with these changes!

[0]
https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html