Re: [PATCH 2/2] gnu: Add emacs-better-defaults.

2016-05-31 Thread Mark H Weaver 
"Thompson, David"  writes:

> On Tue, May 31, 2016 at 12:59 PM, Mark H Weaver  wrote:
>> "Thompson, David"  writes:
>>> Fixed and pushed.  Thanks Ludo and Alex!
>>
>> It fails to build on Hydra:
>>
>>   http://hydra.gnu.org/build/1208688 (x86_64)
>>   http://hydra.gnu.org/build/1208304 (i686)
>>   http://hydra.gnu.org/build/1208517 (armhf)
>
> These jobs are for building emacs-constants, contributed by Federico
> Beffa in February.  I took a look at the build log and the failure is
> in the make-autoloads build phase which this patch set shouldn't have
> affected.

Ah, indeed, I stand corrected.  Sorry for the noise.

  Mark

Re: [PATCH 2/2] gnu: Add emacs-better-defaults.

2016-05-31 Thread Alex Kost 
Mark H Weaver (2016-05-31 19:59 +0300) wrote:

> "Thompson, David"  writes:
>> Fixed and pushed.  Thanks Ludo and Alex!
>
> It fails to build on Hydra:
>
>   http://hydra.gnu.org/build/1208688 (x86_64)
>   http://hydra.gnu.org/build/1208304 (i686)
>   http://hydra.gnu.org/build/1208517 (armhf)

This happened because the source was wrongfully renamed to ".el" while
it should be ".tar.gz".  Fixed by commit
37dbfc50841a8e91f9fb0dc80ff9b5f23de38689.

-- 
Alex

Re: [PATCH 2/2] gnu: Add emacs-better-defaults.

2016-05-31 Thread Thompson, David 
On Tue, May 31, 2016 at 4:53 PM, Alex Kost  wrote:
> Mark H Weaver (2016-05-31 19:59 +0300) wrote:
>
>> "Thompson, David"  writes:
>>> Fixed and pushed.  Thanks Ludo and Alex!
>>
>> It fails to build on Hydra:
>>
>>   http://hydra.gnu.org/build/1208688 (x86_64)
>>   http://hydra.gnu.org/build/1208304 (i686)
>>   http://hydra.gnu.org/build/1208517 (armhf)
>
> This happened because the source was wrongfully renamed to ".el" while
> it should be ".tar.gz".  Fixed by commit
> 37dbfc50841a8e91f9fb0dc80ff9b5f23de38689.

Ugh, sorry for that blunder.

- Dave

Re: [PATCH 2/2] gnu: Add emacs-better-defaults.

2016-05-31 Thread Thompson, David 
On Tue, May 31, 2016 at 12:59 PM, Mark H Weaver  wrote:
> "Thompson, David"  writes:
>> Fixed and pushed.  Thanks Ludo and Alex!
>
> It fails to build on Hydra:
>
>   http://hydra.gnu.org/build/1208688 (x86_64)
>   http://hydra.gnu.org/build/1208304 (i686)
>   http://hydra.gnu.org/build/1208517 (armhf)

These jobs are for building emacs-constants, contributed by Federico
Beffa in February.  I took a look at the build log and the failure is
in the make-autoloads build phase which this patch set shouldn't have
affected.

- Dave

Re: [PATCH 2/2] gnu: Add emacs-better-defaults.

2016-05-31 Thread Mark H Weaver 
"Thompson, David"  writes:
> Fixed and pushed.  Thanks Ludo and Alex!

It fails to build on Hydra:

  http://hydra.gnu.org/build/1208688 (x86_64)
  http://hydra.gnu.org/build/1208304 (i686)
  http://hydra.gnu.org/build/1208517 (armhf)

Can you take a look?

  Mark

Re: [PATCH 2/2] gnu: Add emacs-better-defaults.

2016-05-30 Thread Thompson, David 
On Sat, May 28, 2016 at 11:37 AM, Ludovic Courtès  wrote:
> David Thompson  skribis:
>
>> * gnu/packages/emacs.scm (emacs-better-defaults): New variable.
>
> [...]
>
>> +   (uri (string-append 
>> "http://stable.melpa.org/packages/better-defaults-;
>> +   version ".el"))
>
> IIRC, MELPA URLs are not stable over time (modified in place) and for
> this reason we usually fetch things from Git instead.
>
> Could you do that here?

Fixed and pushed.  Thanks Ludo and Alex!

- Dave

Re: [PATCH 2/2] gnu: Add emacs-better-defaults.

2016-05-28 Thread Ludovic Courtès 
David Thompson  skribis:

> * gnu/packages/emacs.scm (emacs-better-defaults): New variable.

[...]

> +   (uri (string-append 
> "http://stable.melpa.org/packages/better-defaults-;
> +   version ".el"))

IIRC, MELPA URLs are not stable over time (modified in place) and for
this reason we usually fetch things from Git instead.

Could you do that here?

Otherwise LGTM, thanks!

Ludo’.

Re: [PATCH 2/2] gnu: Add emacs-better-defaults.

2016-05-28 Thread Alex Kost 
David Thompson (2016-05-27 17:10 +0300) wrote:

> * gnu/packages/emacs.scm (emacs-better-defaults): New variable.
> ---
>  gnu/packages/emacs.scm | 21 +
>  1 file changed, 21 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 5d6db5a..105c25d 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1706,3 +1706,24 @@ It is recommended to use @code{clojure-mode} with 
> paredit or smartparens.")
>  The purpose of this library is to wrap all the quirks and hassle of
>  @code{package.el} into a sane API.")
>  (license license:gpl3+)))
> +
> +(define-public emacs-better-defaults
> +  (package
> +(name "emacs-better-defaults")
> +(version "0.1.3")
> +(source
> + (origin
> +   (method url-fetch)
> +   (uri (string-append 
> "http://stable.melpa.org/packages/better-defaults-;
> +   version ".el"))

My understanding is that we prefer to retrieve a source directly from
the upstream, so it is better to use:

  https://github.com/technomancy/better-defaults/archive/0.1.3.tar.gz

Otherwise, LGTM.

> +   (sha256
> +(base32
> + "0lvpmja8i8v10lbcvzj6pd7vn9c7gnlbcddd416g2pjq0yydydgf"
> +(build-system emacs-build-system)
> +(home-page "https://github.com/technomancy/better-defaults;)
> +(synopsis "Better defaults for Emacs")
> +(description
> + "Better defaults attempts to address the most obvious deficiencies of 
> the
> +Emacs default configuration in uncontroversial ways that nearly everyone can
> +agree upon.")
> +(license license:gpl3+)))

-- 
Alex

[PATCH 2/2] gnu: Add emacs-better-defaults.

2016-05-27 Thread David Thompson 
* gnu/packages/emacs.scm (emacs-better-defaults): New variable.
---
 gnu/packages/emacs.scm | 21 +
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 5d6db5a..105c25d 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1706,3 +1706,24 @@ It is recommended to use @code{clojure-mode} with 
paredit or smartparens.")
 The purpose of this library is to wrap all the quirks and hassle of
 @code{package.el} into a sane API.")
 (license license:gpl3+)))
+
+(define-public emacs-better-defaults
+  (package
+(name "emacs-better-defaults")
+(version "0.1.3")
+(source
+ (origin
+   (method url-fetch)
+   (uri (string-append "http://stable.melpa.org/packages/better-defaults-;
+   version ".el"))
+   (sha256
+(base32
+ "0lvpmja8i8v10lbcvzj6pd7vn9c7gnlbcddd416g2pjq0yydydgf"
+(build-system emacs-build-system)
+(home-page "https://github.com/technomancy/better-defaults;)
+(synopsis "Better defaults for Emacs")
+(description
+ "Better defaults attempts to address the most obvious deficiencies of the
+Emacs default configuration in uncontroversial ways that nearly everyone can
+agree upon.")
+(license license:gpl3+)))
-- 
2.7.3