Re: 02/36: gnu: guix: Use gnutls-3.6.13 when cross-compiling.

2020-05-01 Thread Jan Nieuwenhuizen
Ludovic Courtès writes:

Hello Ludo'!

> Time for random review comments on ‘wip-hurd-vm’.  :-)

\o/

> guix-comm...@gnu.org skribis:
>
>> commit af9b4d0ba3d55ef89e956f408853548451243e95
>> Author: Jan (janneke) Nieuwenhuizen 
>> AuthorDate: Fri Apr 10 09:54:02 2020 +0200
>>
>> gnu: guix: Use gnutls-3.6.13 when cross-compiling.
>> 
>> * gnu/packages/package-management.scm (guix)[propagated-inputs]: When
>> cross-compiling, use patched gnutls-3.6.13.
>
> [...]
>
>>(propagated-inputs
>> -   `(("gnutls" ,guile3.0-gnutls)
>> +   `(("gnutls" ,(if (%current-target-system)
>> +(@@ (gnu packages tls) gnutls-3.6.13)
>
> Please avoid @@ by making ‘gnutls-3.6.13’ public

Oh..."gnutls-3.6.13" is already public; I simply removed (@@ ..)

Hmm, I don't know how this happened...I either didn't look well before,
maybe I was using then non-exported "gnutls", changed to gnutls-3.6.13
and kept the @@), or possibly it got exported later.  I'll try to
remember to avoid @@ in such cases.

> (and making the package > itself hidden if necessary).

> Otherwise LGTM!

Great, pushed.

> Forgive brevity, sent from my Emacs under lockdown.
> :-)

*lol*

Reading in my GNU Emacs under lockdown, thanks for your brevity.

-- 
Jan Nieuwenhuizen  | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com



Re: 02/36: gnu: guix: Use gnutls-3.6.13 when cross-compiling.

2020-04-30 Thread Ludovic Courtès
Hello!

Time for random review comments on ‘wip-hurd-vm’.  :-)

guix-comm...@gnu.org skribis:

> commit af9b4d0ba3d55ef89e956f408853548451243e95
> Author: Jan (janneke) Nieuwenhuizen 
> AuthorDate: Fri Apr 10 09:54:02 2020 +0200
>
> gnu: guix: Use gnutls-3.6.13 when cross-compiling.
> 
> * gnu/packages/package-management.scm (guix)[propagated-inputs]: When
> cross-compiling, use patched gnutls-3.6.13.

[...]

>(propagated-inputs
> -   `(("gnutls" ,guile3.0-gnutls)
> +   `(("gnutls" ,(if (%current-target-system)
> +(@@ (gnu packages tls) gnutls-3.6.13)

Please avoid @@ by making ‘gnutls-3.6.13’ public (and making the package
itself hidden if necessary).

Otherwise LGTM!

Ludo’.

Forgive brevity, sent from my Emacs under lockdown.
:-)