Re: Helping with abandoned patches
Hi Greg, On mer., 17 janv. 2024 at 12:17, Greg Hogan wrote: > What is the preferred process for when a patch review is provided > (often by a committer) but no response is received from the submitter > (for many weeks or months)? > > Is it appropriate to make the recommended changes and submit an updated patch? Yes because the aim is to improve the code so the review is not lost. Moreover, in that case of no response after a delay, if the reviewer does not have commit access, the best (more helpful) seems sending by the reviewer or anyone else a new version including the recommended changes. Cheers, simon
Re: Helping with abandoned patches
On Wed, Jan 17 2024, Greg Hogan wrote: > Is it appropriate to make the recommended changes and submit an > updated patch? Yes, absolutely! Kind regards Felix
Re: Helping with abandoned patches
On Wed, Jan 17, 2024 at 12:17:26PM -0500, Greg Hogan wrote: > What is the preferred process for when a patch review is provided > (often by a committer) but no response is received from the submitter > (for many weeks or months)? > > Is it appropriate to make the recommended changes and submit an updated patch? I see no reason why it wouldn't be and at least I have done so[1] and the patch got eventually applied. [1]: https://issues.guix.gnu.org/61740 signature.asc Description: PGP signature
Helping with abandoned patches
What is the preferred process for when a patch review is provided (often by a committer) but no response is received from the submitter (for many weeks or months)? Is it appropriate to make the recommended changes and submit an updated patch? Examples include #62262 and #67294, but there surely are many more. Greg
