Re: Antioxidant (new rust build system) update - 100% builds

[Efraim Flashner]

On Wed, Nov 02, 2022 at 12:20:14PM +0100, Ludovic Courtès wrote:
> Hi!
> 
> Maxime Devos  skribis:
> 
> > 100% (rounded up) of the packages build with antioxidant, though a
> > very few still fail to build:
> > .
> 
> Woohoo!!
> 
> > So far, work on antioxidant has been done in a separate channel for
> > convenience, but given that almost everything builds now, I think it's
> > a good time to start looking into moving it into Guix proper
> > (initially as a branch, as there are some remaining TODOs like
> > e.g. 'why are some of the binaries made with antioxidant larger than
> > with cargo-build-system + fix that').
> >
> > More concretely, this would mean changing the 'runtime'
> > transformations done by 'antioxidant-packages.scm' (in the style of
> > '(guix)Defining Package Variants') to source code transformations
> > ("guix style").
> >
> > IIRC, Ludo' has some "guix style" patches for moving #:cargo-inputs to
> > 'inputs' and such; those could perhaps be used as a basis.
> 
> That’s  but it probably needs work if
> we want it to work reliably on all the packages.  My understanding is
> that we’d need a “flag day” where we’d switch all Rust packages to
> Antioxydant in one commit, is that correct?  Any ideas how to achieve
> the big migration?
> 
> Efraim, thoughts on this?

Would it be possible to create a branch for it on savannah and hack on
the integration there? Then we can make sure everything looks good and
merge it in after everything builds nicely.

-- 
Efraim Flashner  אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted


signature.asc
Description: PGP signature

Re: Antioxidant (new rust build system) update - 100% builds

[Maxime Devos]

On 03-11-2022 16:16, Ludovic Courtès wrote:

Hi,

[...]
Perhaps we could temporarily support the “old style”, using the run-time
transformation currently in your repo?  That would allow third-party
channels to migrate peacefully, and it would also reduce the likely hood
of breakage during transition in Guix (e.g., if an old-style package is
merged while the new branch is being built.)


That would be possible (some copy-pasting, and replacing
(define-public application/c-library/whatever ...)
with (define-public application/c-library/whatever (vitaminate/auto 
...)), but "guix refresh -l rust-..." won't be fixed until the source 
code changes are done.


Greetings,
Maxime.


OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: Antioxidant (new rust build system) update - 100% builds

[Ludovic Courtès]

Hi,

Maxime Devos  skribis:

> On 02-11-2022 12:20, Ludovic Courtès wrote:
>> [. ..]
>> That’s  but it probably needs work if
>> we want it to work reliably on all the packages.  My understanding is
>> that we’d need a “flag day” where we’d switch all Rust packages to
>> Antioxydant in one commit, is that correct?  Any ideas how to achieve
>> the big migration?
>
> That's the idea I think, yes.  For this big migration, I propose to
> make the "guix style" good enough to do the switch at once (and let
> ci.guix.gnu.org build it etc. before merging).

OK, makes sense.

> On how to achieve this: the basic antioxidation (e.g. move
> #:cargo-inputs to inputs) is currently fully automated (*).  Then
> there is stuff like 'add this-input to that-package', which is
> 'half-automated', in the sense that there are a bunch of declarative
> alists for that, interpreted automatically but declared manually;
> those could be interpreted by "guix style" as well.

Perhaps we could temporarily support the “old style”, using the run-time
transformation currently in your repo?  That would allow third-party
channels to migrate peacefully, and it would also reduce the likely hood
of breakage during transition in Guix (e.g., if an old-style package is
merged while the new branch is being built.)

Anyway, please do ping people here when specific action is needed from
the rest of us!

Thanks,
Ludo’.

Re: Antioxidant (new rust build system) update - 100% builds

[Maxime Devos]

On 02-11-2022 12:20, Ludovic Courtès wrote:

[. ..]
That’s  but it probably needs work if
we want it to work reliably on all the packages.  My understanding is
that we’d need a “flag day” where we’d switch all Rust packages to
Antioxydant in one commit, is that correct?  Any ideas how to achieve
the big migration?


That's the idea I think, yes.  For this big migration, I propose to make 
the "guix style" good enough to do the switch at once (and let 
ci.guix.gnu.org build it etc. before merging).


On how to achieve this: the basic antioxidation (e.g. move 
#:cargo-inputs to inputs) is currently fully automated (*).  Then there 
is stuff like 'add this-input to that-package', which is 
'half-automated', in the sense that there are a bunch of declarative 
alists for that, interpreted automatically but declared manually; those 
could be interpreted by "guix style" as well.


Lastly, there is some more manual things too -- for making packages 
build under antioxidant, I sometimes found it convenient to update the
package (which sometimes also required packaging a dependency).  For 
those additions and updates, I propose to review+merge them (as 
cargo-build-system, not antioxidant-build-system) before the flag day / 
running "guix style".


(*) albeit at runtime, no corresponding source code tranformations (guix 
style) are written yet.


Greetings,
Maxime.


OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: Antioxidant (new rust build system) update - 100% builds

[Ludovic Courtès]

Hi!

Maxime Devos  skribis:

> 100% (rounded up) of the packages build with antioxidant, though a
> very few still fail to build:
> .

Woohoo!!

> So far, work on antioxidant has been done in a separate channel for
> convenience, but given that almost everything builds now, I think it's
> a good time to start looking into moving it into Guix proper
> (initially as a branch, as there are some remaining TODOs like
> e.g. 'why are some of the binaries made with antioxidant larger than
> with cargo-build-system + fix that').
>
> More concretely, this would mean changing the 'runtime'
> transformations done by 'antioxidant-packages.scm' (in the style of
> '(guix)Defining Package Variants') to source code transformations
> ("guix style").
>
> IIRC, Ludo' has some "guix style" patches for moving #:cargo-inputs to
> 'inputs' and such; those could perhaps be used as a basis.

That’s  but it probably needs work if
we want it to work reliably on all the packages.  My understanding is
that we’d need a “flag day” where we’d switch all Rust packages to
Antioxydant in one commit, is that correct?  Any ideas how to achieve
the big migration?

Efraim, thoughts on this?

Thanks,
Ludo’.

Re: Antioxidant (new rust build system) update - 100% builds

[Hartmut Goebel]

Am 29.10.22 um 21:38 schrieb Maxime Devos:
100% (rounded up) of the packages build with antioxidant, though a 
very few still fail to build: 
. 


\o/ You are great! Thansk for all the work you've put into this.

--
Regards
Hartmut Goebel

| Hartmut Goebel  | h.goe...@crazy-compilers.com   |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: Antioxidant (new rust build system) update - 100% builds

[Csepp]

Maxime Devos  writes:

> [[PGP Signed Part:Undecided]]
> Hi,
>
> 100% (rounded up) of the packages build with antioxidant, though a
> very few still fail to build:
> .

Heck yeah!  This is some super exciting work. UwU

Re: Antioxidant (new rust build system) update - 100% builds

[Tobias Geerinckx-Rice]

Hi Maxime,

This is so great.

It's been downright fun watching antioxidant steadily grow in 
power.  Thank you so much for working on it!


Kind regards,

T G-R


signature.asc
Description: PGP signature