Re: Commit Access: Sharlatan Hellseher

[Maxim Cournoyer]

Hi!

Kyle Meyer  writes:

> Hi Maxim,
>
> Maxim Cournoyer writes:
>
>> Another easy option is to retrieve the Message-ID of any message in the
>> series (via the source HTML of the mail archives, or directly from the
>> mail headers if you have the mail locally), and then use B4, Linux
>> style [0].  Example: suppose I wanted to apply and review this Perl
>> series [1], then I could apply locally to my Guix git checkout with:
>
> I was going to add that a key part of using b4 with public-inbox
> instances outside of the default lore.kernel.org is setting b4.midmask.
> But then I noticed that Guix's etc/git/gitconfig now has
>
> [b4]
> attestation-check-dkim = off
> attestation-policy = off
> linkmask = https://yhetil.org/guix/%s
> linktrailermask = https://yhetil.org/guix/%s
> midmask = https://yhetil.org/guix/%s
>
> Neat.  Thanks for adding that!

This auto-config thing is powerful :-).  Perhaps we should add a word or
two about b4 and other workflows to our cookbook.  I also use patman for
managing submissions with ease (info "(u-boot) Patman patch manager").

-- 
Thanks,
Maxim

Re: Commit Access: Sharlatan Hellseher

[Kyle Meyer]

Hi Maxim,

Maxim Cournoyer writes:

> Another easy option is to retrieve the Message-ID of any message in the
> series (via the source HTML of the mail archives, or directly from the
> mail headers if you have the mail locally), and then use B4, Linux
> style [0].  Example: suppose I wanted to apply and review this Perl
> series [1], then I could apply locally to my Guix git checkout with:

I was going to add that a key part of using b4 with public-inbox
instances outside of the default lore.kernel.org is setting b4.midmask.
But then I noticed that Guix's etc/git/gitconfig now has

[b4]
attestation-check-dkim = off
attestation-policy = off
linkmask = https://yhetil.org/guix/%s
linktrailermask = https://yhetil.org/guix/%s
midmask = https://yhetil.org/guix/%s

Neat.  Thanks for adding that!

Re: Commit Access: Sharlatan Hellseher

[Simon Tournier]

Hi Oleg,

On Thu, 11 Jan 2024 at 19:56, Sharlatan Hellseher  wrote:

> I am happy to have been granted commit access

Cool!  Welcome.

> If anyone has a good patch review workflow using Emacs, Gnus, and Magit,
> I would appreciate it ;-)

Well, nothing more than what had been already suggested.  Well, somehow
pipe the messages with “git am -3s” and apply the patches to a Git
worktree (named cooking), then rebase this cooking on the top of
master.

Cheers,
simon

Re: Commit Access: Sharlatan Hellseher

[Maxim Cournoyer]

Hi,

Efraim Flashner  writes:

> On Fri, Jan 12, 2024 at 05:21:51PM +0100, Clément Lassieur wrote:
>> On Thu, Jan 11 2024, Sharlatan Hellseher wrote:
>> 
>> > Hi Guix!
>> >
>> > I am happy to have been granted commit access and I am ready to help
>> > review pending issues and prepare queued packages for GNU packages in
>> > astronomy. I would like to concentrate on the packages covered by the
>> > Go, Lisp, Python, and Science teams.
>> >
>> > I would like to thank the Guix team for allowing me to become a
>> > committer member. I am looking forward to continuing our collaboration.
>> >
>> > If anyone has a good patch review workflow using Emacs, Gnus, and Magit,
>> > I would appreciate it ;-)

Another easy option is to retrieve the Message-ID of any message in the
series (via the source HTML of the mail archives, or directly from the
mail headers if you have the mail locally), and then use B4, Linux
style [0].  Example: suppose I wanted to apply and review this Perl
series [1], then I could apply locally to my Guix git checkout with:

--8<---cut here---start->8---
b4 shazam 
'a6492643b9e32409b8420e7d54ba290d0937b838.1705443194.git.felix.lechner@leaseup.com'
--8<---cut here---end--->8---

It should get the latest revisions if there are, and apply the full
series in one go.

[0]  https://b4.docs.kernel.org/en/latest/maintainer/am-shazam.html
[1]  https://lists.gnu.org/archive/html/guix-patches/2024-01/msg01180.html
-- 
Thanks,
Maxim

Re: Commit Access: Sharlatan Hellseher

[Rostislav Svoboda]

> Just my 2 cents, I imagine every person here has their own workflow.

I personally don't have any yet (and I assume I'm not the only one) so
I'm really thankful for your snippet.
Cheers Bost

Re: Commit Access: Sharlatan Hellseher

[John Kehayias]

On Thu, Jan 11, 2024 at 07:56 PM, Sharlatan Hellseher wrote:

>
> Hi Guix!
>
> I am happy to have been granted commit access and I am ready to help
> review pending issues and prepare queued packages for GNU packages in
> astronomy. I would like to concentrate on the packages covered by the
> Go, Lisp, Python, and Science teams.
>
> I would like to thank the Guix team for allowing me to become a
> committer member. I am looking forward to continuing our collaboration.
>
> If anyone has a good patch review workflow using Emacs, Gnus, and Magit,
> I would appreciate it ;-)
>
> Regards,
> Sharlatan Hellseher (Oleg)
>

Welcome and looking forward to your further Guix contributions!

John

Re: Commit Access: Sharlatan Hellseher

[Efraim Flashner]

On Fri, Jan 12, 2024 at 05:21:51PM +0100, Clément Lassieur wrote:
> On Thu, Jan 11 2024, Sharlatan Hellseher wrote:
> 
> > Hi Guix!
> >
> > I am happy to have been granted commit access and I am ready to help
> > review pending issues and prepare queued packages for GNU packages in
> > astronomy. I would like to concentrate on the packages covered by the
> > Go, Lisp, Python, and Science teams.
> >
> > I would like to thank the Guix team for allowing me to become a
> > committer member. I am looking forward to continuing our collaboration.
> >
> > If anyone has a good patch review workflow using Emacs, Gnus, and Magit,
> > I would appreciate it ;-)
> 
> Hey, welcome.
> 
> I use this Emacs code to apply patches, with emacs-debbugs and Gnus.
> 
> --8<---cut here---start->8---
> (defun my-apply-patch-or-abort ()
>   (interactive)
>   (my-apply-patch-internal "git am || git am --abort"))
> 
> (defun my-apply-patch ()
>   (interactive)
>   (my-apply-patch-internal "git am --reject"))
> 
> (defun my-apply-patch-or-abort-attachment (n)
>   (interactive "P")
>   (my-apply-patch-attachment-internal "git am || git am --abort" n))
> 
> (defun my-apply-patch-attachment (n)
>   (interactive "P")
>   (my-apply-patch-attachment-internal "git am --reject" n))
> 
> (defun my-apply-patch-attachment-internal (cmd n)
>   "C-u  M-x my-apply-..."
>   (let ((git-dir "~/src/guix"))
> (save-window-excursion
>   (gnus-article-part-wrapper
>n
>(lambda (handle)
>  (let ((default-directory git-dir))
>(mm-pipe-part handle cmd)))
> 
> (defun my-apply-patch-internal (cmd)
>   "Works with a selection of articles."
>   (let ((git-dir "~/src/guix")
> (articles (gnus-summary-work-articles nil)))
> (save-window-excursion
>   (while articles
> (gnus-summary-goto-subject (pop articles))
> (with-current-buffer gnus-summary-buffer
>   (let ((default-directory git-dir))
> (gnus-summary-save-in-pipe cmd))
>   (gnus-article-hide-headers))
> --8<---cut here---end--->8---
> 
> Just my 2 cents, I imagine every person here has their own workflow.

I'm going to suggest 'git am -3' that someone else here suggested to me.
When a patch fails to apply cleanly git will try harder and leave the
failed-to-apply bits inside the code, making it easier to clean-up the
patch than to manually apply it.

-- 
Efraim Flashner  רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted


signature.asc
Description: PGP signature

Re: Commit Access: Sharlatan Hellseher

[Clément Lassieur]

On Thu, Jan 11 2024, Sharlatan Hellseher wrote:

> Hi Guix!
>
> I am happy to have been granted commit access and I am ready to help
> review pending issues and prepare queued packages for GNU packages in
> astronomy. I would like to concentrate on the packages covered by the
> Go, Lisp, Python, and Science teams.
>
> I would like to thank the Guix team for allowing me to become a
> committer member. I am looking forward to continuing our collaboration.
>
> If anyone has a good patch review workflow using Emacs, Gnus, and Magit,
> I would appreciate it ;-)

Hey, welcome.

I use this Emacs code to apply patches, with emacs-debbugs and Gnus.

--8<---cut here---start->8---
(defun my-apply-patch-or-abort ()
  (interactive)
  (my-apply-patch-internal "git am || git am --abort"))

(defun my-apply-patch ()
  (interactive)
  (my-apply-patch-internal "git am --reject"))

(defun my-apply-patch-or-abort-attachment (n)
  (interactive "P")
  (my-apply-patch-attachment-internal "git am || git am --abort" n))

(defun my-apply-patch-attachment (n)
  (interactive "P")
  (my-apply-patch-attachment-internal "git am --reject" n))

(defun my-apply-patch-attachment-internal (cmd n)
  "C-u  M-x my-apply-..."
  (let ((git-dir "~/src/guix"))
(save-window-excursion
  (gnus-article-part-wrapper
   n
   (lambda (handle)
 (let ((default-directory git-dir))
   (mm-pipe-part handle cmd)))

(defun my-apply-patch-internal (cmd)
  "Works with a selection of articles."
  (let ((git-dir "~/src/guix")
(articles (gnus-summary-work-articles nil)))
(save-window-excursion
  (while articles
(gnus-summary-goto-subject (pop articles))
(with-current-buffer gnus-summary-buffer
  (let ((default-directory git-dir))
(gnus-summary-save-in-pipe cmd))
  (gnus-article-hide-headers))
--8<---cut here---end--->8---

Just my 2 cents, I imagine every person here has their own workflow.

Clément

Re: Commit Access: jgart

[John Kehayias]

Welcome and congrats! I've always appreciated your enthusiasm and looking for 
ways to improve the Guix experience.

(apologies for formatting and top posting, email client limitations right now)

 Original Message 
On May 16, 2023, 9:28 AM, jgart wrote:

> Hi Guixers, Thanks for granting me commit access. I'm looking forward to 
> helping out with patch review, with a particular focus on moving patches 
> along for the Python team. I also intend to continue contributing more 
> packages, updates, and improvements. Thanks again for granting me the 
> privilege of commit access and I am looking forward to continuing our 
> collaborations. all best, jgart (Jorge Gomez)

Re: Commit Access: jgart

[Ekaitz Zarraga]

Felicidades!


--- Original Message ---
On Tuesday, May 16th, 2023 at 2:28 AM, jgart  wrote:


> Hi Guixers,
> 
> Thanks for granting me commit access. I'm looking forward to helping out with 
> patch review, with a
> particular focus on moving patches along for the Python team.
> 
> I also intend to continue contributing more packages, updates, and 
> improvements.
> 
> Thanks again for granting me the privilege of commit access and I am looking 
> forward to continuing our collaborations.
> 
> all best,
> 
> jgart (Jorge Gomez)

Re: Commit Access: jgart

[宋文武]

"jgart"  writes:

> Hi Guixers,
>
> Thanks for granting me commit access. I'm looking forward to helping out with 
> patch review, with a
> particular focus on moving patches along for the Python team.
>
> I also intend to continue contributing more packages, updates, and 
> improvements.
>
> Thanks again for granting me the privilege of commit access and I am looking 
> forward to continuing our collaborations.
>
> all best,

Hi jgart, congrats and thank you for joining the party!  
Always a pleasure working with you :)

Re: Commit Access

[Tobias Geerinckx-Rice]

Hi Vinicius,

Vinicius Monego 写道：
I was granted commit access to the repository [1] one hour 
ago. I am
signing this mail with the key that will be used to sign 
commits. My

public key can be found at [2] and [3].


Thanks, and welcome aboard! :-)

Toot,

T G-R


signature.asc
Description: PGP signature

Re: Commit Access

[Maxim Cournoyer]

Hi Vinicius,

Vinicius Monego  writes:

> Hi everyone,
>
> I was granted commit access to the repository [1] one hour ago. I am
> signing this mail with the key that will be used to sign commits. My
> public key can be found at [2] and [3].
>
> Looking forward to working with all of you.
>
> Vinicius

Just to confirm, that we are receiving your messages to the list
correctly, and they their GPG signature validates.

Thank you, and congrats for stepping up to become a committer.

Maxim

Re: Commit Access to Emacs-Guix

[Pierre Neidhardt]

That's great news?

Do you have a link to the project?
How do you intend to receive contributions?  Via a mailing list?

Cheers!

-- 
Pierre Neidhardt
https://ambrevar.xyz/


signature.asc
Description: PGP signature

Re: Commit Access

[Amin Bandali]

Hello,

Leo Prikler writes:

> Hello everyone,
>
> earlier today, I was granted commit access to the repository [1].
[...]

Welcome, Leo!


signature.asc
Description: PGP signature

Re: Commit Access

[Tobias Geerinckx-Rice]

Leo,

Leo Prikler 写道：
earlier today, I was granted commit access to the repository 
[1].  This
message is signed with the key I will use for signing my 
commits.  It

should have the following info:


Excellent news.  Welcome!

Kind regards,

T G-R


signature.asc
Description: PGP signature

Re: Commit access

[Ludovic Courtès]

Hi!

Miguel Ángel Arruga Vivas  skribis:

> I'm happy to announce with this message my access to the repository and
> the key I'll use to sign the commits.  This text has been signed with
> it, which has the following information and fingerprint:
>
> pub   rsa3072 2020-09-09 [SC] [expires: 2022-01-01]
>   888784C41459ACCB83E7E84C634C6E8979FABEC2
> uid   [ultimate] Miguel Ángel Arruga Vivas 
> sub   rsa3072 2020-09-09 [E] [expires: 2022-01-01]

Welcome aboard!

I was going to invite you to take a look at
,
and then I realized you had definitely read every word of it.  :-)

Happy hacking!

Ludo’.


signature.asc
Description: PGP signature

Re: Commit access

[Kei Kebreau]

Miguel Ángel Arruga Vivas  writes:

> Hello, everybody!
>
> I'm happy to announce with this message my access to the repository and
> the key I'll use to sign the commits.  This text has been signed with
> it, which has the following information and fingerprint:
>
> pub   rsa3072 2020-09-09 [SC] [expires: 2022-01-01]
>   888784C41459ACCB83E7E84C634C6E8979FABEC2
> uid   [ultimate] Miguel Ángel Arruga Vivas 
> sub   rsa3072 2020-09-09 [E] [expires: 2022-01-01]
>
> Happy hacking!
> Miguel

Good key and good signature.  Great to have you with us, Miguel!

Kind regards,
Kei


signature.asc
Description: PGP signature

Re: Commit access

[pelzflorian (Florian Pelz)]

On Sat, Oct 17, 2020 at 03:57:19PM +0200, Miguel Ángel Arruga Vivas wrote:
> Hello, everybody!
> 
> I'm happy to announce with this message my access to the repository and
> the key I'll use to sign the commits.  This text has been signed with
> it, which has the following information and fingerprint:
> 
> pub   rsa3072 2020-09-09 [SC] [expires: 2022-01-01]
>   888784C41459ACCB83E7E84C634C6E8979FABEC2
> uid   [ultimate] Miguel Ángel Arruga Vivas 
> sub   rsa3072 2020-09-09 [E] [expires: 2022-01-01]
> 
> Happy hacking!
> Miguel

I’m happy you’re with us!

Regards,
Florian

signature.asc
Description: PGP signature

Re: Commit access

[Brett Gilio]

Miguel Ángel Arruga Vivas  writes:

> Hello, everybody!
>
> I'm happy to announce with this message my access to the repository and
> the key I'll use to sign the commits.  This text has been signed with
> it, which has the following information and fingerprint:
>
> pub   rsa3072 2020-09-09 [SC] [expires: 2022-01-01]
>   888784C41459ACCB83E7E84C634C6E8979FABEC2
> uid   [ultimate] Miguel Ángel Arruga Vivas 
> sub   rsa3072 2020-09-09 [E] [expires: 2022-01-01]
>
> Happy hacking!
> Miguel
>

Welcome!

-- 
Brett M. Gilio
bre...@gnu.org
https://brettgilio.com/
E82A C026 95D6 FF02 43CA 1E5C F6C5 2DD1 BA27 CB87

Re: Commit access

[Tobias Geerinckx-Rice]

Miguel,

Miguel Ángel Arruga Vivas 写道：
I'm happy to announce with this message my access to the 
repository and

the key I'll use to sign the commits.


Welcome aboard!  \o/

I downloaded your key from Savannah[0] and it all checks out. 
Don't forget to update it next year :-)


Kind regards,

T G-R

[0]: http://savannah.gnu.org/people/viewgpg.php?user_id=90368


signature.asc
Description: PGP signature

Re: Commit access for Kei Kebreau

[Ludovic Courtès]

Hi,

Kei Kebreau  skribis:

> On Thu, 19 May 2016 12:21:06 +0300
> Alex Kost  wrote:
>
>> Hello, Kei!
>> 
>> Would you like to have commit access to the guix git repo? so that you
>> can push the patches yourself (after they are reviewed).  For this,
>> you need to create an account on .  Then
>> one of the project admins (probably Ludovic) can add you to
>> .
>> 
>> Make sure to read HACKING file in the guix repo, and if anything is
>> not clear, please ask.
>> 
>
> I would like that, thank you! My user name on Savannah is kkebreau.

Done, welcome!  :-)

Please do read ‘HACKING’.  Also note that, although this is not
documented yet, all commits must now be signed.  See
.

Thank you!

Ludo’.


signature.asc
Description: PGP signature