Re: automake-1.16.2
On Thu, Mar 26, 2020 at 08:06:44PM +0100, Marius Bakke wrote: > Vincent Legoll writes: > > For the tests they will be native-inputs, so only increase dependencies > > for building, is that a problem ? I would have thought that test coverage > > is more important (especially on such important packages), I'm probably > > missing something... > > For such heavy-impact packages, an important consideration is that any > dependency we add gets the same impact. Additionally, test suites can be less important for core packages like automake, because the real test is building the distro.
Re: automake-1.16.2
Vincent Legoll writes: >> We’d probably have to decide on a case by case basis which additional >> dependencies we’d like to add, given that Automake has a lot of >> dependents. > > For the tests they will be native-inputs, so only increase dependencies > for building, is that a problem ? I would have thought that test coverage > is more important (especially on such important packages), I'm probably > missing something... For such heavy-impact packages, an important consideration is that any dependency we add gets the same impact. Hypothetically, let's say Automake has an optional dependency on 'git' for some tests. Providing git as a native-input means that we can no longer update git outside of the "core-updates" cycle, because that would cause too many rebuilds. Of course there are ways to work around such cycles, but it complicates the dependency graphs. signature.asc Description: PGP signature
Re: automake-1.16.2
On Thu, Mar 26, 2020 at 3:07 PM Ludovic Courtès wrote: > > Trying to update automake to the latest, I'm seeing lots > > of skipped tests because of missing native-inputs, would > > it be OK toadd those to enable more tests to be run ? > > I hadn’t seen your message and added Automake 1.16.2 in commit > 72a5cc53586080e75ae4ee80f3a2467ff30c4f5e. No problem, I've seen you added that. > We’d probably have to decide on a case by case basis which additional > dependencies we’d like to add, given that Automake has a lot of > dependents. For the tests they will be native-inputs, so only increase dependencies for building, is that a problem ? I would have thought that test coverage is more important (especially on such important packages), I'm probably missing something... -- Vincent Legoll
Re: automake-1.16.2
Hi! Vincent Legoll skribis: > Trying to update automake to the latest, I'm seeing lots > of skipped tests because of missing native-inputs, would > it be OK toadd those to enable more tests to be run ? I hadn’t seen your message and added Automake 1.16.2 in commit 72a5cc53586080e75ae4ee80f3a2467ff30c4f5e. Most tests are automatically skipped when the tool they need is missing, except for the one mentioned in the commit. We’d probably have to decide on a case by case basis which additional dependencies we’d like to add, given that Automake has a lot of dependents. Thanks, Ludo’.
automake-1.16.2
Hi, Trying to update automake to the latest, I'm seeing lots of skipped tests because of missing native-inputs, would it be OK toadd those to enable more tests to be run ? -- Vincent Legoll
