Re: bug#66964: Request for merging "mesa-updates" branch

[Kaelyn]

Hi,

On Tuesday, November 14th, 2023 at 12:36 PM, Kaelyn 
 wrote:

> 
> Hi John,
> 
> On Tuesday, November 14th, 2023 at 12:11 PM, John Kehayias 
> john.kehay...@protonmail.com wrote:
> 
> > Hi Kaelyn,
> > 
> > On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
> > 
> > > Hi,
> > > 
> > > I've just submitted a pair of patches for the mesa-updates branch:
> > > https://issues.guix.gnu.org/67136 updating xorgproto and
> > > xorg-server-xwayland. The xorgproto is a high-impact update (guix
> > > refresh reports rebuilding 8710 packages would ensure 22871 dependent
> > > packages are rebuilt), but required to update to the latest xwayland
> > > as xwayland requires a newer version of presentproto than in the
> > > current guix xorgproto package. The updating and ungrafting of mesa
> > > and a number of X.org related libraries seemed like a good time (and
> > > place) to update xorgproto as well.
> > > 
> > > Cheers,
> > > Kaelyn
> > 
> > Thanks for the patches. I think mesa-updates in this current iteration
> > is set on builds (ended up being a lot more due to the ungrafting but
> > seems done on our main architectures for several days now). I had to
> > make some other changes to fix some larger breakages but at this point I
> > think it will just be taking us back in the build queue too much.
> > 
> > So I think it would make more sense on the next big rebuild, either
> > core-updates (talk about doing that with more ungrafts right now) or
> > I'll do mesa-updates again when the next release of mesa hits. Or maybe
> > it makes sense to just do another branch for xwayland?
> > 
> > Open to ideas! I'll send a separate message soon on the status of
> > mesa-updates and see what people think, but my thought was to merge this
> > to master in the next day or so if there are no objections.
> > 
> > Thanks!
> > John
> 
> 
> No worries! I realize I was a little late to the party for the mesa-updates 
> branch (had some ongoing technical issues), so if core-updates is still early 
> enough in the process I think it would be good to push the changes to that 
> branch. The current xwayland is pretty old, and the updated version has quite 
> a few CVEs fixed in comparison (just 
> https://www.phoronix.com/news/X.Org-Halloween-Bugs-2023 and 
> https://www.phoronix.com/news/X.Org-Server-Holiday-2022 list 8 CVEs fixed 
> between xwayland 21.1.3 and 23.2.2).

I forgot to sent an email when I did this, but a few weeks ago I updated the 
xorgproto/xwayland update ticket (#66964) to refer to core-updates instead of 
mesa-updates and sent in a v2 of the patches rebased against core-updates.

Cheers,
Kaelyn

Re: bug#66964: Request for merging "mesa-updates" branch

[John Kehayias]

Guix-ers,

On Wed, Nov 15, 2023 at 08:28 AM, Efraim Flashner wrote:

> On Tue, Nov 14, 2023 at 08:11:08PM +, John Kehayias wrote:
>> Hi Kaelyn,
>>
>> On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
>>
>> > Hi,
>> >
>> > I've just submitted a pair of patches for the mesa-updates branch:
>> >  updating xorgproto and
>> > xorg-server-xwayland. The xorgproto is a high-impact update (guix
>> > refresh reports rebuilding 8710 packages would ensure 22871 dependent
>> > packages are rebuilt), but required to update to the latest xwayland
>> > as xwayland requires a newer version of presentproto than in the
>> > current guix xorgproto package. The updating and ungrafting of mesa
>> > and a number of X.org related libraries seemed like a good time (and
>> > place) to update xorgproto as well.
>> >
>> > Cheers,
>> > Kaelyn
>>
>> Thanks for the patches. I think mesa-updates in this current iteration
>> is set on builds (ended up being a lot more due to the ungrafting but
>> seems done on our main architectures for several days now). I had to
>> make some other changes to fix some larger breakages but at this point I
>> think it will just be taking us back in the build queue too much.
>>
>> So I think it would make more sense on the next big rebuild, either
>> core-updates (talk about doing that with more ungrafts right now) or
>> I'll do mesa-updates again when the next release of mesa hits. Or maybe
>> it makes sense to just do another branch for xwayland?
>>
>> Open to ideas! I'll send a separate message soon on the status of
>> mesa-updates and see what people think, but my thought was to merge this
>> to master in the next day or so if there are no objections.
>
> If the mesa branch is ready to merge so soon then I think we should just
> get that merged and then I'll rebase the rust-team branch on top of new
> master.  The rust-team branch is also ready to merge, but we're way
> behind on aarch64 substitutes.  Either way the substitute servers will
> be rebuilding all of rust so I think it'd be better to merge in
> mesa-updates and then do rust.

Merged as 79765b40fd9b4921b531284c589ace8a2c89a6ea woop!

We got good coverage on x86_64, i686, powerpc64le, aarch64 (all
-linux) especially from Bordeaux. Unfortunately armhf got stuck even
with prodding and waiting, but hopefully it will recover. There may be
some slight catching up across the board with recent issues on Berlin,
but prior to things getting wonky it was looking good (of course all
that happened right when I wanted to merge the other day).

Thanks to Efraim for some fixes and especially getting non-x86 in
better shape.

Feel free anyone to ping me on patches/bugs due to this merge. And
please enjoy updated mesa, fixes to gtk4 applications, some less
grafts, and more.

John

PS: I'll return to mesa-updates soon with next major mesa update and
pending related patches, or in core-updates if that is getting close.

Re: bug#66964: Request for merging "mesa-updates" branch

[Efraim Flashner]

On Tue, Nov 14, 2023 at 08:11:08PM +, John Kehayias wrote:
> Hi Kaelyn,
> 
> On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
> 
> > Hi,
> >
> > I've just submitted a pair of patches for the mesa-updates branch:
> >  updating xorgproto and
> > xorg-server-xwayland. The xorgproto is a high-impact update (guix
> > refresh reports rebuilding 8710 packages would ensure 22871 dependent
> > packages are rebuilt), but required to update to the latest xwayland
> > as xwayland requires a newer version of presentproto than in the
> > current guix xorgproto package. The updating and ungrafting of mesa
> > and a number of X.org related libraries seemed like a good time (and
> > place) to update xorgproto as well.
> >
> > Cheers,
> > Kaelyn
> 
> Thanks for the patches. I think mesa-updates in this current iteration
> is set on builds (ended up being a lot more due to the ungrafting but
> seems done on our main architectures for several days now). I had to
> make some other changes to fix some larger breakages but at this point I
> think it will just be taking us back in the build queue too much.
> 
> So I think it would make more sense on the next big rebuild, either
> core-updates (talk about doing that with more ungrafts right now) or
> I'll do mesa-updates again when the next release of mesa hits. Or maybe
> it makes sense to just do another branch for xwayland?
> 
> Open to ideas! I'll send a separate message soon on the status of
> mesa-updates and see what people think, but my thought was to merge this
> to master in the next day or so if there are no objections.

If the mesa branch is ready to merge so soon then I think we should just
get that merged and then I'll rebase the rust-team branch on top of new
master.  The rust-team branch is also ready to merge, but we're way
behind on aarch64 substitutes.  Either way the substitute servers will
be rebuilding all of rust so I think it'd be better to merge in
mesa-updates and then do rust.

-- 
Efraim Flashner  רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted


signature.asc
Description: PGP signature

Re: bug#66964: Request for merging "mesa-updates" branch

[Kaelyn]

Hi John,

On Tuesday, November 14th, 2023 at 12:11 PM, John Kehayias 
 wrote:

> 
> Hi Kaelyn,
> 
> On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
> 
> > Hi,
> > 
> > I've just submitted a pair of patches for the mesa-updates branch:
> > https://issues.guix.gnu.org/67136 updating xorgproto and
> > xorg-server-xwayland. The xorgproto is a high-impact update (guix
> > refresh reports rebuilding 8710 packages would ensure 22871 dependent
> > packages are rebuilt), but required to update to the latest xwayland
> > as xwayland requires a newer version of presentproto than in the
> > current guix xorgproto package. The updating and ungrafting of mesa
> > and a number of X.org related libraries seemed like a good time (and
> > place) to update xorgproto as well.
> > 
> > Cheers,
> > Kaelyn
> 
> 
> Thanks for the patches. I think mesa-updates in this current iteration
> is set on builds (ended up being a lot more due to the ungrafting but
> seems done on our main architectures for several days now). I had to
> make some other changes to fix some larger breakages but at this point I
> think it will just be taking us back in the build queue too much.
> 
> So I think it would make more sense on the next big rebuild, either
> core-updates (talk about doing that with more ungrafts right now) or
> I'll do mesa-updates again when the next release of mesa hits. Or maybe
> it makes sense to just do another branch for xwayland?
> 
> Open to ideas! I'll send a separate message soon on the status of
> mesa-updates and see what people think, but my thought was to merge this
> to master in the next day or so if there are no objections.
> 
> Thanks!
> John

No worries! I realize I was a little late to the party for the mesa-updates 
branch (had some ongoing technical issues), so if core-updates is still early 
enough in the process I think it would be good to push the changes to that 
branch. The current xwayland is pretty old, and the updated version has quite a 
few CVEs fixed in comparison (just 
https://www.phoronix.com/news/X.Org-Halloween-Bugs-2023 and 
https://www.phoronix.com/news/X.Org-Server-Holiday-2022 list 8 CVEs fixed 
between xwayland 21.1.3 and 23.2.2).

Cheers,
Kaelyn

Re: bug#66964: Request for merging "mesa-updates" branch

[John Kehayias]

Hi Kaelyn,

On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:

> Hi,
>
> I've just submitted a pair of patches for the mesa-updates branch:
>  updating xorgproto and
> xorg-server-xwayland. The xorgproto is a high-impact update (guix
> refresh reports rebuilding 8710 packages would ensure 22871 dependent
> packages are rebuilt), but required to update to the latest xwayland
> as xwayland requires a newer version of presentproto than in the
> current guix xorgproto package. The updating and ungrafting of mesa
> and a number of X.org related libraries seemed like a good time (and
> place) to update xorgproto as well.
>
> Cheers,
> Kaelyn

Thanks for the patches. I think mesa-updates in this current iteration
is set on builds (ended up being a lot more due to the ungrafting but
seems done on our main architectures for several days now). I had to
make some other changes to fix some larger breakages but at this point I
think it will just be taking us back in the build queue too much.

So I think it would make more sense on the next big rebuild, either
core-updates (talk about doing that with more ungrafts right now) or
I'll do mesa-updates again when the next release of mesa hits. Or maybe
it makes sense to just do another branch for xwayland?

Open to ideas! I'll send a separate message soon on the status of
mesa-updates and see what people think, but my thought was to merge this
to master in the next day or so if there are no objections.

Thanks!
John