Re: [hackers] [dmenu] [PATCH] Typo Patch
On Thu, Aug 6, 2015 at 4:20 AM, Eric Pruitt eric.pru...@gmail.com wrote: This patch fixes a typo in dmenu. Hi! Applied! Thanks for the patch. Kind regards, Hiltjo
[hackers] [dmenu] Fixed typo introduced by shared code || Eric Pruitt
commit bbf7b95dc93a47dbb5a4143b903797dc97197515 Author: Eric Pruitt eric.pru...@gmail.com AuthorDate: Wed Aug 5 19:19:14 2015 -0700 Commit: Hiltjo Posthuma hil...@codemadness.org CommitDate: Thu Aug 6 12:47:51 2015 +0200 Fixed typo introduced by shared code diff --git a/dmenu.c b/dmenu.c index 11b6e8d..f0bc176 100644 --- a/dmenu.c +++ b/dmenu.c @@ -118,7 +118,7 @@ main(int argc, char *argv[]) { if(!setlocale(LC_CTYPE, ) || !XSupportsLocale()) fputs(warning: no locale support\n, stderr); if(!(dpy = XOpenDisplay(NULL))) - die(dwm: cannot open display\n); + die(dmenu: cannot open display\n); screen = DefaultScreen(dpy); root = RootWindow(dpy, screen); sw = DisplayWidth(dpy, screen);
Re: [hackers] [PATCH][vis] Change op_put to repeat put operation count times
On Thu, Jul 30, 2015 at 09:14:06PM +0200, Silvan Jegen wrote: On Thu, Jul 30, 2015 at 06:51:21PM +0200, Marc André Tanner wrote: On Wed, Jul 29, 2015 at 08:52:07PM +0200, Silvan Jegen wrote: This is the quick-and-dirty way to implement a feature I miss from Vim. Thanks. Yes the count/repetition code needs an overhaul. I'm not sure whether it makes sense to move it into the operator implementation themselves though. Feels wrong. Also there are multiple operators which will need it. For example when . repeats the last insertion a count Yes, that is what I thought as well. If we put it into the operators we will have to duplicate the repetition code for each operator. Ideally, we would not have to do that. Turns out this is not that simple. I went with your approach for now. gp and gP should now also be recognized, hope it works as expected. Thanks! -- Marc André Tanner http://www.brain-dump.org/ GPG key: CF7D56C0