Re: [hackers] [st][patch] Increase the buffer size for escape sequences

2018-09-23 Thread Ingo Heimbach
What is incorrect? 

Am 23. September 2018 14:12:23 MESZ schrieb Hiltjo Posthuma 
:
>On Sun, Sep 23, 2018 at 12:12:27PM +0200, Ingo Heimbach wrote:
>> Before this commit, long escape sequences (e.g. OSC 52) could be
>trimmed
>> due to a quite small escape sequence buffer. This commit increases
>the
>> escape sequence buffer from 128 to 1048576 UTF-8 characters.
>> ---
>>  st.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/st.c b/st.c
>> index 46c954b..e9d4536 100644
>> --- a/st.c
>> +++ b/st.c
>> @@ -31,7 +31,7 @@
>>  /* Arbitrary sizes */
>>  #define UTF_INVALID   0xFFFD
>>  #define UTF_SIZ   4
>> -#define ESC_BUF_SIZ   (128*UTF_SIZ)
>> +#define ESC_BUF_SIZ   (1048576*UTF_SIZ)
>>  #define ESC_ARG_SIZ   16
>>  #define STR_BUF_SIZ   ESC_BUF_SIZ
>>  #define STR_ARG_SIZ   ESC_ARG_SIZ
>> -- 
>> 2.19.0
>> 
>> 
>
>This is incorrect.
>
>-- 
>Kind regards,
>Hiltjo


Re: [hackers] [st][patch] Increase the buffer size for escape sequences

2018-09-23 Thread Hiltjo Posthuma
On Sun, Sep 23, 2018 at 12:12:27PM +0200, Ingo Heimbach wrote:
> Before this commit, long escape sequences (e.g. OSC 52) could be trimmed
> due to a quite small escape sequence buffer. This commit increases the
> escape sequence buffer from 128 to 1048576 UTF-8 characters.
> ---
>  st.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/st.c b/st.c
> index 46c954b..e9d4536 100644
> --- a/st.c
> +++ b/st.c
> @@ -31,7 +31,7 @@
>  /* Arbitrary sizes */
>  #define UTF_INVALID   0xFFFD
>  #define UTF_SIZ   4
> -#define ESC_BUF_SIZ   (128*UTF_SIZ)
> +#define ESC_BUF_SIZ   (1048576*UTF_SIZ)
>  #define ESC_ARG_SIZ   16
>  #define STR_BUF_SIZ   ESC_BUF_SIZ
>  #define STR_ARG_SIZ   ESC_ARG_SIZ
> -- 
> 2.19.0
> 
> 

This is incorrect.

-- 
Kind regards,
Hiltjo



[hackers] [st][patch] Increase the buffer size for escape sequences

2018-09-23 Thread Ingo Heimbach

Before this commit, long escape sequences (e.g. OSC 52) could be trimmed
due to a quite small escape sequence buffer. This commit increases the
escape sequence buffer from 128 to 1048576 UTF-8 characters.
---
 st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/st.c b/st.c
index 46c954b..e9d4536 100644
--- a/st.c
+++ b/st.c
@@ -31,7 +31,7 @@
 /* Arbitrary sizes */
 #define UTF_INVALID   0xFFFD
 #define UTF_SIZ   4
-#define ESC_BUF_SIZ   (128*UTF_SIZ)
+#define ESC_BUF_SIZ   (1048576*UTF_SIZ)
 #define ESC_ARG_SIZ   16
 #define STR_BUF_SIZ   ESC_BUF_SIZ
 #define STR_ARG_SIZ   ESC_ARG_SIZ
--
2.19.0




Re: [hackers] [sbase] [PATCH] ed: Changed delimiter to fix unterminated TODO comment

2018-09-23 Thread Quentin Rameau
Hello Firasuke,

>  1 file changed, 1 insertion(+), 1 deletion(-) .
> - *s/ *//
> + *s# *##

Applied, thanks!



[hackers] [sbase] ed: Changed delimiter to fix unterminated TODO comment || Firas Khalil Khana

2018-09-23 Thread git
commit a1627b94195e83dba5b7b483d5af780e316cb73f
Author: Firas Khalil Khana 
AuthorDate: Sat Sep 22 13:30:21 2018 +0300
Commit: Quentin Rameau 
CommitDate: Sun Sep 23 11:02:31 2018 +0200

ed: Changed delimiter to fix unterminated TODO comment

diff --git a/ed.c b/ed.c
index 6a2f231..b844e86 100644
--- a/ed.c
+++ b/ed.c
@@ -22,7 +22,7 @@
  *0a
  *   Line
  *.
- *s/ *//
+ *s# *##
  * o cat <