[hackers] [scroll] Fix typo and spaces with adjustments from me. || Steve Ward

[git]

commit 91719e47d5384a79a3fb76ee36a3980d0e3f56f3
Author: Steve Ward 
AuthorDate: Wed May 6 22:54:30 2020 -0400
Commit: Jan Klemkow 
CommitDate: Sun May 10 22:41:12 2020 +0200

Fix typo and spaces with adjustments from me.

diff --git a/config.def.h b/config.def.h
index c6e0c0e..36b1a45 100644
--- a/config.def.h
+++ b/config.def.h
@@ -3,13 +3,13 @@
  * Use "cat -v" to figure out favorite key combination.
  *
  * lines is the number of lines scrolled up or down.
- * If lines is negative, its the fraction of the terminal size.
+ * If lines is negative, it's the fraction of the terminal size.
  */
 
 struct rule rules[] = {
/* sequence eventlines */
-   {"\033[5;2~",   SCROLL_UP,   -1},   /* [Shift] + [PageUP] */
-   {"\033[6;2~",   SCROLL_DOWN, -1},   /* [Shift] + [PageDown] */
-   {"\031",SCROLL_UP,1},   /* mouse wheel up */
-   {"\005",SCROLL_DOWN,  1}/* mouse wheel Down */
+   {"\033[5;2~",   SCROLL_UP,   -1},   /* [Shift] + [PageUP] */
+   {"\033[6;2~",   SCROLL_DOWN, -1},   /* [Shift] + [PageDown] */
+   {"\031",SCROLL_UP,1},   /* mouse wheel up */
+   {"\005",SCROLL_DOWN,  1},   /* mouse wheel Down */
 };

Re: [hackers] [dwm][patch] Fix transparent borders

[Jakub Leszczak]

So how does the review process look like? When I push commit to wiki do I
need to write an email to the author and get his approval and show it to
you?

In general if I were to add new patch to wiki how would the review process
look like? Does pushing autogenerates an email thread?

Re: [hackers] [dwm][patch] Fix transparent borders

[Hiltjo Posthuma]

On Sun, May 10, 2020 at 02:30:56PM +0200, Jakub Leszczak wrote:
> > Maybe it can be added to the wiki page for the alpha patch?
> 
> To me it is also OK.  Like I said I personally didn't even think it is
> worthy of a patch.
> And if you don't want this to be part of mainline, then I guess I
> could add some text on alpha patch page.
> 
> > The wiki is public and can be pushed to.
> 
> I have other code which could make for a good candidate for a patch.
> What is a process of adding such patch to the page?
> I would guess I should firstly write an email and get a green light
> from you, and then create/push a commit in the wiki repository, right?
> 

Hi,

Anyone can contribute to the wiki: https://suckless.org/wiki/

There are some rules and guidelines to keep the wiki clean and usable for
everyone.

For modifying a certain page it might be good to contact the author(s) of the
alpha patch when you add or modify something to the page.

After review a script is run by the administrators/moderators and the HTML is
generated on the site. This happens every few days or so.

Thanks,

-- 
Kind regards,
Hiltjo

Re: [hackers] [dwm][patch] Fix transparent borders

[Jakub Leszczak]

> Maybe it can be added to the wiki page for the alpha patch?

To me it is also OK.  Like I said I personally didn't even think it is
worthy of a patch.
And if you don't want this to be part of mainline, then I guess I
could add some text on alpha patch page.

> The wiki is public and can be pushed to.

I have other code which could make for a good candidate for a patch.
What is a process of adding such patch to the page?
I would guess I should firstly write an email and get a green light
from you, and then create/push a commit in the wiki repository, right?

Re: [hackers] [dwm][patch] Fix transparent borders

[Hiltjo Posthuma]

On Sun, May 10, 2020 at 11:37:02AM +0200, maxardis wrote:
> Hi,
> 
> I personally didn't think this is worthy of a patch, but some people
> actually find it useful.
> 
> Issue is that by default when using dwm with compositing window
> manager (xcompmgr, picom) whenever client (most often it is terminal)
> has transparent background it's borders also become transparent.
> 
> This is not what people expect or want and hence the need to fix that.
> One possible solution is to use alpha patch.  But some people don't
> know that it fixes the issue (description of alpha patch only says
> about adding opacity to statusbar), and others find it an overkill or
> have difficulty applying the patch.
> 
> In the end all that is needed is just one line of code.  I don't know
> wheter it should become part of mainline or a patch.
> 
> Commit: 
> 
> 
> Br,
> Jakub Leszczak
> 

Hi,

To me this is not an issue, but a preference. I don't like alpha transparency
personally.

"This is not what people expect or want and hence the need to fix that."
Is wrong.

Regardless, thanks for sending code / feedback. Maybe it can be added to the
wiki page for the alpha patch? The wiki is public and can be pushed to.

-- 
Kind regards,
Hiltjo

Re: [hackers] [dwm][patch] Fix transparent borders

[maxardis]

> Please simply attach patches to email directly instead of redirecting

Sure.  No problem.
From 1529909466206016f2101457bbf37c67195714c8 Mon Sep 17 00:00:00 2001
From: Jakub Leszczak 
Date: Fri, 22 Nov 2019 10:46:53 +0800
Subject: [PATCH] Fix transparent borders

When terminal has transparency then its borders also become transparent.
Fix it by removing transparency from any pixels drawn.
---
 drw.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drw.c b/drw.c
index 8fd1ca4..490a592 100644
--- a/drw.c
+++ b/drw.c
@@ -202,6 +202,8 @@ drw_clr_create(Drw *drw, Clr *dest, const char *clrname)
 	   DefaultColormap(drw->dpy, drw->screen),
 	   clrname, dest))
 		die("error, cannot allocate color '%s'", clrname);
+
+	dest->pixel |= 0xff << 24;
 }
 
 /* Wrapper to create color schemes. The caller has to call free(3) on the
-- 
2.26.2

Re: [hackers] [dwm][patch] Fix transparent borders

[Quentin Rameau]

> Hi,

Hi Jakub,

> Commit: 
> 

Please simply attach patches to email directly instead of redirecting
to third-party prodivers/protocols.

[hackers] [dwm][patch] Fix transparent borders

[maxardis]

Hi,

I personally didn't think this is worthy of a patch, but some people
actually find it useful.

Issue is that by default when using dwm with compositing window
manager (xcompmgr, picom) whenever client (most often it is terminal)
has transparent background it's borders also become transparent.

This is not what people expect or want and hence the need to fix that.
One possible solution is to use alpha patch.  But some people don't
know that it fixes the issue (description of alpha patch only says
about adding opacity to statusbar), and others find it an overkill or
have difficulty applying the patch.

In the end all that is needed is just one line of code.  I don't know
wheter it should become part of mainline or a patch.

Commit: 


Br,
Jakub Leszczak