Re: [hackers] [scroll] Fix make on OpenBSD || Jochen Sprickerhof

[Quentin Rameau]

> Sure, provide a patch to OpenBSD ;).

Glad that you agree.
The point is that this is not the correct place to fix this issue.

> Does it break anything this way?

It might break reader's understanding about how make works.

Re: [hackers] [scroll] Fix make on OpenBSD || Jochen Sprickerhof

[Jochen Sprickerhof]

Hi Quentin,

* Quentin Rameau  [2020-04-12 08:34]:

Fix make on OpenBSD

-scroll: config.h
+scroll: scroll.c config.h


I think it'd be better to fix OpenBSD make or let OpenBSD port
maintainers to patch the software rather than pushing changes do
standard code because of some buggy implementations.


Sure, provide a patch to OpenBSD ;).

Does it break anything this way?

Cheers Jochen


signature.asc
Description: PGP signature

Re: [hackers] [scroll] Fix make on OpenBSD || Jochen Sprickerhof

[Quentin Rameau]

> Fix make on OpenBSD
>
> -scroll: config.h
> +scroll: scroll.c config.h

I think it'd be better to fix OpenBSD make or let OpenBSD port
maintainers to patch the software rather than pushing changes do
standard code because of some buggy implementations.

[hackers] [scroll] Fix make on OpenBSD || Jochen Sprickerhof

[git]

commit 4a454be5448811cf224d2e29797380e427e1b78e
Author: Jochen Sprickerhof 
AuthorDate: Sat Apr 11 22:27:02 2020 +0200
Commit: Jochen Sprickerhof 
CommitDate: Sat Apr 11 22:27:02 2020 +0200

Fix make on OpenBSD

diff --git a/Makefile b/Makefile
index 4d415b7..c637c81 100644
--- a/Makefile
+++ b/Makefile
@@ -7,7 +7,7 @@ all: scroll
 config.h:
cp config.def.h config.h
 
-scroll: config.h
+scroll: scroll.c config.h
 
 install: scroll
mkdir -p $(BINDIR) $(MANDIR)/man1