Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes
On Wed, Mar 13, 2019 at 05:12:54PM +0200, Lauri Tirkkonen wrote: > Currently st is outputting the following on stderr when I attach or > detach tmux (on OpenBSD): > > erresc: unknown private set/reset mode 1005 > > diff below fixes it. > > From e3ddd14bacb0037e236b5a2243120b8494c5f054 Mon Sep 17 00:00:00 2001 > From: Lauri Tirkkonen > Date: Wed, 13 Mar 2019 17:08:50 +0200 > Subject: [PATCH] be silent about explicitly unhandled mouse modes > > --- > st.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/st.c b/st.c > index 379dd10..d35f89d 100644 > --- a/st.c > +++ b/st.c > @@ -1575,6 +1575,7 @@ tsetmode(int priv, int set, int *args, int narg) > case 1015: /* urxvt mangled mouse mode; incompatible > and can be mistaken for other control > codes. */ > + break; > default: > fprintf(stderr, > "erresc: unknown private set/reset mode > %d\n", > -- > 2.21.0 > > -- > Lauri Tirkkonen | lotheac @ IRCnet > Applied, thanks. -- Kind regards, Hiltjo
Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes
I'm not drunk mate. But someone came in my room who was talking to me and I compose this email while talking to him. The scrot I gave before was the output of ncmpcpp's running song's album art, which is also saved in /tmp. On 13/03, Quentin Rameau wrote: > Hello Abdullah, > > > it fixes this. > > > > see attachment. > > > > On 13/03, Quentin Rameau wrote: > > > Hello Lauri, > > > > > > > diff below fixes it. > > > > > > What does it fix? > > > > > Please do not send to this mailing list while being drunk. > A K https://abdullah.today 69C8 7720 E507 86DF 1D85 EA5E FC59 7891 5CBC 7BC7 signature.asc Description: PGP signature
Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes
Hello Abdullah, > it fixes this. > > see attachment. > > On 13/03, Quentin Rameau wrote: > > Hello Lauri, > > > > > diff below fixes it. > > > > What does it fix? > > Please do not send to this mailing list while being drunk.
Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes
> the erroneous output on stderr. the comment reads like these escapes are > intentionally left unhandled, but in that case it doesn't make sense to > output an error about them. Ok, I thought there was actually an issue preventing tmux to work correctly.
Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes
He has explained in his patch what it fixes. On 13/03, Quentin Rameau wrote: > Hello Lauri, > > > diff below fixes it. > > What does it fix? > A K https://abdullah.today 69C8 7720 E507 86DF 1D85 EA5E FC59 7891 5CBC 7BC7 signature.asc Description: PGP signature
Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes
On Wed, Mar 13 2019 16:22:02 +0100, Quentin Rameau wrote: > Hello Lauri, > > > diff below fixes it. > > What does it fix? the erroneous output on stderr. the comment reads like these escapes are intentionally left unhandled, but in that case it doesn't make sense to output an error about them. -- Lauri Tirkkonen | lotheac @ IRCnet
Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes
Hello Lauri, > diff below fixes it. What does it fix?
[hackers] [st][patch] be silent about explicitly unhandled mouse modes
Currently st is outputting the following on stderr when I attach or detach tmux (on OpenBSD): erresc: unknown private set/reset mode 1005 diff below fixes it. >From e3ddd14bacb0037e236b5a2243120b8494c5f054 Mon Sep 17 00:00:00 2001 From: Lauri Tirkkonen Date: Wed, 13 Mar 2019 17:08:50 +0200 Subject: [PATCH] be silent about explicitly unhandled mouse modes --- st.c | 1 + 1 file changed, 1 insertion(+) diff --git a/st.c b/st.c index 379dd10..d35f89d 100644 --- a/st.c +++ b/st.c @@ -1575,6 +1575,7 @@ tsetmode(int priv, int set, int *args, int narg) case 1015: /* urxvt mangled mouse mode; incompatible and can be mistaken for other control codes. */ + break; default: fprintf(stderr, "erresc: unknown private set/reset mode %d\n", -- 2.21.0 -- Lauri Tirkkonen | lotheac @ IRCnet
