Re: Failures on "Generate Build Matrix"

[Willy Tarreau]

On Fri, Dec 23, 2022 at 03:24:47PM +0100, William Lallemand wrote:
> On Fri, Dec 23, 2022 at 12:14:15AM +0600,  ??? wrote:
> > haproxy/vtest.yml at master · chipitsine/haproxy (github.com)
> > 
> > 
> > secret name can be arbitrary, for example "TOKEN".
> > env variable is GITHUB_API_TOKEN
> > 
> 
> I passed some time doing tests and reading the github configuration, in
> fact we don't need to generate a token ourselves and to add it to the
> secret configuration.
> 
> Github has a GITHUB_TOKEN which is generated at the beginning of the job
> and destroyed at the end, so I just add it in the environment as
> recommended in the documentation.
> 
> https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
> 
> So we can remove any token that was generated for this problem, it is
> not useful.

Good catch! That also explains why they don't want us to create one
whose name starts with GITHUB_ :-)

Thanks,
Willy

Re: Failures on "Generate Build Matrix"

[William Lallemand]

On Fri, Dec 23, 2022 at 12:14:15AM +0600, Илья Шипицин wrote:
> haproxy/vtest.yml at master · chipitsine/haproxy (github.com)
> 
> 
> secret name can be arbitrary, for example "TOKEN".
> env variable is GITHUB_API_TOKEN
> 

I passed some time doing tests and reading the github configuration, in
fact we don't need to generate a token ourselves and to add it to the
secret configuration.

Github has a GITHUB_TOKEN which is generated at the beginning of the job
and destroyed at the end, so I just add it in the environment as
recommended in the documentation.

https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret

So we can remove any token that was generated for this problem, it is
not useful.

Regards,
-- 
William Lallemand

Support arbitrary PROXY protocol v2 TLVs as samples

[Bitsch, Johannes (external - Project)]

Hi all,

I created a feature request on github about supporting arbitrary PROXY protocol 
v2 TLVs in haproxy a few weeks ago[1].

Since I haven't received any feedback or reactions on it so far, I was 
wondering if this was the right place to discuss something like this.
Is there a better place to have a discussion about it, e.g. on this mailing 
list or somewhere else? If you could point me to the best way to do this, I'd 
be happy to switch.

I'll avoid duplicating the request here for now but will happily copy/paste it 
in here if that’s easier for someone.

Thanks & regards,
Johannes 

[1] https://github.com/haproxy/haproxy/issues/1947