Re: [PR] Improve wording of http-request wait-for-body

[Tim Düsterhus]

Hi

On 4/14/23 18:42, William Dauchy wrote:

Thank you for your patch.
Do you think you could come back with a patch which is only modifying
the section you want? It seems you did a change on the full file
instead which makes the review quite hard.



It appears they changed the line endings of the entire file. Appending 
?w=1 to the PR shows a useful diff. I've attached a fixed patch.


Best regards
Tim DüsterhusFrom cc26527ca0afab9384e572bbf351e3965d8f25f8 Mon Sep 17 00:00:00 2001
From: Craig <99729+cr...@users.noreply.github.com>
Date: Fri, 14 Apr 2023 17:29:04 +0200
Subject: [PATCH] Improve wording of http-request wait-for-body

Improve wording of http-request wait-for-body so it's easier to understand.
---
 doc/configuration.txt | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/configuration.txt b/doc/configuration.txt
index 3adab3487..e0e5f571c 100644
--- a/doc/configuration.txt
+++ b/doc/configuration.txt
@@ -7839,11 +7839,11 @@ http-request wait-for-body time  [ at-least  ]
  [ { if | unless }  ]
 
   This will delay the processing of the request waiting for the payload for at
-  most  milliseconds. if "at-least" argument is specified, HAProxy stops
-  to wait the payload when the first  bytes are received. 0 means no
-  limit, it is the default value. Regardless the "at-least" argument value,
+  most  milliseconds. If the "at-least" argument is specified, HAProxy
+  stops to wait when the first  payload bytes are received. 0 means no
+  limit, which is the default value. Regardless of the "at-least" argument value,
   HAProxy stops to wait if the whole payload is received or if the request
-  buffer is full.  This action may be used as a replacement to "option
+  buffer is full. This action may be used as a replacement to "option
   http-buffer-request".
 
   Arguments :
-- 
2.40.0

Re: [PR] Improve wording of http-request wait-for-body

[William Dauchy]

Hi Craig,

Thank you for your patch.
Do you think you could come back with a patch which is only modifying
the section you want? It seems you did a change on the full file
instead which makes the review quite hard.

-- 
William

[PR] Improve wording of http-request wait-for-body

[PR Bot]

Dear list!

Author: Craig <99729+cr...@users.noreply.github.com>
Number of patches: 1

This is an automated relay of the Github pull request:
   Improve wording of http-request wait-for-body

Patch title(s): 
   Improve wording of http-request wait-for-body 

Link:
   https://github.com/haproxy/haproxy/pull/2122

Edit locally:
   wget https://github.com/haproxy/haproxy/pull/2122.patch && vi 2122.patch

Apply locally:
   curl https://github.com/haproxy/haproxy/pull/2122.patch | git am -

Description:
   Improve wording of http-request wait-for-body so it's easier to
   understand.

Instructions:
   This github pull request will be closed automatically; patch should be
   reviewed on the haproxy mailing list (haproxy@formilux.org). Everyone is
   invited to comment, even the patch's author. Please keep the author and
   list CCed in replies. Please note that in absence of any response this
   pull request will be lost.

Re: [PATCH] CI: monthly Fedora Rawhide, bump "actions/checkout" to v3

[William Lallemand]

On Sat, Apr 08, 2023 at 01:36:48PM +0200, Илья Шипицин wrote:
> Hello,
> 
> couple of patches:
> 
> 1) Fedora Rawhide (known to include the most recent compilers) monthly
> builds
> 2) small cleanup, "actions/checkout" bumped to v3
> 
> Cheers,
> Ilya

Thanks, merged.

-- 
William Lallemand