Re: [PATCH] BUILD: ssl: include buffer common headers for ssl_sock_ctx

[William Lallemand]

On Sun, May 17, 2020 at 01:41:53PM +0200, William Dauchy wrote:
> since commit c0cdaffaa338 ("REORG: ssl: move ssl_sock_ctx and fix
> cross-dependencies issues"), `struct ssl_sock_ctx` was moved in
> ssl_sock.h. As it contains a `struct buffer`, including
> `common/buffer.h` is now mandatory. I encountered an issue while
> including ssl_sock.h on another patch:
> 
> include/types/ssl_sock.h:240:16: error: field ‘early_buf’ has incomplete type
>   240 |  struct buffer early_buf;  /* buffer to store the early data 
> received */
> 
> no backport needed.
> 
> Fixes: c0cdaffaa338 ("REORG: ssl: move ssl_sock_ctx and fix
> cross-dependencies issues")
> Signed-off-by: William Dauchy 

Thanks, merged!

-- 
William Lallemand

[PATCH] BUILD: ssl: include buffer common headers for ssl_sock_ctx

[William Dauchy]

since commit c0cdaffaa338 ("REORG: ssl: move ssl_sock_ctx and fix
cross-dependencies issues"), `struct ssl_sock_ctx` was moved in
ssl_sock.h. As it contains a `struct buffer`, including
`common/buffer.h` is now mandatory. I encountered an issue while
including ssl_sock.h on another patch:

include/types/ssl_sock.h:240:16: error: field ‘early_buf’ has incomplete type
  240 |  struct buffer early_buf;  /* buffer to store the early data 
received */

no backport needed.

Fixes: c0cdaffaa338 ("REORG: ssl: move ssl_sock_ctx and fix
cross-dependencies issues")
Signed-off-by: William Dauchy 
---
 include/types/ssl_sock.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/types/ssl_sock.h b/include/types/ssl_sock.h
index 99c964d6e..78639ac10 100644
--- a/include/types/ssl_sock.h
+++ b/include/types/ssl_sock.h
@@ -31,6 +31,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
-- 
2.26.2