Re: [PATCH] fix memory leak, issue 559
On Mon, Mar 23, 2020 at 10:54:47AM +0100, Emmanuel Hocdet wrote: > > Hi, > > This issue was introduced by #516. > find_chain must not be freed. > patch attached. > > > Le 21 mars 2020 à 15:23, Илья Шипицин a écrit : > > > > Hello, > > > > I attached patch that fixes memory leak, described in #559 > > > > ++ > Manu > Thanks Manu, merged. -- William Lallemand
Re: [PATCH] fix memory leak, issue 559
Hi, This issue was introduced by #516. find_chain must not be freed. patch attached. > Le 21 mars 2020 à 15:23, Илья Шипицин a écrit : > > Hello, > > I attached patch that fixes memory leak, described in #559 > ++ Manu 0001-BUG-MINOR-ssl-memory-leak-when-find_chain-is-NULL.patch Description: Binary data
[PATCH] fix memory leak, issue 559
Hello, I attached patch that fixes memory leak, described in #559 Cheers, Ilya Shipitcin From a52fad9b32959afc78b4e3086b4d3e17458d19b1 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 21 Mar 2020 19:21:10 +0500 Subject: [PATCH] BUG/MINOR: src/ssl_sock.c: free "find_chain" upon exit non-recurring memory leak was detected in issue #559 --- src/ssl_sock.c | 4 1 file changed, 4 insertions(+) diff --git a/src/ssl_sock.c b/src/ssl_sock.c index 9b44e9d0b..efd464255 100644 --- a/src/ssl_sock.c +++ b/src/ssl_sock.c @@ -3702,6 +3702,10 @@ static int ssl_sock_put_ckch_into_ctx(const char *path, const struct cert_key_an #endif end: + +if (find_chain) +sk_X509_pop_free(find_chain, X509_free); + return errcode; } -- 2.25.1