Re: [PATCH] spell check fixes
On Mon, May 10, 2021 at 12:51:45PM +0500, ??? wrote: > Hello, > > yet another spell check improvements. Merged, thanks Ilya! Willy
[PATCH] spell check fixes
Hello,
yet another spell check improvements.
Ilya
From 58ea7d81c586a609aa7bdea44d0c33a7de500fda Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Mon, 10 May 2021 12:50:00 +0500
Subject: [PATCH 2/2] CLEANUP: assorted typo fixes in the code and comments
This is 23rd iteration of typo fixes
---
doc/configuration.txt | 2 +-
src/activity.c| 4 ++--
src/haproxy.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/configuration.txt b/doc/configuration.txt
index 964bc04ce..a716c3481 100644
--- a/doc/configuration.txt
+++ b/doc/configuration.txt
@@ -12247,7 +12247,7 @@ tcp-request content [{if | unless} ]
"tcp-request content" rules are not evaluated. This upgrade method should be
preferred to the implicit one consisting to rely on the backend mode. When
used, it is possible to set HTTP directives in a frontend without any
- warning. These directives will be conditionaly evaluated if the HTTP upgrade
+ warning. These directives will be conditionally evaluated if the HTTP upgrade
is performed. However, an HTTP backend must still be selected. It remains
unsupported to route an HTTP connection (upgraded or not) to a TCP server.
diff --git a/src/activity.c b/src/activity.c
index 179ff1f32..ec230da82 100644
--- a/src/activity.c
+++ b/src/activity.c
@@ -112,7 +112,7 @@ static __attribute__((noreturn)) void memprof_die(const char *msg)
* Worse, we have to account for the risk of reentrance from dlsym() when
* it tries to prepare its error messages. Here its ahndled by in_memprof
* that makes allocators return NULL. dlsym() handles it gracefully. An
- * alternate approch consists in calling aligned_alloc() from these places
+ * alternate approach consists in calling aligned_alloc() from these places
* but that would mean not being able to intercept it later if considered
* useful to do so.
*/
@@ -411,7 +411,7 @@ static int cli_parse_set_profiling(char **args, char *payload, struct appctx *ap
}
if (strcmp(args[2], "tasks") != 0)
- return cli_err(appctx, "Expects etiher 'tasks' or 'memory'.\n");
+ return cli_err(appctx, "Expects either 'tasks' or 'memory'.\n");
if (strcmp(args[3], "on") == 0) {
unsigned int old = profiling;
diff --git a/src/haproxy.c b/src/haproxy.c
index c13beb487..1fd4a6be6 100644
--- a/src/haproxy.c
+++ b/src/haproxy.c
@@ -2623,7 +2623,7 @@ void run_poll_loop()
int i;
if (stopping) {
-/* stop muxes before acknowleding stopping */
+/* stop muxes before acknowledging stopping */
if (!(stopping_thread_mask & tid_bit)) {
task_wakeup(mux_stopping_data[tid].task, TASK_WOKEN_OTHER);
wake = 1;
--
2.31.1
From 58064260ab0f4b65bad595e9e987d4d4223016a0 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Mon, 10 May 2021 12:45:18 +0500
Subject: [PATCH 1/2] CI: extend spellchecker whitelist, add "ists" as well
codespell does not handle plurals, we already whitelusted "ist", let us
whitelist "ists" as well
---
.github/workflows/codespell.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml
index c2130ebf9..de49f4343 100644
--- a/.github/workflows/codespell.yml
+++ b/.github/workflows/codespell.yml
@@ -14,4 +14,4 @@ jobs:
- name: install prerequisites
run: sudo pip install codespell
- name: check
- run: codespell -c -q 2 --ignore-words-list ist,hist,wan,ca,cas,que,ans,te,nd,referer,ot,uint,iif,fo,keep-alives,dosen --skip="CHANGELOG,Makefile,*.fig,*.pem"
+ run: codespell -c -q 2 --ignore-words-list ist,ists,hist,wan,ca,cas,que,ans,te,nd,referer,ot,uint,iif,fo,keep-alives,dosen --skip="CHANGELOG,Makefile,*.fig,*.pem"
--
2.31.1
Re: [PATCH] spell check fixes, spell rules exclusion
Hi Ilya, On Sat, Feb 27, 2021 at 11:50:17AM +0500, ??? wrote: > ping :) Ah sorry, missed again, now merged! Do not hesitate to CC me when you have patches that you're certain you want to get merged, as I can easily overlook some of them on the list. It works very well with Tim and Lukas who regularly CC me at the end of a discussion just to tell me that they reviewed something that's OK or as a reminder not to forget to merge a patch. Thanks! Willy
Re: [PATCH] spell check fixes, spell rules exclusion
ping :) сб, 20 февр. 2021 г. в 00:25, Илья Шипицин : > Hello, > > couple of spell check fixes. > > Ilya >
[PATCH] spell check fixes, spell rules exclusion
Hello,
couple of spell check fixes.
Ilya
From b7c727d7dd358aa0e3191ce302d7489617909603 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Sat, 20 Feb 2021 00:18:00 +0500
Subject: [PATCH 1/2] CI: codespell: skip Makefile for spell check
checking Makefile is noisy, we do not benefit from it
---
.github/workflows/codespell.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml
index 8029a21f6..75c96c054 100644
--- a/.github/workflows/codespell.yml
+++ b/.github/workflows/codespell.yml
@@ -14,4 +14,4 @@ jobs:
- name: install prerequisites
run: sudo pip install codespell
- name: check
- run: codespell -c -q 2 --ignore-words-list ist,hist,wan,ca,cas,que,ans,te,nd,referer,ot,uint,iif,fo,keep-alives --skip="CHANGELOG,*.fig,*.pem"
+ run: codespell -c -q 2 --ignore-words-list ist,hist,wan,ca,cas,que,ans,te,nd,referer,ot,uint,iif,fo,keep-alives --skip="CHANGELOG,Makefile,*.fig,*.pem"
--
2.29.2
From cac2c459eaec597c1ff402e63105518284634fca Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin
Date: Sat, 20 Feb 2021 00:23:36 +0500
Subject: [PATCH 2/2] CLEANUP: assorted typo fixes in the code and comments
This is 18th iteration of typo fixes
---
doc/configuration.txt | 2 +-
src/dns.c | 18 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/doc/configuration.txt b/doc/configuration.txt
index 6b2eea2b9..d1bb8816e 100644
--- a/doc/configuration.txt
+++ b/doc/configuration.txt
@@ -17557,7 +17557,7 @@ src_http_err_rate([]) : integer
src_http_fail_cnt([]) : integer
Returns the cumulative number of HTTP response failures triggered by the
incoming connection's source address in the current proxy's stick-table or in
- the designated stick-table. This includes the both repsonse errors and 5xx
+ the designated stick-table. This includes the both response errors and 5xx
status codes other than 501 and 505. See also sc/sc0/sc1/sc2_http_fail_cnt.
If the address is not found, zero is returned.
diff --git a/src/dns.c b/src/dns.c
index cb30bff46..41ff11d8c 100644
--- a/src/dns.c
+++ b/src/dns.c
@@ -193,7 +193,7 @@ ssize_t dns_recv_nameserver(struct dns_nameserver *ns, void *data, size_t size)
* elem is removed from the list */
__ha_barrier_store();
-/* awake appctx beacause it may have other
+/* awake appctx because it may have other
* message to receive
*/
appctx_wakeup(ds->appctx);
@@ -592,7 +592,7 @@ static void dns_session_io_handler(struct appctx *appctx)
if (ci_putchk(si_ic(si), &trash) == -1) {
/* should never happen since we
* check available_room is large
- * enought here.
+ * enough here.
*/
si_rx_room_blk(si);
ret = 0;
@@ -626,7 +626,7 @@ static void dns_session_io_handler(struct appctx *appctx)
read:
- /* if session is not a waiter it means there is no commited
+ /* if session is not a waiter it means there is no committed
* message into rx_buf and we are free to use it
* Note: we need a load barrier here to not miss the
* delete from the list
@@ -674,7 +674,7 @@ read:
break;
}
- /* enougth data is available into the channel to read the message until the end */
+ /* enough data is available into the channel to read the message until the end */
/* read from the channel until the end of the message */
co_getblk(si_oc(si), ds->rx_msg.area + ds->rx_msg.offset, ds->rx_msg.len - ds->rx_msg.offset, 0);
@@ -980,7 +980,7 @@ static struct task *dns_process_idle_exp(struct task *t, void *context, unsigned
/* force session shutdown */
ds->shutdown = 1;
- /* to be sure that the appctx wont miss shutdown */
+ /* to be sure that the appctx won't miss shutdown */
__ha_barrier_store();
/* wake appctx to perform the shutdown */
@@ -1127,7 +1127,7 @@ static struct task *dns_process_req(struct task *t, void *context, unsigned shor
myist.len = len;
ads = NULL;
- /* try to push request into activ sess with free slot */
+ /* try to push request into active sess with free slot */
if (!LIST_ISEMPTY(&dss->free_sess)) {
ds = LIST_NEXT(&dss->free_sess, struct dns_session *, list);
@@ -1147,7 +1147,7 @@ static struct task *dns_process_req(struct task *t, void *context, unsigned shor
}
if (!ads) {
- /* try to push request into idle, this one should have enought free space */
+ /* try to push request into idle, this one should have enough free space */
if (!LIST_ISEMPTY(&dss->idle_sess)) {
ds = LIST_NEXT(&dss->idle_sess, struct dns_session *, list);
@@ -1171,7 +1171,7 @@ static struct task *dns_process_req(struct task *t, void *context, unsigned shor
}
}
- /* we didn't find a session avalaible with large enough room */
+ /* we didn't find a session available with large enough room */
if (!ads) {
/* allocate a new session */
ads = dns_session_new(dss);
@@ -1272,7 +1272,7 @@ int dns_stream
