PR Bot wrote:
> Dear list!
> Author: Peter Skarpetis
> Number of patches: 1
> This is an automated relay of the Github pull request:
>Fixed null pointer dereference in srv_cleanup_connections()
> Patch title(s):
>Fixed null pointer dereference in srv_cleanup_connections()
> Link:
>https://github.com/haproxy/haproxy/pull/1031
> Edit locally:
>wget https://github.com/haproxy/haproxy/pull/1031.patch && vi 1031.patch
> Apply locally:
>curl https://github.com/haproxy/haproxy/pull/1031.patch | git am -
> Description:
>haproxy_srv_cleanup_connections_crash.cfg causes a null pointer
>dereference in srv_cleanup_connections . Configuration file works in
>2.0.19 branch but crashes in all subsequent versions including the
>dev branch. I did not track down the cause, I just added the null
>pointer check to stop the crashing.
>
>Crash can be reproduced
>with the following command:
>./haproxy -c -f
>haproxy_srv_cleanup_connections_crash.cfg
>haproxy_srv_cleanup_connections_crash.cfg can be grabbed from the
>gist below:
>https://gist.github.com/peterska/769f41562f6b045df59df
>2294b2c20f0#file-haproxy_srv_cleanup_connections_crash-cfg
>configuration file has been edited enough to cause the crash while
>removing all references to certificates and CA authorities. It is not
>a production config file.
> Instructions:
>This github pull request will be closed automatically; patch should be
>reviewed on the haproxy mailing list (haproxy@formilux.org). Everyone is
>invited to comment, even the patch's author. Please keep the author and
>list CCed in replies. Please note that in absence of any response this
>pull request will be lost.
I can reproduce your issue on haproxy master. However I'm not sure why
idle_conns list is NULL in this case so I'll investigate it before
validating your patch.
--
Amaury Denoyelle
