Re: [PR] updating req.body_param doc with chunk-encoding limitation

[Willy Tarreau]

Hello,

On Tue, Oct 22, 2019 at 10:23:05AM -0400, PR Bot wrote:
> Patch title(s): 
>updating req.body_param doc with chunk-encoding limitation
> 
> Link:
>https://github.com/haproxy/haproxy/pull/333

diff --git a/doc/configuration.txt b/doc/configuration.txt
index b79795c68..fc988b320 100644
--- a/doc/configuration.txt
+++ b/doc/configuration.txt
@@ -15823,7 +15823,8 @@ req.body_param([) : string
   parameter  as presented in the request body (no URL decoding is
   performed). Note that the ACL version of this fetch iterates over multiple
   parameters and will iteratively report all parameters values if no name is
-  given.
+  given. Also, only the first chunk is currently analyzed in case of 
+  chunked-encoded body.

Actually this was true before the introduction of HTX in 1.9. When
you use HTX mode (using option http-use-htx in 1.9, by default in
2.0, and only one supported in 2.1), you don't have this limitation
anymore. Thus I'd propose that instead we don't change the doc.

Thanks!
Willy

[PR] updating req.body_param doc with chunk-encoding limitation

[PR Bot]

Dear list!

Author: fclerg <29798784+fcl...@users.noreply.github.com>
Number of patches: 1

This is an automated relay of the Github pull request:
   updating req.body_param doc with chunk-encoding limitation

Patch title(s): 
   updating req.body_param doc with chunk-encoding limitation

Link:
   https://github.com/haproxy/haproxy/pull/333

Edit locally:
   wget https://github.com/haproxy/haproxy/pull/333.patch && vi 333.patch

Apply locally:
   curl https://github.com/haproxy/haproxy/pull/333.patch | git am -

Description:


Instructions:
   This github pull request will be closed automatically; patch should be
   reviewed on the haproxy mailing list (haproxy@formilux.org). Everyone is
   invited to comment, even the patch's author. Please keep the author and
   list CCed in replies. Please note that in absence of any response this
   pull request will be lost.