Dear list! Author: Chris Staite <christopher.sta...@menlosecurity.com> Number of patches: 1
This is an automated relay of the Github pull request: BUG/MEDIUM: h1-htx: Ensure chunked parsing with full output buffer Patch title(s): BUG/MEDIUM: h1-htx: Ensure chunked parsing with full output buffer Link: https://github.com/haproxy/haproxy/pull/2278 Edit locally: wget https://github.com/haproxy/haproxy/pull/2278.patch && vi 2278.patch Apply locally: curl https://github.com/haproxy/haproxy/pull/2278.patch | git am - Description: A previous fix to ensure that there is sufficient space on the output buffer to place parsed data (#2053) introduced an issue that if the output buffer is filled on a chunk boundary no data is parsed but the congested flag is not set due to the state not being H1_MSG_DATA. The check to ensure that there is sufficient space in the output buffer is actually already performed in all downstream functions before it is used. This makes the early optimisation that avoids the state transition to H1_MSG_DATA needless. Therefore, in order to allow the chunk parser to continue in this edge case we can simply remove the early check. This ensures that the state can progress and set the congested flag correctly in the caller. This patch fixes #2262. The upstream change that caused this logic error was backported as far as 2.5, therefore it makes sense to backport this fix back that far also. Instructions: This github pull request will be closed automatically; patch should be reviewed on the haproxy mailing list (haproxy@formilux.org). Everyone is invited to comment, even the patch's author. Please keep the author and list CCed in replies. Please note that in absence of any response this pull request will be lost.
