Re: PATCH: enable cirrus-ci (freebsd builds)
Hi Tim, On Thu, May 16, 2019 at 07:53:03PM +0200, Tim Düsterhus wrote: > Willy, > > Am 16.05.19 um 09:42 schrieb Willy Tarreau: > > If in the mean time you know how to verify that it was properly enabled > > and builds there, and share with us the link to consult the status, it > > would be nice. > > These continuous integration services report the commit status back to > GitHub: If you view the commit list on GitHub [1] you can see either a > green checkmark or a red X behind the date on certain commits. These > commits were the HEAD of the master branch after a push and the ones tested. > > When you click the checkmark / X a list of continues integration > services opens. Ah, I've already seen such crosses on certain projects, but since there's no tooltip when you hover them, I never tried to click, to avoid doing mistakes! > For the recent commit at the time of composing this > email clicking Cirrus leads to this page with links to the build logs [2]: > > https://github.com/haproxy/haproxy/runs/129763329 > > So it appears that Cirrus indeed is properly enabled now (and FreeBSD > passes the tests). > > [1] https://github.com/haproxy/haproxy/commits/master > [2] https://cirrus-ci.com/task/5113143785684992 Thanks for this explanation, it'll be easier to search now. (...) > Sorry for the duplicate email. I thought the part of "why do we need two > services" was in another mail and I stripped the paragraph without checking: > > The reason is simple. These CI services only support a limited number of > operating systems. For Travis this is Linux and Mac. Since a few months > Windows as well. > > Cirrus appears to supports Linux, Mac and FreeBSD (which probably would > have been sufficient). > But honestly: I never heard about Cirrus before, while Travis is very > well known in the GitHub community. This makes it easier to find Travis > expertise in case something goes wrong. Personally I also find Travis' > UI cleaner. OK these are perfectl valid arguments. Thank you very much for taking the time to explain all this, it's much clearer now! Willy
Re: PATCH: enable cirrus-ci (freebsd builds)
чт, 16 мая 2019 г. в 22:59, Tim Düsterhus : > Willy, > > Am 16.05.19 um 09:42 schrieb Willy Tarreau: > > It would be nice next time to give a bit more information. Maybe for > > you this cirrus stuff is legacy, but I never heard about it before, am > > not used at all to this type of tools, and don't even know why this one > > and not another one. And can't we use just one instead of fragmenting > > the build results between multiple sites ? These are typically the > > Sorry for the duplicate email. I thought the part of "why do we need two > services" was in another mail and I stripped the paragraph without > checking: > > The reason is simple. These CI services only support a limited number of > operating systems. For Travis this is Linux and Mac. Since a few months > Windows as well. > > Cirrus appears to supports Linux, Mac and FreeBSD (which probably would > have been sufficient). > But honestly: I never heard about Cirrus before, while Travis is very > well known in the GitHub community. This makes it easier to find Travis > expertise in case something goes wrong. Personally I also find Travis' > UI cleaner. > > So while Travis technically is redundant now it has some nice user > experience benefits compared to Cirrus. And as Travis is set up anyway > we may as well leave it enabled. > cirrus is very new thing. I'm not sure stable it is. Maybe we'll drop it soon but it allows to run freebsd builds, which is great as for travis, I'll add sanitizers (sent patch already) and cygwin builds > > Best regards > Tim Düsterhus >
Re: PATCH: enable cirrus-ci (freebsd builds)
чт, 16 мая 2019 г. в 22:53, Tim Düsterhus : > Willy, > > Am 16.05.19 um 09:42 schrieb Willy Tarreau: > > If in the mean time you know how to verify that it was properly enabled > > and builds there, and share with us the link to consult the status, it > > would be nice. > > These continuous integration services report the commit status back to > GitHub: If you view the commit list on GitHub [1] you can see either a > green checkmark or a red X behind the date on certain commits. These > commits were the HEAD of the master branch after a push and the ones > tested. > > When you click the checkmark / X a list of continues integration > services opens. For the recent commit at the time of composing this > email clicking Cirrus leads to this page with links to the build logs [2]: > > https://github.com/haproxy/haproxy/runs/129763329 > > So it appears that Cirrus indeed is properly enabled now (and FreeBSD > passes the tests). > I think we can add the following links to some documentation (another popular way is adding badges to README.md) https://cirrus-ci.com/github/haproxy/haproxy https://travis-ci.com/haproxy/haproxy > > [1] https://github.com/haproxy/haproxy/commits/master > [2] https://cirrus-ci.com/task/5113143785684992 > > Best regards > Tim Düsterhus >
Re: PATCH: enable cirrus-ci (freebsd builds)
Willy, Am 16.05.19 um 09:42 schrieb Willy Tarreau: > It would be nice next time to give a bit more information. Maybe for > you this cirrus stuff is legacy, but I never heard about it before, am > not used at all to this type of tools, and don't even know why this one > and not another one. And can't we use just one instead of fragmenting > the build results between multiple sites ? These are typically the Sorry for the duplicate email. I thought the part of "why do we need two services" was in another mail and I stripped the paragraph without checking: The reason is simple. These CI services only support a limited number of operating systems. For Travis this is Linux and Mac. Since a few months Windows as well. Cirrus appears to supports Linux, Mac and FreeBSD (which probably would have been sufficient). But honestly: I never heard about Cirrus before, while Travis is very well known in the GitHub community. This makes it easier to find Travis expertise in case something goes wrong. Personally I also find Travis' UI cleaner. So while Travis technically is redundant now it has some nice user experience benefits compared to Cirrus. And as Travis is set up anyway we may as well leave it enabled. Best regards Tim Düsterhus
Re: PATCH: enable cirrus-ci (freebsd builds)
Willy, Am 16.05.19 um 09:42 schrieb Willy Tarreau: > If in the mean time you know how to verify that it was properly enabled > and builds there, and share with us the link to consult the status, it > would be nice. These continuous integration services report the commit status back to GitHub: If you view the commit list on GitHub [1] you can see either a green checkmark or a red X behind the date on certain commits. These commits were the HEAD of the master branch after a push and the ones tested. When you click the checkmark / X a list of continues integration services opens. For the recent commit at the time of composing this email clicking Cirrus leads to this page with links to the build logs [2]: https://github.com/haproxy/haproxy/runs/129763329 So it appears that Cirrus indeed is properly enabled now (and FreeBSD passes the tests). [1] https://github.com/haproxy/haproxy/commits/master [2] https://cirrus-ci.com/task/5113143785684992 Best regards Tim Düsterhus
Re: PATCH: enable cirrus-ci (freebsd builds)
чт, 16 мая 2019 г. в 12:42, Willy Tarreau : > Hi Ilya, > > On Thu, May 16, 2019 at 01:12:40AM +0500, ??? wrote: > > in order to enable builds, the following steps must be taken > > > > 1) must be enabled (using owner account) on > > https://github.com/marketplace/cirrus-ci , also "haproxy/haproxy" repo > > should be enabled there > > 2) build configuration is taken from .cirrus.yml (attached as patch to > > previous email) > > So I did this, stupidly repeating the steps you explained above and > committing your file, but I have absolutely no idea what I did and > still couldn't figure on their cirrus-ci.org and .com sites where the > build statuses are supposed to be reported. I wanted to at least add > this in the commit message but couldn't. Quite frankly, I really hate > doing stuff that I don't understand with little more info than "please > just click the green buttons there and don't worry it will not hurt, > only red ones do". > > It would be nice next time to give a bit more information. Maybe for > you this cirrus stuff is legacy, but I never heard about it before, am > not used at all to this type of tools, and don't even know why this one > and not another one. And can't we use just one instead of fragmenting > the build results between multiple sites ? These are typically the > element that should be provided upfront when requesting such features, > so that I don't have to spend time asking or blindly trusting that this > will not break our process. > > If in the mean time you know how to verify that it was properly enabled > and builds there, and share with us the link to consult the status, it > would be nice. > I understand what you mean, actually I've no idea yet how to document it properly. while travis-ci provides very good url naming, i.e. https://travis-ci.com/haproxy/haproxy there's no such way within cirrus-ci I'll try to find out :) > > Thanks, > Willy >
Re: PATCH: enable cirrus-ci (freebsd builds)
Hi Ilya, On Thu, May 16, 2019 at 01:12:40AM +0500, ??? wrote: > in order to enable builds, the following steps must be taken > > 1) must be enabled (using owner account) on > https://github.com/marketplace/cirrus-ci , also "haproxy/haproxy" repo > should be enabled there > 2) build configuration is taken from .cirrus.yml (attached as patch to > previous email) So I did this, stupidly repeating the steps you explained above and committing your file, but I have absolutely no idea what I did and still couldn't figure on their cirrus-ci.org and .com sites where the build statuses are supposed to be reported. I wanted to at least add this in the commit message but couldn't. Quite frankly, I really hate doing stuff that I don't understand with little more info than "please just click the green buttons there and don't worry it will not hurt, only red ones do". It would be nice next time to give a bit more information. Maybe for you this cirrus stuff is legacy, but I never heard about it before, am not used at all to this type of tools, and don't even know why this one and not another one. And can't we use just one instead of fragmenting the build results between multiple sites ? These are typically the element that should be provided upfront when requesting such features, so that I don't have to spend time asking or blindly trusting that this will not break our process. If in the mean time you know how to verify that it was properly enabled and builds there, and share with us the link to consult the status, it would be nice. Thanks, Willy
Re: PATCH: enable cirrus-ci (freebsd builds)
Hi Ilya, On Thu, May 16, 2019 at 12:05:47AM +0500, ??? wrote: > Hello, > > can we enable cirrus-ci ? it's like travis-ci, it allows run freebsd builds I have no opinion on it, I don't know anything about it at all, so since you appear to know what it involves, you'll have to give me some info. Cheers, Willy
Re: PATCH: enable cirrus-ci (freebsd builds)
Hello, can we enable cirrus-ci ? it's like travis-ci, it allows run freebsd builds ср, 1 мая 2019 г. в 14:11, Илья Шипицин : > hello! > > can you please enable cirrus-ci on https://github.com/haproxy/haproxy ? > > > -- Forwarded message - > От: Илья Шипицин > Date: вт, 30 апр. 2019 г. в 15:35 > Subject: PATCH: enable cirrus-ci (freebsd builds) > To: HAProxy > > > Hello. > > I enabled basic freebsd CI (yet, it need to be enabled on github.com in > few easy steps) > thanks! > > Ilya Shipitcin >
PATCH: enable cirrus-ci (freebsd builds)
Hello. I enabled basic freebsd CI (yet, it need to be enabled on github.com in few easy steps) thanks! Ilya Shipitcin From c0feb90929b1e8f1987dde27fc9f57c9b6d8fc36 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Tue, 30 Apr 2019 15:33:36 +0500 Subject: [PATCH] BUILD: enable freebsd builds on cirrus-ci --- .cirrus.yml | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 .cirrus.yml diff --git a/.cirrus.yml b/.cirrus.yml new file mode 100644 index ..df5e354a --- /dev/null +++ b/.cirrus.yml @@ -0,0 +1,14 @@ +FreeBSD_task: + freebsd_instance: +image: freebsd-12-0-release-amd64 + env: +ASSUME_ALWAYS_YES: TRUE # required for unattended "pkg" invocation + script: +- pkg install openssl111 git gmake lua53 +- git clone https://github.com/VTest/VTest.git ../vtest +- make -C ../vtest +- gmake CC=clang V=1 TARGET=freebsd USE_ZLIB=1 USE_PCRE=1 USE_OPENSSL=1 USE_LUA=1 LUA_INC=/usr/local/include/lua53 LUA_LIB=/usr/local/lib LUA_LIB_NAME=lua-5.3 +- ./haproxy -vv +- ldd haproxy +- env VTEST_PROGRAM=../vtest/vtest gmake reg-tests || (for folder in /tmp/*regtest*/vtc.*; do cat $folder/INFO $folder/LOG; done && exit 1) + -- 2.20.1
