Re: [PATCH] BUG/MINOR: mux-h1: Correctly report Ti timer when HTX and keepalives are used
Le 12/07/2019 à 16:20, Christopher Faulet a écrit : Le 12/07/2019 à 15:56, David Pirotte a écrit : Sure thing, Christopher. Patch is attached. Thanks! Thanks ! merged now. Sorry, forgot to mention. I slightly amended you patch to also set t_handshake to 0 to have the right Th time. -- Christopher Faulet
Re: [PATCH] BUG/MINOR: mux-h1: Correctly report Ti timer when HTX and keepalives are used
Le 12/07/2019 à 15:56, David Pirotte a écrit : Sure thing, Christopher. Patch is attached. Thanks! Thanks ! merged now. -- Christopher Faulet
Re: [PATCH] BUG/MINOR: mux-h1: Correctly report Ti timer when HTX and keepalives are used
Sure thing, Christopher. Patch is attached. Thanks! Cheers, Dave On Fri, Jul 12, 2019 at 5:00 AM Christopher Faulet wrote: > Le 10/07/2019 à 17:58, David Pirotte a écrit : > > Instructions to reproduce are below. > > > > When HTTP keepalives are used in conjunction with HTX, the Ti timer > reports the > > elapsed time since the beginning of the connection instead of the end of > the > > previous request as stated in the documentation. Tq and Tt also report > > incorrectly as a result. > > > > So, when creating a new h1s, check if it is the first request on > the connection. > > If not, set the session create times to the current timestamp rather > than the > > initial session accept timestamp. This makes the logged timers behave as > stated > > in the documentation. > > > > I hope this is useful, and feedback is welcome if there is a more > correct > > strategy. Thanks! > > > Hi Dave, > > Thanks ! Of course it is useful. However, your patch was mangled by your > mailer. > Could you please resend it as an attachment or using the command "git > send-email" ? > > -- > Christopher Faulet > 0001-BUG-MINOR-mux-h1-Correctly-report-Ti-timer-when-HTX-.patch Description: Binary data
Re: [PATCH] BUG/MINOR: mux-h1: Correctly report Ti timer when HTX and keepalives are used
Le 10/07/2019 à 17:58, David Pirotte a écrit : Instructions to reproduce are below. When HTTP keepalives are used in conjunction with HTX, the Ti timer reports the elapsed time since the beginning of the connection instead of the end of the previous request as stated in the documentation. Tq and Tt also report incorrectly as a result. So, when creating a new h1s, check if it is the first request on the connection. If not, set the session create times to the current timestamp rather than the initial session accept timestamp. This makes the logged timers behave as stated in the documentation. I hope this is useful, and feedback is welcome if there is a more correct strategy. Thanks! Hi Dave, Thanks ! Of course it is useful. However, your patch was mangled by your mailer. Could you please resend it as an attachment or using the command "git send-email" ? -- Christopher Faulet
