Re: [PATCH] BUILD/MINOR cpu counter available for affinity fix proposal for Mac

2021-01-15 Thread Willy Tarreau
On Fri, Jan 15, 2021 at 10:51:57AM +, David CARLIER wrote:
> Oh well the number of threads is just 1 for Mac while having 8 cores
> in my M1, that's about it. I would say backporting to 2.1 should be
> enough if that possible.

Thank you, I'll put that into your message then.

Willy



Re: [PATCH] BUILD/MINOR cpu counter available for affinity fix proposal for Mac

2021-01-15 Thread David CARLIER
Oh well the number of threads is just 1 for Mac while having 8 cores
in my M1, that's about it. I would say backporting to 2.1 should be
enough if that possible.

On Fri, 15 Jan 2021 at 10:20, Willy Tarreau  wrote:
>
> Hi David,
>
> On Fri, Jan 15, 2021 at 08:15:54AM +, David CARLIER wrote:
> > Hi here a little patch proposal for the MacOS case.
>
> Thanks for this one. I'm having a question.
>
> > From 93deb10319b713dfede80b4244bb01c65985794c Mon Sep 17 00:00:00 2001
> > From: David CARLIER 
> > Date: Fri, 15 Jan 2021 08:09:56 +
> > Subject: [PATCH] BUILD/MINOR: Fixes the number of possible cpus report for
> >  Mac.
> >
> > There is no low level api to achieve same as Linux/FreeBSD, we rely
> >  on CPUs available.
>
> I think it's more of a bug than a build issue then. What effect does
> this have on this platform ? Does it start without threads or with not
> enough or too many ? Does this need to be backported, and if so, did
> you spot how far ? (or how far would you need it to be backported?).
> In this case I'd change the subject line and add this info there in
> the message.
>
> Thank you!
> Willy



Re: [PATCH] BUILD/MINOR cpu counter available for affinity fix proposal for Mac

2021-01-15 Thread Willy Tarreau
Hi David,

On Fri, Jan 15, 2021 at 08:15:54AM +, David CARLIER wrote:
> Hi here a little patch proposal for the MacOS case.

Thanks for this one. I'm having a question.

> From 93deb10319b713dfede80b4244bb01c65985794c Mon Sep 17 00:00:00 2001
> From: David CARLIER 
> Date: Fri, 15 Jan 2021 08:09:56 +
> Subject: [PATCH] BUILD/MINOR: Fixes the number of possible cpus report for
>  Mac.
> 
> There is no low level api to achieve same as Linux/FreeBSD, we rely
>  on CPUs available.

I think it's more of a bug than a build issue then. What effect does
this have on this platform ? Does it start without threads or with not
enough or too many ? Does this need to be backported, and if so, did
you spot how far ? (or how far would you need it to be backported?).
In this case I'd change the subject line and add this info there in
the message.

Thank you!
Willy