Re: [PATCH v2] BUG/MEDIUM: stats: add missing INF_BUILD_INFO definition
On Fri, Jan 15, 2021 at 05:58:13PM +0100, Adis Nezirovic wrote: > On 1/15/21 5:01 PM, Willy Tarreau wrote: > > OK thanks. Adis, do you have the ability to recheck for your test case, > > or do you want me to pick it right now ? > > > > Thanks, > > Willy > > > Sorry, I've missed that patch from William. That works for me, my Lua test > case passes. Great, now merged. Thanks to you both! Willy
Re: [PATCH v2] BUG/MEDIUM: stats: add missing INF_BUILD_INFO definition
On Fri, Jan 15, 2021 at 5:58 PM Adis Nezirovic wrote: > (maybe I'll invest some time to contribute a few basic Lua tests, so > things get noted faster). could be nice, even a few basic ones indeed Thanks! -- William
Re: [PATCH v2] BUG/MEDIUM: stats: add missing INF_BUILD_INFO definition
On 1/15/21 5:01 PM, Willy Tarreau wrote: OK thanks. Adis, do you have the ability to recheck for your test case, or do you want me to pick it right now ? Thanks, Willy Sorry, I've missed that patch from William. That works for me, my Lua test case passes. (maybe I'll invest some time to contribute a few basic Lua tests, so things get noted faster). Best regards, -- Adis Nezirovic Software Engineer HAProxy Technologies - Powering your uptime! 375 Totten Pond Road, Suite 302 | Waltham, MA 02451, US +1 (844) 222-4340 | https://www.haproxy.com
Re: [PATCH v2] BUG/MEDIUM: stats: add missing INF_BUILD_INFO definition
On Fri, Jan 15, 2021 at 01:12:33PM +0100, William Dauchy wrote:
> From: Adis Nezirovic
>
> commit 5a982a71656ce885be4b1d4b90b8db31204788a1 ("MINOR:
> contrib/prometheus-exporter: export build_info") is breaking lua
> `core.get_info()`.
>
> This patch makes sure build_info is correctly initialised in all cases.
>
> Reviewed-by: William Dauchy
OK thanks. Adis, do you have the ability to recheck for your test case,
or do you want me to pick it right now ?
Thanks,
Willy
