Re: stable-bot: Bugfixes waiting for a release 2.1 (7), 2.0 (5)

2020-02-25 Thread Willy Tarreau
On Tue, Feb 25, 2020 at 11:41:38PM -0500, Daniel Corbett wrote:
> Good news is the bot is much more dynamic now.  I no longer need to manually
> add new versions and older versions should have their release dates
> automatically adjusted to account for age.  Also, we will see non-LTS
> versions (1.9) disappear from the emails after 1 year of release.  Versions
> older than 3 years will not be in the report either.

Sound good!

Willy



Re: stable-bot: Bugfixes waiting for a release 2.1 (7), 2.0 (5)

2020-02-25 Thread Daniel Corbett

Hey Tim & Willy,

On 2/25/20 10:45 PM, Willy Tarreau wrote:

On Wed, Feb 26, 2020 at 01:23:24AM +0100, Tim Düsterhus wrote:

Daniel,

I already told you in IRC, but as I now have an email to reply to: This
new email format is much better than the old one.

FWIW I agree, it's more synthetic and still seems to contain all the
relevant information.

Thanks for these changes!
Willy


Thanks for the feedback!  Tim, I've immediately implemented your 
suggestion around the dashes.  I'll look into the alignment recommendations.


Glad I could help improve the output (required quite a bit of refactoring!)

Good news is the bot is much more dynamic now.  I no longer need to 
manually add new versions and older versions should have their release 
dates automatically adjusted to account for age.  Also, we will see 
non-LTS versions (1.9) disappear from the emails after 1 year of 
release.  Versions older than 3 years will not be in the report either.


Thanks again for all of the feedback and suggestions.

Thanks,
-- Daniel



Re: stable-bot: Bugfixes waiting for a release 2.1 (7), 2.0 (5)

2020-02-25 Thread Willy Tarreau
On Wed, Feb 26, 2020 at 01:23:24AM +0100, Tim Düsterhus wrote:
> Daniel,
> 
> I already told you in IRC, but as I now have an email to reply to: This
> new email format is much better than the old one.

FWIW I agree, it's more synthetic and still seems to contain all the
relevant information.

Thanks for these changes!
Willy



Re: stable-bot: Bugfixes waiting for a release 2.1 (7), 2.0 (5)

2020-02-25 Thread Tim Düsterhus
Daniel,

I already told you in IRC, but as I now have an email to reply to: This
new email format is much better than the old one.

I have a few more small suggestions inline below:

Am 26.02.20 um 01:00 schrieb stable-...@haproxy.com:
> Hi,
> 
> This is a friendly bot that watches fixes pending for the next haproxy-stable 
> release!  One such e-mail is sent periodically once patches are waiting in 
> the last maintenance branch, and an ideal release date is computed based on 
> the severity of these fixes and their merge date.  Responses to this mail 
> must be sent to the mailing list.
> 
> 
> Last release 2.1.3 was issued on 2020-02-12.  There are currently 7 patches 
> in the queue cut down this way:
> - 1 MAJOR, first one merged on 2020-02-21
> - 1 MEDIUM, first one merged on 2020-02-21
> - 5 MINOR, first one merged on 2020-02-21

Consider aligning the "first one ..." part to avoid that jagged
formatting, due to MEDIUM (and CRITICAL, though I assume we'll never see
that) being longer the the other severities. Make sure to test two-digit
patch numbers.

> Thus the computed ideal release date for 2.1.4 would be 2020-03-06, which is 
> in two weeks or less.
> 
> Last release 2.0.13 was issued on 2020-02-13.  There are currently 5 patches 
> in the queue cut down this way:
> - 1 MAJOR, first one merged on 2020-02-21
> - 1 MEDIUM, first one merged on 2020-02-21
> - 3 MINOR, first one merged on 2020-02-21
> 
> Thus the computed ideal release date for 2.0.14 would be 2020-03-06, which is 
> in two weeks or less.
> 
> The current list of patches in the queue is:
>  - 2.0, 2.1  - MAJOR   : http-ana: Always abort the request 
> when a tarpit is triggered
>  - 2.0, 2.1  - MEDIUM  : muxes: Use the right argument when 
> calling the destroy method.
>  - 2.0, 2.1  - MINOR   : filters: Count HTTP headers as 
> filtered data but don't forward them
>  - 2.0, 2.1  - MINOR   : namespace: avoid closing fd when 
> socket failed in my_socketat
>  - 2.0, 2.1  - MINOR   : http-ana: Matching on monitor-uri 
> should be case-sensitive
>  - 2.1   - MINOR   : http-htx: Don't return error if 
> authority is updated without changes
>  - 2.1   - MINOR   : mux-fcgi: Forbid special characters 
> when matching PATH_INFO param
> 
> ---

Consider replacing "---" with "-- " (including the space after the
hyphens). It will then be treated as an email signature (RFC 3676#4.3).
My email client automatically tones down the color of signatures and
strips them when replying. And de facto this last paragraph is a signature.

> The haproxy stable-bot is freely provided by HAProxy Technologies to help 
> improve the quality of each HAProxy release.  If you have any issue with 
> these emails or if you want to suggest some improvements, please post them on 
> the list so that the solutions suiting the most users can be found.
> 

Best regards
Tim Düsterhus



stable-bot: Bugfixes waiting for a release 2.1 (7), 2.0 (5)

2020-02-25 Thread stable-bot
Hi,

This is a friendly bot that watches fixes pending for the next haproxy-stable 
release!  One such e-mail is sent periodically once patches are waiting in the 
last maintenance branch, and an ideal release date is computed based on the 
severity of these fixes and their merge date.  Responses to this mail must be 
sent to the mailing list.


Last release 2.1.3 was issued on 2020-02-12.  There are currently 7 patches in 
the queue cut down this way:
- 1 MAJOR, first one merged on 2020-02-21
- 1 MEDIUM, first one merged on 2020-02-21
- 5 MINOR, first one merged on 2020-02-21

Thus the computed ideal release date for 2.1.4 would be 2020-03-06, which is in 
two weeks or less.

Last release 2.0.13 was issued on 2020-02-13.  There are currently 5 patches in 
the queue cut down this way:
- 1 MAJOR, first one merged on 2020-02-21
- 1 MEDIUM, first one merged on 2020-02-21
- 3 MINOR, first one merged on 2020-02-21

Thus the computed ideal release date for 2.0.14 would be 2020-03-06, which is 
in two weeks or less.

The current list of patches in the queue is:
 - 2.0, 2.1  - MAJOR   : http-ana: Always abort the request 
when a tarpit is triggered
 - 2.0, 2.1  - MEDIUM  : muxes: Use the right argument when 
calling the destroy method.
 - 2.0, 2.1  - MINOR   : filters: Count HTTP headers as 
filtered data but don't forward them
 - 2.0, 2.1  - MINOR   : namespace: avoid closing fd when 
socket failed in my_socketat
 - 2.0, 2.1  - MINOR   : http-ana: Matching on monitor-uri 
should be case-sensitive
 - 2.1   - MINOR   : http-htx: Don't return error if 
authority is updated without changes
 - 2.1   - MINOR   : mux-fcgi: Forbid special characters 
when matching PATH_INFO param

---
The haproxy stable-bot is freely provided by HAProxy Technologies to help 
improve the quality of each HAProxy release.  If you have any issue with these 
emails or if you want to suggest some improvements, please post them on the 
list so that the solutions suiting the most users can be found.