[jira] [Updated] (HDFS-17466) Remove FsVolumeList#getVolumes() invocation out of DataSetLock

2024-04-14 Thread farmmamba (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-17466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

farmmamba updated HDFS-17466:
-
Parent: HDFS-15382
Issue Type: Sub-task  (was: Improvement)

> Remove FsVolumeList#getVolumes() invocation out of DataSetLock
> --
>
> Key: HDFS-17466
> URL: https://issues.apache.org/jira/browse/HDFS-17466
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: datanode
>Affects Versions: 3.4.0
>Reporter: farmmamba
>Assignee: farmmamba
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17466) Remove FsVolumeList#getVolumes() invocation out of DataSetLock

2024-04-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837061#comment-17837061
 ] 

ASF GitHub Bot commented on HDFS-17466:
---

hfutatzhanghb opened a new pull request, #6728:
URL: https://github.com/apache/hadoop/pull/6728

   ### Description of PR
   We can remove FsVolumeList#getVolumes() invocation out of DataSetLock, 
because remove volumes are not protected by 
   DataSetLock.  
   
   We should remove global fields not protected by DataSetLock to make it more 
clearly.




> Remove FsVolumeList#getVolumes() invocation out of DataSetLock
> --
>
> Key: HDFS-17466
> URL: https://issues.apache.org/jira/browse/HDFS-17466
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: datanode
>Affects Versions: 3.4.0
>Reporter: farmmamba
>Assignee: farmmamba
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDFS-17466) Remove FsVolumeList#getVolumes() invocation out of DataSetLock

2024-04-14 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-17466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HDFS-17466:
--
Labels: pull-request-available  (was: )

> Remove FsVolumeList#getVolumes() invocation out of DataSetLock
> --
>
> Key: HDFS-17466
> URL: https://issues.apache.org/jira/browse/HDFS-17466
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: datanode
>Affects Versions: 3.4.0
>Reporter: farmmamba
>Assignee: farmmamba
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Created] (HDFS-17466) Remove FsVolumeList#getVolumes() invocation out of DataSetLock

2024-04-14 Thread farmmamba (Jira)
farmmamba created HDFS-17466:


 Summary: Remove FsVolumeList#getVolumes() invocation out of 
DataSetLock
 Key: HDFS-17466
 URL: https://issues.apache.org/jira/browse/HDFS-17466
 Project: Hadoop HDFS
  Issue Type: Improvement
  Components: datanode
Affects Versions: 3.4.0
Reporter: farmmamba
Assignee: farmmamba






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17462) NPE in Router concat when trg is an empty file.

2024-04-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837049#comment-17837049
 ] 

ASF GitHub Bot commented on HDFS-17462:
---

fannaihao commented on PR #6722:
URL: https://github.com/apache/hadoop/pull/6722#issuecomment-2054796201

   @ayushtkn Thanks for the comment! I will add tests for this.
   Yes, I also think it's better to have a direct way to get the block pool id 
of an empty file then verify, but I failed to find such methods..
   I checked `getFileInfo`, seems it does not return info about block pool id? 
If I miss something, please let me know.
   The `expectedBlockPoolId` thing is somehow indirect, but it works right..




> NPE in Router concat when trg is an empty file.
> ---
>
> Key: HDFS-17462
> URL: https://issues.apache.org/jira/browse/HDFS-17462
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 2.10.2, 3.3.6
>Reporter: NaihaoFan
>Priority: Minor
>  Labels: pull-request-available
>
> When trg of Router concat is an empty file, it will trigger NPE in Router, 
> and the concat will fail, example:
> This is because when trg is an empty file, NameNode will return 
> lastLocatedBlock as null in the response of getBlockLocations. And Router 
> will not check null of lastLocatedBlock returned, instead Router will use it 
> to get block pool id directly.
> Trg of concat is an empty file should be allowed in router since this case is 
> supported by concat of NameNode.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837048#comment-17837048
 ] 

Xiping Zhang commented on HDFS-17465:
-

[~goiri]   Hi, this is an obvious logical problem, the failure of the use case 
has nothing to do with it, can you help to merge  it?

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Affects Versions: 3.5.0
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiping Zhang updated HDFS-17465:

Affects Version/s: 3.5.0

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Affects Versions: 3.5.0
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Reopened] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiping Zhang reopened HDFS-17465:
-

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17383) Datanode current block token should come from active NameNode in HA mode

2024-04-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837042#comment-17837042
 ] 

ASF GitHub Bot commented on HDFS-17383:
---

ThinkerLei commented on PR #6562:
URL: https://github.com/apache/hadoop/pull/6562#issuecomment-2054527922

   @zhangshuyan0 Thank you very much for your comment. The case you mentioned 
has been fixed. When there is no active namenode, the currentKey will be set to 
one of the standby nodes. When a failover occurs, the active namenode will 
proactively trigger the distribution of the key to the DataNode to promptly 
modify the currentKey.




> Datanode current block token should come from active NameNode in HA mode
> 
>
> Key: HDFS-17383
> URL: https://issues.apache.org/jira/browse/HDFS-17383
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: lei w
>Priority: Major
>  Labels: pull-request-available
> Attachments: reproduce.diff
>
>
> We found that transfer block failed during the namenode upgrade. The specific 
> error reported was that the block token verification failed. The reason is 
> that during the datanode transfer block process, the source datanode uses its 
> own generated block token, and the keyid comes from ANN or SBN. However, 
> because the newly upgraded NN has just been started, the keyid owned by the 
> source datanode may not be owned by the target datanode, so the write fails. 
> Here's how to reproduce this situation in the attachment



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837030#comment-17837030
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

zhangxiping1 commented on code in PR #6727:
URL: https://github.com/apache/hadoop/pull/6727#discussion_r1565052852


##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/ProportionRouterRpcFairnessPolicyController.java:
##
@@ -93,7 +93,8 @@ public boolean acquirePermit(String nsId) {
   public void releasePermit(String nsId) {
 if (contains(nsId)) {
   super.releasePermit(nsId);
+} else {
+  super.releasePermit(DEFAULT_NS);
 }

Review Comment:
   yes, thank you for your reply,the effect is the same. : )





> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836937#comment-17836937
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

hadoop-yetus commented on PR #6727:
URL: https://github.com/apache/hadoop/pull/6727#issuecomment-2054000539

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 33s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  45m 34s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 38s |  |  trunk passed with JDK 
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1  |
   | +1 :green_heart: |  compile  |   0m 36s |  |  trunk passed with JDK 
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06  |
   | +1 :green_heart: |  checkstyle  |   0m 27s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 40s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  |  trunk passed with JDK 
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  trunk passed with JDK 
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06  |
   | -1 :x: |  spotbugs  |   1m 21s | 
[/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6727/1/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf-warnings.html)
 |  hadoop-hdfs-project/hadoop-hdfs-rbf in trunk has 1 extant spotbugs 
warnings.  |
   | +1 :green_heart: |  shadedclient  |  34m  7s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 31s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 32s |  |  the patch passed with JDK 
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1  |
   | +1 :green_heart: |  javac  |   0m 32s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 27s |  |  the patch passed with JDK 
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06  |
   | +1 :green_heart: |  javac  |   0m 27s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 19s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   0m 33s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  |  the patch passed with JDK 
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  |  the patch passed with JDK 
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06  |
   | +1 :green_heart: |  spotbugs  |   1m 20s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  34m 32s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  29m 11s |  |  hadoop-hdfs-rbf in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 38s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 159m  5s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6727/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/6727 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux c32de0b16bf5 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 
15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / b2b6b60c22e4e45abdb2cc8ad1c1715bd9aca8c3 |
   | Default Java | Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6727/1/testReport/ |
   | Max. process+thread count | 3446 (vs. ulimit of 5500) 

[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836921#comment-17836921
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

KeeProMise commented on code in PR #6727:
URL: https://github.com/apache/hadoop/pull/6727#discussion_r1564577262


##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/ProportionRouterRpcFairnessPolicyController.java:
##
@@ -93,7 +93,8 @@ public boolean acquirePermit(String nsId) {
   public void releasePermit(String nsId) {
 if (contains(nsId)) {
   super.releasePermit(nsId);
+} else {
+  super.releasePermit(DEFAULT_NS);
 }

Review Comment:
   hi, LGTM. Personal opinion, whether it can be written like this.
   ```java
   if (contains(nsId)) {
  super.releasePermit(nsId);
  return;
   }
   super.releasePermit(DEFAULT_NS);
   ```





> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17438) RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority.

2024-04-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836916#comment-17836916
 ] 

ASF GitHub Bot commented on HDFS-17438:
---

KeeProMise commented on PR #6655:
URL: https://github.com/apache/hadoop/pull/6655#issuecomment-2053977983

   @goiri hi, If you have time, please take a look again, thanks.




> RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority.
> -
>
> Key: HDFS-17438
> URL: https://issues.apache.org/jira/browse/HDFS-17438
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Jian Zhang
>Assignee: Jian Zhang
>Priority: Major
>  Labels: pull-request-available
> Attachments: HDFS-17438.001.patch
>
>
> At present, when the status of all namenodes in an ns in the router is the 
> same, the namenode which is the newest reported will be placed at the top of 
> the cache. when the client accesses the ns through the router, it will first 
> access the namenode.
> If multiple namenodes in this route are in an active state, or if there are 
> namenodes with multiple observer states, the existing logic is not a problem, 
> because the newest reported active or observer state namenode have a higher 
> probability of being true active or observer compared to the namenode that 
> reported active or observer state a long time ago.
> Similarly, the newest reported namenode with a status of standby or 
> unavailable has a higher probability of being a standby or unavailable 
> namenode compared to the namenode reported with a status of standby or 
> unavailable a long time ago. Therefore, the newest nn reported as standby or 
> unavailable status should have a lower priority for access, the oldest nn 
> reported as standby or unavailable status should have a higher priority for 
> access.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836915#comment-17836915
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

KeeProMise commented on code in PR #6727:
URL: https://github.com/apache/hadoop/pull/6727#discussion_r1564577262


##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/ProportionRouterRpcFairnessPolicyController.java:
##
@@ -93,7 +93,8 @@ public boolean acquirePermit(String nsId) {
   public void releasePermit(String nsId) {
 if (contains(nsId)) {
   super.releasePermit(nsId);
+} else {
+  super.releasePermit(DEFAULT_NS);
 }

Review Comment:
   Personal opinion, whether it can be written like this.
   ```java
   if (contains(nsId)) {
  super.releasePermit(nsId);
  return;
   }
   super.releasePermit(DEFAULT_NS);
   ```





> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Jian Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836914#comment-17836914
 ] 

Jian Zhang commented on HDFS-17465:
---

[~zhangxiping] hi, The code of our own cluster is a little different from the 
community code, so we did not find this problem. But this bug really needs to 
be fixed, thanks.

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836908#comment-17836908
 ] 

Xiping Zhang commented on HDFS-17465:
-

[~Keepromise]   hi , will your cluster trigger this issue as well? 

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836907#comment-17836907
 ] 

Xiping Zhang edited comment on HDFS-17465 at 4/14/24 8:23 AM:
--

!image-2024-04-14-16-07-32-362.png!

Permit should not always be released here. Maximum permit count exceeded

arthas traces to default_ns permit leakage :

!image-2024-04-14-16-23-18-499.png!

 


was (Author: zhangxiping):
!image-2024-04-14-16-07-32-362.png!

Permit should not always be released here. Maximum permit count exceeded

 

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836907#comment-17836907
 ] 

Xiping Zhang commented on HDFS-17465:
-

!image-2024-04-14-16-07-32-362.png!

Permit should not always be released here. Maximum permit count exceeded

 

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiping Zhang updated HDFS-17465:

Attachment: image-2024-04-14-16-07-32-362.png

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Resolved] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiping Zhang resolved HDFS-17465.
-
Resolution: Fixed

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836905#comment-17836905
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

zhangxiping1 opened a new pull request, #6727:
URL: https://github.com/apache/hadoop/pull/6727

   …“'ava.Lang. Error: Maximum permit count exceeded'
   
   
   
   ### Description of PR
   
   
   ### How was this patch tested?
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
> Attachments: image-2024-04-14-15-39-59-531.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HDFS-17465:
--
Labels: pull-request-available  (was: )

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Created] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira)
Xiping Zhang created HDFS-17465:
---

 Summary: RBF: Use ProportionRouterRpcFairnessPolicyController get  
“java.Lang. Error: Maximum permit count exceeded”
 Key: HDFS-17465
 URL: https://issues.apache.org/jira/browse/HDFS-17465
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: rbf
Reporter: Xiping Zhang
Assignee: Xiping Zhang
 Attachments: image-2024-04-14-15-39-59-531.png

!image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org