[jira] [Comment Edited] (HDDS-1025) Handle replication of closed containers in DeadNodeHanlder
[ https://issues.apache.org/jira/browse/HDDS-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757927#comment-16757927 ] Yiqun Lin edited comment on HDDS-1025 at 2/1/19 3:31 AM: - LGTM, +1. Thanks for addressing the comment, [~bharatviswa]! I would just commit the latest patch now. was (Author: linyiqun): LGTM, +1. Thanks for addressing the comment, [~bharatviswa]! > Handle replication of closed containers in DeadNodeHanlder > -- > > Key: HDDS-1025 > URL: https://issues.apache.org/jira/browse/HDDS-1025 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Attachments: HDDS-1025.00.patch, HDDS-1025.01.patch, > HDDS-1025.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > This Jira is to do one of the TODO mentioned in the DeadNodeHandler > // TODO: Check replica count and call replication manager. > > As Right now, when a node is dead, replication for the closed containers is > not triggered. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1025) Handle replication of closed containers in DeadNodeHanlder
[ https://issues.apache.org/jira/browse/HDDS-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757684#comment-16757684 ] Bharat Viswanadham edited comment on HDDS-1025 at 1/31/19 8:48 PM: --- Thank you [~linyiqun] for review. Addressed the review comments in patch v02 Not added LOG for container open, as we plan to open the Jira and fix the TODO, but in the test for open containers, checked that we should not have the request in the log. was (Author: bharatviswa): Thank you [~linyiqun] for review. Addressed the review comments in patch v02 Not added LOG for container open, as we plan to open the Jira and fix the TODO, but checked for open containers we don't have the request for open container in the log. > Handle replication of closed containers in DeadNodeHanlder > -- > > Key: HDDS-1025 > URL: https://issues.apache.org/jira/browse/HDDS-1025 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Attachments: HDDS-1025.00.patch, HDDS-1025.01.patch, > HDDS-1025.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > This Jira is to do one of the TODO mentioned in the DeadNodeHandler > // TODO: Check replica count and call replication manager. > > As Right now, when a node is dead, replication for the closed containers is > not triggered. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1025) Handle replication of closed containers in DeadNodeHanlder
[ https://issues.apache.org/jira/browse/HDDS-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756681#comment-16756681 ] Bharat Viswanadham edited comment on HDDS-1025 at 1/31/19 12:24 AM: This patch has taken care of only closed/quasi_close containers. If their expected replica count is not matching with the existing replica count, fired a ReplicaRequest event. was (Author: bharatviswa): This patch has taken care of only closed/quasi_close containers. If their expected replica count is not matching with expected, firing a ReplicaRequest event. > Handle replication of closed containers in DeadNodeHanlder > -- > > Key: HDDS-1025 > URL: https://issues.apache.org/jira/browse/HDDS-1025 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Attachments: HDDS-1025.00.patch > > > This Jira is to do one of the TODO mentioned in the DeadNodeHandler > // TODO: Check replica count and call replication manager. > > As Right now, when a node is dead, replication for the closed containers is > not triggered. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
