[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809671#comment-16809671 ] Yiqun Lin edited comment on HDDS-1189 at 4/4/19 9:36 AM: - Committed this to trunk with checkstyle issue fixed. Thanks [~swagle] for the contribution and [~avijayan], [~elek], [~arpitagarwal] for additional reviews. was (Author: linyiqun): Committed this to trunk. Thanks [~swagle] for the contribution and [~avijayan], [~elek], [~arpitagarwal] for additional reviews. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch, > HDDS-1189.03.patch, HDDS-1189.04.patch, HDDS-1189.05.patch, > HDDS-1189.06.patch, HDDS-1189.08.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809505#comment-16809505 ] Siddharth Wagle edited comment on HDDS-1189 at 4/4/19 4:53 AM: --- [~arpitagarwal]/[~linyiqun] Rebased patch attached. was (Author: swagle): [~arpitagarwal] Rebased patch attached. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch, > HDDS-1189.03.patch, HDDS-1189.04.patch, HDDS-1189.05.patch, > HDDS-1189.06.patch, HDDS-1189.08.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808970#comment-16808970 ] Siddharth Wagle edited comment on HDDS-1189 at 4/3/19 5:43 PM: --- Hi [~elek], I looked at the spring-jdbc pom file and went through all the dependencies. The only other thing of note, non-ASL was, "com.h2database.h2" which is EPL 1.0 and is already in the LICENSE.txt was (Author: swagle): Hi [~elek], I looked at the spring-jdbc pom file and went through all the dependencies. The only other thing of note non-ASL was "com.h2database.h2" which is EPL 1.0 and is already in the LICENSE.txt > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch, > HDDS-1189.03.patch, HDDS-1189.04.patch, HDDS-1189.05.patch, HDDS-1189.06.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808263#comment-16808263 ] Siddharth Wagle edited comment on HDDS-1189 at 4/3/19 4:58 AM: --- Thanks [~elek] and [~avijayan] for your reviews. Addressed the comments in 05 as below: _License issue_: - Removed HSQLDB dependency and reverted to using in-memory sqlite for code generation, the hsqldb license is actually a copy of BSD but there was an alternate way out so went with that. - spring-jdbc is Apache v2 _Configuration issues_: - Used the recon.db.dir for constructing default url - There is no password field tag, checked source tree - The findbugs plugin does not apply recursively, hence need to be explicit was (Author: swagle): Thanks [~elek] and [~avijayan] for your reviews. Addressed the comments in 05 as below: _License issue_: - Removed HSQLDB dependency and reverted to using in-memory sqlite for code generation, the hsqldb license is actually a copy of BSD but there was an alternate way out so went with that. - spring-jdbc is Apache v2 _Configuration issues_: - Used the recon.dbdir for constructing default url - There is no password field tag, checked source tree - The findbugs plugin does not apply recursively, hence need to be explicit > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch, > HDDS-1189.03.patch, HDDS-1189.04.patch, HDDS-1189.05.patch, HDDS-1189.06.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808263#comment-16808263 ] Siddharth Wagle edited comment on HDDS-1189 at 4/3/19 4:58 AM: --- Thanks [~elek] and [~avijayan] for your reviews. Addressed the comments in 05 as below: _License issue_: - Removed HSQLDB dependency and reverted to using in-memory sqlite for code generation, the hsqldb license is actually a copy of BSD but there was an alternate way out so went with that. - spring-jdbc is Apache v2 _Configuration issues_: - Used the recon.dbdir for constructing default url - There is no password field tag, checked source tree - The findbugs plugin does not apply recursively, hence need to be explicit was (Author: swagle): Thanks [~elek] and [~avijayan] for your reviews. Addressed the comments in 05 as below: _License issue_: - Removed HSQLDB dependency and reverted to using in-memory sqlite for code generation, the hsqldb license is actually BSD but there was an alternate way out so went with that. - spring-jdbc is Apache v2 _Configuration issues_: - Used the recon.dbdir for constructing default url - There is no password field tag, checked source tree - The findbugs plugin does not apply recursively, hence need to be explicit > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch, > HDDS-1189.03.patch, HDDS-1189.04.patch, HDDS-1189.05.patch, HDDS-1189.06.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805154#comment-16805154 ] Siddharth Wagle edited comment on HDDS-1189 at 3/29/19 4:06 PM: Hi [~linyiqun], 1. It is not a test program, it is in the maven lifecycle, Recon cannot build without the generating Pojos and Dao objects. Reason for raising the exception is that devs can call code generator using something like "mvn exec:java" as well. 2. Sorry missed that, thanks for pointing out. 3. Will get that in the next version along with config fields. was (Author: swagle): Hi [~linyiqun], 1. it is not a test program, it is in the maven lifecycle, Recon cannot build without the generating Pojos and Dao objects. Reason for raising the exception is that devs can call code generator using something like "mvn exec:java" as well. 2. Sorry missed that, thanks for pointing out. 3. Will get that in the next version along with config fields. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch, > HDDS-1189.03.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804037#comment-16804037 ] Siddharth Wagle edited comment on HDDS-1189 at 3/29/19 1:09 AM: Hi [~linyiqun], thanks for the first review. - Adding the javadoc for better understanding to JooqCodeGenerator. The main method of JooqCodeGenerator is called by maven lifecycle to generate code. - ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the generated DAO objects. I will add a unit test to make this point clear. - This is meant to be a skeleton patch that introduces all key components, specifically: codegen, ORM and transactions without introducing noise. I will add more unit tests, certainly, but want to keep it small enough to review and understand. The other tables will be added along with API and logic to populate utilization data, in short, more functional in nature. With this patch, anybody who wants to add a table gets POJOs and DAO for free with only need to add 1 function call in the ShemaDefinition. was (Author: swagle): Hi [~linyiqun], thanks for the first review. - Adding the javadoc for better understanding to JooqCodeGenerator. The main method of JooqCodeGenerator is called by maven lifecycle to generate code. - ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the generated DAO objects. I will add a unit test to make this point clear. - This is meant to be a skeleton patch that introduces all key components, specifically: codegen, ORM and transactions without introducing noise. I will add more unit tests, certainly, but want to keep it small enough to review and understand. The other tables will be added along with API and logic to populate utilization data, in short, more functional in nature. Anybody who wants to add a table gets POJOs and DAO for free with only need to add 1 function call in the ShemaDefinition. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch, > HDDS-1189.03.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804496#comment-16804496 ] Siddharth Wagle edited comment on HDDS-1189 at 3/29/19 1:07 AM: 03 => Addressed comments from [~linyiqun] and fixed checkstyle issues. was (Author: swagle): 03 => Addressed comments from [~linyiqun] and fix checkstyle issues. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch, > HDDS-1189.03.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804037#comment-16804037 ] Siddharth Wagle edited comment on HDDS-1189 at 3/28/19 10:59 PM: - Hi [~linyiqun], thanks for the first review. - Adding the javadoc for better understanding to JooqCodeGenerator. The main method of JooqCodeGenerator is called by maven lifecycle to generate code. - ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the generated DAO objects. I will add a unit test to make this point clear. - This is meant to be a skeleton patch that introduces all key components, specifically: codegen, ORM and transactions without introducing noise. I will add more unit tests, certainly, but want to keep it small enough to review and understand. The other tables will be added along with API and logic to populate utilization data, in short, more functional in nature. Anybody who wants to add a table gets POJOs and DAO for free with only need to add 1 function call in the ShemaDefinition. was (Author: swagle): Hi [~linyiqun], thanks for the first review. - ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the generated DAO objects. I will add a unit test to make this point clear. - Adding the javadoc for better understanding to JooqCodeGenerator. The main method of JooqCodeGenerator is called by maven lifecycle to generate code. - This is meant to be a skeleton patch that introduces all key components, specifically: codegen, ORM and transactions without introducing noise. I will add more unit tests, certainly, but want to keep it small enough to review and understand. The other tables will be added along with API and logic to populate utilization data, in short, more functional in nature. Anybody who wants to add a table gets POJOs and DAO for free with only need to add 1 function call in the ShemaDefinition. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804037#comment-16804037 ] Siddharth Wagle edited comment on HDDS-1189 at 3/28/19 10:58 PM: - Hi [~linyiqun], thanks for the first review. - ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the generated DAO objects. I will add a unit test to make this point clear. - Adding the javadoc for better understanding to JooqCodeGenerator. The main method of JooqCodeGenerator is called by maven lifecycle to generate code. - This is meant to be a skeleton patch that introduces all key components, specifically: codegen, ORM and transactions without introducing noise. I will add more unit tests, certainly, but want to keep it small enough to review and understand. The other tables will be added along with API and logic to populate utilization data, in short, more functional in nature. Anybody who wants to add a table gets POJOs and DAO for free with only need to add 1 function call in the ShemaDefinition. was (Author: swagle): Hi [~linyiqun], thanks for the first review. - ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the generated DAO objects. I will add a unit test to make this point clear. - This is meant to be a skeleton patch that introduces all key components, specifically: codegen, ORM and transactions without introducing noise. I will add more unit tests, certainly, but want to keep it small enough to review and understand. The other tables will be added along with API and logic to populate utilization data, in short, more functional in nature. Anybody who wants to add a table gets POJOs and DAO for free with only need to add 1 function call in the ShemaDefinition. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803622#comment-16803622 ] Siddharth Wagle edited comment on HDDS-1189 at 3/28/19 3:45 PM: _Patch adds following functionality_: - Persistence module based on Jooq ORM - Auto code generation feature for POJOS and DAO objects that can be used to manipulate recon SQL DB - SQL lite default database injection - Java-based DDL generation example for future patches. _General theme_: *minimize boilerplate* and *dialect independent* cc: [~arpitagarwal]/[~avijayan]/[~linyiqun] for taking a look when possible. was (Author: swagle): _Patch adds following functionality_: - Persistence module based on Jooq ORM - Auto code generation feature for POJOS and DAO objects that can be used to manipulate recon SQL DB - SQL lite default database injection - Java-based DDL generation example for future patches. _General theme_: *minimize boilerplate* and "dialect independent* cc: [~arpitagarwal]/[~avijayan]/[~linyiqun] for taking a look when possible. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803622#comment-16803622 ] Siddharth Wagle edited comment on HDDS-1189 at 3/28/19 3:44 PM: _Patch adds following functionality_: - Persistence module based on Jooq ORM - Auto code generation feature for POJOS and DAO objects that can be used to manipulate recon SQL DB - SQL lite default database injection - Java-based DDL generation example for future patches. _General theme_: *minimize boilerplate* and "dialect independent* cc: [~arpitagarwal]/[~avijayan]/[~linyiqun] for taking a look when possible. was (Author: swagle): _Patch adds following functionality_: - Persistence module based on Jooq ORM - Auto code generation feature for POJOS and DAO objects that can be used to manipulate recon SQL DB - SQL lite default database injection - Java-based DDL generation example for future patches. cc: [~arpitagarwal]/[~avijayan]/[~linyiqun] for taking a look when possible. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804037#comment-16804037 ] Siddharth Wagle edited comment on HDDS-1189 at 3/28/19 3:41 PM: Hi [~linyiqun], thanks for the first review. - ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the generated DAO objects. I will add a unit test to make this point clear. - This is meant to be a skeleton patch that introduces all key components, specifically: codegen, ORM and transactions without introducing noise. I will add more unit tests, certainly, but want to keep it small enough to review and understand. The other tables will be added along with API and logic to populate utilization data, in short, more functional in nature. Anybody who wants to add a table gets POJOs and DAO for free with only need to add 1 function call in the ShemaDefinition. was (Author: swagle): Hi [~linyiqun], thanks for the first review. - ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the generated DAO objects. I will add a unit test to make this point clear. - This is meant to be a skeleton patch that introduces all key components, specifically: codegen, ORM and transactions without introducing noise. I will add more unit tests, certainly, but want to keep it small enough to review and understand. The other tables will be added along with API and logic to populate utilization data, in short, more functional in nature. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804037#comment-16804037 ] Siddharth Wagle edited comment on HDDS-1189 at 3/28/19 3:40 PM: Hi [~linyiqun], thanks for the first review. - ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the generated DAO objects. I will add a unit test to make this point clear. - This is meant to be a skeleton patch that introduces all key components, specifically: codegen, ORM and transactions without introducing noise. I will add more unit tests, certainly, but want to keep it small enough to review and understand. The other tables will be added along with API and logic to populate utilization data, in short, more functional in nature. was (Author: swagle): Hi [~linyiqun], thanks for the first review. - ReconSchemaDefinition is only DDL creation, all the CRUD operations are contained in the generated DAO objects. I will add a unit test to make this point clear. - This is meant to be a skeleton patch that introduces all key components, specifically: codegen, ORM and transactions without introducing noise. I will add more unit tests certainly but want to keep it small enough to review and understand. The other tables will be added along with API and logic to populate utilization data, in short, more functional in nature. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDDS-1189) Recon Aggregate DB schema and ORM
[ https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803622#comment-16803622 ] Siddharth Wagle edited comment on HDDS-1189 at 3/28/19 6:30 AM: _Patch adds following functionality_: - Persistence module based on Jooq ORM - Auto code generation feature for POJOS and DAO objects that can be used to manipulate recon SQL DB - SQL lite default database injection - Java-based DDL generation example for future patches. cc: [~arpitagarwal]/[~avijayan]/[~linyiqun] for taking a look when possible. was (Author: swagle): _Patch adds following functionality_: - Persistence module based on Jooq ORM - Auto code generation feature for POJOS and DAO objects that can be used to manipulated recon SQL DB - SQL lite default database injection - Java-based DDL generation example for future patches. > Recon Aggregate DB schema and ORM > - > > Key: HDDS-1189 > URL: https://issues.apache.org/jira/browse/HDDS-1189 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Affects Versions: 0.5.0 >Reporter: Siddharth Wagle >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1189.01.patch > > > _Objectives_ > - Define V1 of the db schema for recon service > - The current proposal is to use jOOQ as the ORM for SQL interaction. For two > main reasons: a) powerful DSL for querying, that abstracts out SQL dialects, > b) Allows code to schema and schema to code seamless transition, critical for > creating DDL through the code and unit testing across versions of the > application. > - Add e2e unit tests suite for Recon entities, created based on the design doc -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
