[jira] [Comment Edited] (HDFS-13530) NameNode: Fix NullPointerException when getQuotaUsageInt() invoked

2018-05-07 Thread Ajay Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466267#comment-16466267
 ] 

Ajay Kumar edited comment on HDFS-13530 at 5/7/18 6:13 PM:
---

[~liuhongtong] thanks for filing the jira and submitting the patch. patch looks 
good, mind adding a test case?


was (Author: ajayydv):
[~liuhongtong] thanks for filing the jira and submitting the patch. mind adding 
a test case?

> NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
> --
>
> Key: HDFS-13530
> URL: https://issues.apache.org/jira/browse/HDFS-13530
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: federation, namenode
>Reporter: liuhongtong
>Priority: Major
> Attachments: HDFS-13530.001.patch
>
>
> If the directory is nonexistent, getQuotaUsage rpc call will run into 
> NullPointerException throwed by
> FSDirStatAndListingOp.getQuotaUsageInt() .
> I think FSDirStatAndListingOp.getQuotaUsageInt() should throw 
> FileNotFoundException when the directory is nonexistent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (HDFS-13530) NameNode: Fix NullPointerException when getQuotaUsageInt() invoked

2018-05-07 Thread liuhongtong (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465516#comment-16465516
 ] 

liuhongtong edited comment on HDFS-13530 at 5/7/18 6:58 AM:


 
{code:java}
[ERROR] TestWebHdfsTimeouts.testTwoStepWriteConnectTimeout:245 expected timeout 
[ERROR] TestWebHdfsTimeouts.testTwoStepWriteConnectTimeout:245 expected timeout 
[ERROR] Errors: [ERROR] 
TestDataNodeVolumeFailureReporting.testVolFailureStatsPreservedOnNNRestart:283 
? Timeout [INFO] [ERROR] Tests run: 5557, Failures: 10, Errors: 1, Skipped: 21
{code}
I'm innocent, and this unit test failure is irrelevant with the modified code.


was (Author: liuhongtong):
 
{code:java}
[ERROR] TestWebHdfsTimeouts.testTwoStepWriteConnectTimeout:245 expected timeout 
[ERROR] TestWebHdfsTimeouts.testTwoStepWriteConnectTimeout:245 expected timeout 
[ERROR] Errors: [ERROR] 
TestDataNodeVolumeFailureReporting.testVolFailureStatsPreservedOnNNRestart:283 
? Timeout [INFO] [ERROR] Tests run: 5557, Failures: 10, Errors: 1, Skipped: 21
{code}
I'm innocent, and this unit test failure is irrelevant with the modified code.

 

 

 

> NameNode: Fix NullPointerException when getQuotaUsageInt() invoked
> --
>
> Key: HDFS-13530
> URL: https://issues.apache.org/jira/browse/HDFS-13530
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: federation, namenode
>Reporter: liuhongtong
>Priority: Major
> Attachments: HDFS-13530.001.patch
>
>
> If the directory is nonexistent, getQuotaUsage rpc call will run into 
> NullPointerException throwed by
> FSDirStatAndListingOp.getQuotaUsageInt() .
> I think FSDirStatAndListingOp.getQuotaUsageInt() should throw 
> FileNotFoundException when the directory is nonexistent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org