[jira] [Comment Edited] (HDFS-13534) libhdfs++: Fix GCC7 build
[
https://issues.apache.org/jira/browse/HDFS-13534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503465#comment-16503465
]
Owen O'Malley edited comment on HDFS-13534 at 6/6/18 3:38 PM:
--
To get it working with gcc 7 for ORC's copy, I had to make two changes:
{code:java}
*** lib/common/async_stream.h~ 2017-08-30 07:56:51.0 -0700
--- lib/common/async_stream.h 2018-06-05 22:02:35.0 -0700
***
*** 20,25
--- 20,26
#define LIB_COMMON_ASYNC_STREAM_H_
#include
+ #include
namespace hdfs {
{code}
{code:java}
*** lib/rpc/request.h~ 2017-08-30 07:56:51.0 -0700
--- lib/rpc/request.h 2018-06-05 22:33:59.0 -0700
***
*** 22,27
--- 22,28
#include "common/util.h"
#include "common/new_delete.h"
+ #include
#include
#include
{code}
Those don't seem to be in this patch.
was (Author: owen.omalley):
To get it working with gcc 7, I had to make two changes:
{code:java}
*** lib/common/async_stream.h~ 2017-08-30 07:56:51.0 -0700
--- lib/common/async_stream.h 2018-06-05 22:02:35.0 -0700
***
*** 20,25
--- 20,26
#define LIB_COMMON_ASYNC_STREAM_H_
#include
+ #include
namespace hdfs {
{code}
{code:java}
*** lib/rpc/request.h~ 2017-08-30 07:56:51.0 -0700
--- lib/rpc/request.h 2018-06-05 22:33:59.0 -0700
***
*** 22,27
--- 22,28
#include "common/util.h"
#include "common/new_delete.h"
+ #include
#include
#include
{code}
Those don't seem to be in this patch.
> libhdfs++: Fix GCC7 build
> -
>
> Key: HDFS-13534
> URL: https://issues.apache.org/jira/browse/HDFS-13534
> Project: Hadoop HDFS
> Issue Type: Task
>Reporter: James Clampffer
>Assignee: James Clampffer
>Priority: Major
> Attachments: HDFS-13534.000.patch, HDFS-13534.001.patch
>
>
> After merging HDFS-13403 [~pifta] noticed the build broke on some platforms.
> [~bibinchundatt] pointed out that prior to gcc 7 mutex, future, and regex
> implicitly included functional. Without that implicit include the compiler
> errors on the std::function in ioservice.h.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDFS-13534) libhdfs++: Fix GCC7 build
[
https://issues.apache.org/jira/browse/HDFS-13534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467504#comment-16467504
]
Anatoli Shein edited comment on HDFS-13534 at 5/8/18 4:01 PM:
--
[~James C], is the below line commented out on purpose?
{code:java}
npm install -g ember-cli{code}
Also, the following line is giving me an error "marked override, but does not
override":
{code:java}
ProducerResult Produce() override = 0;{code}
was (Author: anatoli.shein):
[~James C], is the below line commented out on purpose?
{code:java}
npm install -g ember-cli
{code}
> libhdfs++: Fix GCC7 build
> -
>
> Key: HDFS-13534
> URL: https://issues.apache.org/jira/browse/HDFS-13534
> Project: Hadoop HDFS
> Issue Type: Task
>Reporter: James Clampffer
>Assignee: James Clampffer
>Priority: Major
> Attachments: HDFS-13534.000.patch
>
>
> After merging HDFS-13403 [~pifta] noticed the build broke on some platforms.
> [~bibinchundatt] pointed out that prior to gcc 7 mutex, future, and regex
> implicitly included functional. Without that implicit include the compiler
> errors on the std::function in ioservice.h.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDFS-13534) libhdfs++: Fix GCC7 build
[
https://issues.apache.org/jira/browse/HDFS-13534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467504#comment-16467504
]
Anatoli Shein edited comment on HDFS-13534 at 5/8/18 2:52 PM:
--
[~James C], is the below line commented out on purpose?
{code:java}
npm install -g ember-cli
{code}
was (Author: anatoli.shein):
[~James C], is the below line commented out on purpose?
# npm install -g ember-cli
> libhdfs++: Fix GCC7 build
> -
>
> Key: HDFS-13534
> URL: https://issues.apache.org/jira/browse/HDFS-13534
> Project: Hadoop HDFS
> Issue Type: Task
>Reporter: James Clampffer
>Assignee: James Clampffer
>Priority: Major
> Attachments: HDFS-13534.000.patch
>
>
> After merging HDFS-13403 [~pifta] noticed the build broke on some platforms.
> [~bibinchundatt] pointed out that prior to gcc 7 mutex, future, and regex
> implicitly included functional. Without that implicit include the compiler
> errors on the std::function in ioservice.h.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
