[ 
https://issues.apache.org/jira/browse/HDFS-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030309#comment-17030309
 ] 

Xieming Li edited comment on HDFS-15111 at 2/5/20 2:37 AM:
-----------------------------------------------------------

[~ayushtkn]
 Thank you for your comment.

Again, there are 3 test failures:

[TestDelegationTokensWithHA.testObserverReadProxyProviderWithDT|https://builds.apache.org/job/PreCommit-HDFS-Build/28735/testReport/org.apache.hadoop.hdfs.server.namenode.ha/TestDelegationTokensWithHA/testObserverReadProxyProviderWithDT/]
 : This happens even on trunk and thus regarded irrelevant.

[org.apache.hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage.blockReport_02,
 
|https://builds.apache.org/job/PreCommit-HDFS-Build/28735/testReport/org.apache.hadoop.hdfs.server.datanode/TestNNHandlesBlockReportPerStorage/blockReport_02/]
 
[org.apache.hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport.blockReport_02:
 
|https://builds.apache.org/job/PreCommit-HDFS-Build/28735/testReport/org.apache.hadoop.hdfs.server.datanode/TestNNHandlesCombinedBlockReport/blockReport_02/]:
 These two errors were not reproducible on my local enviroment.

 

[~shv]

Thank your for your comment.
I think assertion might not be a good idea. As a namenode could be stopped from 
a starting state:

( NameNode#stop seems to be able to stop a namenode on any states )

 

 


was (Author: risyomei):
[~ayushtkn]
 Thank you for your comment.

Again, there are 3 test failures:

[TestDelegationTokensWithHA.testObserverReadProxyProviderWithDT|https://builds.apache.org/job/PreCommit-HDFS-Build/28735/testReport/org.apache.hadoop.hdfs.server.namenode.ha/TestDelegationTokensWithHA/testObserverReadProxyProviderWithDT/]
 : This happens even on trunk and thus regarded irrelevant.

[org.apache.hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage.blockReport_02,
 
|https://builds.apache.org/job/PreCommit-HDFS-Build/28735/testReport/org.apache.hadoop.hdfs.server.datanode/TestNNHandlesBlockReportPerStorage/blockReport_02/]
 
[org.apache.hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport.blockReport_02:
 
|https://builds.apache.org/job/PreCommit-HDFS-Build/28735/testReport/org.apache.hadoop.hdfs.server.datanode/TestNNHandlesCombinedBlockReport/blockReport_02/]:
 These two errors were not reproducible on my local enviroment.

 

[~shv]

Thank your for your comment.

I think assertion might not be a good idea. As a namenode could be stopped from 
a starting state:

 


  

> stopStandbyServices() should log which service state it is transitioning from.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-15111
>                 URL: https://issues.apache.org/jira/browse/HDFS-15111
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs, logging
>    Affects Versions: 2.10.0
>            Reporter: Konstantin Shvachko
>            Assignee: Xieming Li
>            Priority: Major
>              Labels: newbie++
>         Attachments: HDFS-15111.001.patch, HDFS-15111.002.patch, 
> HDFS-15111.003.patch
>
>
> Trying to transition Observer to Standby state. {{stopStandbyServices()}} 
> logs that it is "Stopping services started for standby state". It should be 
> "Stopping services started for observer state"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to