[jira] [Commented] (HDDS-1073) Fix FindBugs issues on OzoneBucketStub#createMultipartKey
[
https://issues.apache.org/jira/browse/HDDS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763495#comment-16763495
]
Hudson commented on HDDS-1073:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15915 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/15915/])
HDDS-1073. Fix FindBugs issues on OzoneBucketStub#createMultipartKey. (elek:
rev df7b7dadf94dbc196297c607ca87cbc87d72ee4c)
* (edit)
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/client/OzoneBucketStub.java
> Fix FindBugs issues on OzoneBucketStub#createMultipartKey
> -
>
> Key: HDDS-1073
> URL: https://issues.apache.org/jira/browse/HDDS-1073
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Xiaoyu Yao
>Assignee: Aravindan Vijayan
>Priority: Minor
> Attachments: HDDS-1073-2.patch, HDDS-1073.patch
>
>
> We should not use == or != for String equality.
> {code}
> if (multipartUploadID == null || multipartUploadID != uploadID) {
> throw new IOException("NO_SUCH_MULTIPART_UPLOAD_ERROR");
> } else {
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-1073) Fix FindBugs issues on OzoneBucketStub#createMultipartKey
[
https://issues.apache.org/jira/browse/HDDS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763357#comment-16763357
]
Hadoop QA commented on HDDS-1073:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
41s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 32m 21s{color}
| {color:red} hadoop-ozone in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m
35s{color} | {color:green} hadoop-hdds in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 51m 6s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdds.scm.pipeline.TestRatisPipelineProvider |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
|
| | hadoop.hdds.scm.pipeline.TestSCMRestart |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-1073 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12958014/HDDS-1073-2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle |
| uname | Linux dbf0d3f373dd 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HDDS-Build/ozone.sh |
| git revision | trunk / a140a89 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/2207/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/2207/testReport/ |
| Max. process+thread count | 1132 (vs. ulimit of 1) |
| modules | C: hadoop-ozone/s3gateway U: hadoop-ozone/s3gateway |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/2207/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Fix FindBugs issues on OzoneBucketStub#createMultipartKey
> -
>
> Key: HDDS-1073
> URL: https://issues.apache.org/jira/browse/HDDS-1073
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Xiaoyu Yao
>Assignee: Aravindan Vijayan
>Priority: Minor
> Attachments: HDDS-1073-2.patch, HDDS-1073.patch
>
>
> We should
[jira] [Commented] (HDDS-1073) Fix FindBugs issues on OzoneBucketStub#createMultipartKey
[
https://issues.apache.org/jira/browse/HDDS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763351#comment-16763351
]
Hadoop QA commented on HDDS-1073:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
45s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
55s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
10s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 39m 45s{color}
| {color:red} hadoop-ozone in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
23s{color} | {color:green} hadoop-hdds in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 62m 20s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
|
| | hadoop.hdds.scm.pipeline.TestSCMRestart |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| | hadoop.ozone.container.TestContainerReplication |
| | hadoop.hdds.scm.pipeline.TestRatisPipelineProvider |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-1073 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12958013/HDDS-1073.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle |
| uname | Linux 5b709e49b067 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct
5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HDDS-Build/ozone.sh |
| git revision | trunk / a140a89 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/2206/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/2206/testReport/ |
| Max. process+thread count | 1131 (vs. ulimit of 1) |
| modules | C: hadoop-ozone/s3gateway U: hadoop-ozone/s3gateway |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/2206/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Fix FindBugs issues on OzoneBucketStub#createMultipartKey
> -
>
> Key: HDDS-1073
> URL: https://issues.apache.org/jira/browse/HDDS-1073
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Xiaoyu Yao
>Assignee:
[jira] [Commented] (HDDS-1073) Fix FindBugs issues on OzoneBucketStub#createMultipartKey
[
https://issues.apache.org/jira/browse/HDDS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763338#comment-16763338
]
Bharat Viswanadham commented on HDDS-1073:
--
+1. Pending Jenkins.
> Fix FindBugs issues on OzoneBucketStub#createMultipartKey
> -
>
> Key: HDDS-1073
> URL: https://issues.apache.org/jira/browse/HDDS-1073
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Xiaoyu Yao
>Assignee: Aravindan Vijayan
>Priority: Minor
> Attachments: HDDS-1073-2.patch, HDDS-1073.patch
>
>
> We should not use == or != for String equality.
> {code}
> if (multipartUploadID == null || multipartUploadID != uploadID) {
> throw new IOException("NO_SUCH_MULTIPART_UPLOAD_ERROR");
> } else {
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-1073) Fix FindBugs issues on OzoneBucketStub#createMultipartKey
[
https://issues.apache.org/jira/browse/HDDS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763313#comment-16763313
]
Bharat Viswanadham commented on HDDS-1073:
--
Thank You [~avijayan] for fixing the issue.
One minor comment:
Remove unused import Line 30.
> Fix FindBugs issues on OzoneBucketStub#createMultipartKey
> -
>
> Key: HDDS-1073
> URL: https://issues.apache.org/jira/browse/HDDS-1073
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Xiaoyu Yao
>Assignee: Aravindan Vijayan
>Priority: Minor
> Attachments: HDDS-1073.patch
>
>
> We should not use == or != for String equality.
> {code}
> if (multipartUploadID == null || multipartUploadID != uploadID) {
> throw new IOException("NO_SUCH_MULTIPART_UPLOAD_ERROR");
> } else {
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
