[jira] [Commented] (HDDS-126) Fix findbugs warning in MetadataKeyFilters.java
[
https://issues.apache.org/jira/browse/HDDS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500521#comment-16500521
]
Akira Ajisaka commented on HDDS-126:
Thank you, [~xyao]!
> Fix findbugs warning in MetadataKeyFilters.java
> ---
>
> Key: HDDS-126
> URL: https://issues.apache.org/jira/browse/HDDS-126
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
>Priority: Major
> Labels: newbie, reviewed
> Fix For: 0.2.1
>
> Attachments: HDDS-126.01.patch, HDDS-126.02.patch
>
>
> {noformat}
> module:hadoop-hdds/common
>Found reliance on default encoding in
> org.apache.hadoop.utils.MetadataKeyFilters$KeyPrefixFilter.filterKey(byte[],
> byte[], byte[]):in
> org.apache.hadoop.utils.MetadataKeyFilters$KeyPrefixFilter.filterKey(byte[],
> byte[], byte[]): String.getBytes() At MetadataKeyFilters.java:[line 97]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-126) Fix findbugs warning in MetadataKeyFilters.java
[
https://issues.apache.org/jira/browse/HDDS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500445#comment-16500445
]
Hudson commented on HDDS-126:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14350 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14350/])
HDDS-126. Fix findbugs warning in MetadataKeyFilters.java. Contributed (xyao:
rev ab3885f2c8cfd63ff94e548c40db3b4ea52c12e8)
* (edit)
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/MetadataKeyFilters.java
> Fix findbugs warning in MetadataKeyFilters.java
> ---
>
> Key: HDDS-126
> URL: https://issues.apache.org/jira/browse/HDDS-126
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
>Priority: Major
> Labels: newbie, reviewed
> Fix For: 0.2.1
>
> Attachments: HDDS-126.01.patch, HDDS-126.02.patch
>
>
> {noformat}
> module:hadoop-hdds/common
>Found reliance on default encoding in
> org.apache.hadoop.utils.MetadataKeyFilters$KeyPrefixFilter.filterKey(byte[],
> byte[], byte[]):in
> org.apache.hadoop.utils.MetadataKeyFilters$KeyPrefixFilter.filterKey(byte[],
> byte[], byte[]): String.getBytes() At MetadataKeyFilters.java:[line 97]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-126) Fix findbugs warning in MetadataKeyFilters.java
[
https://issues.apache.org/jira/browse/HDDS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500157#comment-16500157
]
genericqa commented on HDDS-126:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 27m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 10s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
56s{color} | {color:red} hadoop-hdds/common in trunk has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 12s{color} | {color:orange} hadoop-hdds/common: The patch generated 1 new +
0 unchanged - 1 fixed = 1 total (was 1) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 49s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
6s{color} | {color:green} hadoop-hdds/common generated 0 new + 0 unchanged - 1
fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
57s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
26s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 59m 13s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-126 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12926358/HDDS-126.02.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 10fb8b2824e0 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 9efb4b7 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/235/artifact/out/branch-findbugs-hadoop-hdds_common-warnings.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDDS-Build/235/artifact/out/diff-checkstyle-hadoop-hdds_common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/235/testReport/
[jira] [Commented] (HDDS-126) Fix findbugs warning in MetadataKeyFilters.java
[
https://issues.apache.org/jira/browse/HDDS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500109#comment-16500109
]
Akira Ajisaka commented on HDDS-126:
Thanks [~xyao] for reviewing this. Updated.
> Fix findbugs warning in MetadataKeyFilters.java
> ---
>
> Key: HDDS-126
> URL: https://issues.apache.org/jira/browse/HDDS-126
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
>Priority: Major
> Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-126.01.patch, HDDS-126.02.patch
>
>
> {noformat}
> module:hadoop-hdds/common
>Found reliance on default encoding in
> org.apache.hadoop.utils.MetadataKeyFilters$KeyPrefixFilter.filterKey(byte[],
> byte[], byte[]):in
> org.apache.hadoop.utils.MetadataKeyFilters$KeyPrefixFilter.filterKey(byte[],
> byte[], byte[]): String.getBytes() At MetadataKeyFilters.java:[line 97]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-126) Fix findbugs warning in MetadataKeyFilters.java
[
https://issues.apache.org/jira/browse/HDDS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496803#comment-16496803
]
Xiaoyu Yao commented on HDDS-126:
-
Thanks [~ajisakaa] for reporting and posting the fix. The patch looks good to
me.
One NIT: we can use the following wrapper that has been used across ozone/hdfs
code base
DFSUtil.string2Bytes() to simplify that change.
> Fix findbugs warning in MetadataKeyFilters.java
> ---
>
> Key: HDDS-126
> URL: https://issues.apache.org/jira/browse/HDDS-126
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Akira Ajisaka
>Priority: Major
> Labels: newbie
> Attachments: HDDS-126.01.patch
>
>
> {noformat}
> module:hadoop-hdds/common
>Found reliance on default encoding in
> org.apache.hadoop.utils.MetadataKeyFilters$KeyPrefixFilter.filterKey(byte[],
> byte[], byte[]):in
> org.apache.hadoop.utils.MetadataKeyFilters$KeyPrefixFilter.filterKey(byte[],
> byte[], byte[]): String.getBytes() At MetadataKeyFilters.java:[line 97]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-126) Fix findbugs warning in MetadataKeyFilters.java
[
https://issues.apache.org/jira/browse/HDDS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496394#comment-16496394
]
genericqa commented on HDDS-126:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 56s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
3s{color} | {color:red} hadoop-hdds/common in trunk has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 12s{color} | {color:orange} hadoop-hdds/common: The patch generated 1 new +
0 unchanged - 1 fixed = 1 total (was 1) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 40s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
2s{color} | {color:green} hadoop-hdds/common generated 0 new + 0 unchanged - 1
fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
56s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
25s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 59m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-126 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12925890/HDDS-126.01.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 7c2037a1fdf9 3.13.0-141-generic #190-Ubuntu SMP Fri Jan 19
12:52:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / d1e2b80 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/218/artifact/out/branch-findbugs-hadoop-hdds_common-warnings.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDDS-Build/218/artifact/out/diff-checkstyle-hadoop-hdds_common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/218/testReport/
