[jira] [Commented] (HDDS-345) Upgrade RocksDB version from 5.8.0 to 5.14.2
[
https://issues.apache.org/jira/browse/HDDS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579379#comment-16579379
]
Hudson commented on HDDS-345:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14765 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14765/])
HDDS-345. Upgrade RocksDB version from 5.8.0 to 5.14.2. Contributed by (elek:
rev d1830d8b8e032becbf5580645266b67634cdb41f)
* (edit) hadoop-hdds/common/pom.xml
* (edit)
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/RocksDBStore.java
> Upgrade RocksDB version from 5.8.0 to 5.14.2
>
>
> Key: HDDS-345
> URL: https://issues.apache.org/jira/browse/HDDS-345
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode, Ozone Manager, SCM
>Affects Versions: 0.2.1
>Reporter: Nanda kumar
>Assignee: Nanda kumar
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-345.000.patch, HDDS-345.001.patch
>
>
> We have been using RocksDB version {{5.8.0}}, this can be upgraded to the
> latest {{5.14.2}} version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-345) Upgrade RocksDB version from 5.8.0 to 5.14.2
[
https://issues.apache.org/jira/browse/HDDS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578755#comment-16578755
]
genericqa commented on HDDS-345:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 18s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 51s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
54s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 59m 3s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 |
| JIRA Issue | HDDS-345 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12935406/HDDS-345.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient xml findbugs checkstyle |
| uname | Linux bd39a7dd4596 4.4.0-130-generic #156-Ubuntu SMP Thu Jun 14
08:53:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 11daa01 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/760/testReport/ |
| Max. process+thread count | 409 (vs. ulimit of 1) |
| modules | C: hadoop-hdds/common U: hadoop-hdds/common |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/760/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT
[jira] [Commented] (HDDS-345) Upgrade RocksDB version from 5.8.0 to 5.14.2
[
https://issues.apache.org/jira/browse/HDDS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578663#comment-16578663
]
Anu Engineer commented on HDDS-345:
---
+1, please feel free to commit at will. We already have test passes with this
version of RocksDB.
> Upgrade RocksDB version from 5.8.0 to 5.14.2
>
>
> Key: HDDS-345
> URL: https://issues.apache.org/jira/browse/HDDS-345
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode, Ozone Manager, SCM
>Affects Versions: 0.2.1
>Reporter: Nanda kumar
>Assignee: Nanda kumar
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-345.000.patch, HDDS-345.001.patch
>
>
> We have been using RocksDB version {{5.8.0}}, this can be upgraded to the
> latest {{5.14.2}} version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-345) Upgrade RocksDB version from 5.8.0 to 5.14.2
[
https://issues.apache.org/jira/browse/HDDS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578651#comment-16578651
]
Nanda kumar commented on HDDS-345:
--
Thanks [~elek] for the review, addressed the review comment in patch v001.
> Upgrade RocksDB version from 5.8.0 to 5.14.2
>
>
> Key: HDDS-345
> URL: https://issues.apache.org/jira/browse/HDDS-345
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode, Ozone Manager, SCM
>Affects Versions: 0.2.1
>Reporter: Nanda kumar
>Assignee: Nanda kumar
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-345.000.patch, HDDS-345.001.patch
>
>
> We have been using RocksDB version {{5.8.0}}, this can be upgraded to the
> latest {{5.14.2}} version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-345) Upgrade RocksDB version from 5.8.0 to 5.14.2
[
https://issues.apache.org/jira/browse/HDDS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575857#comment-16575857
]
Elek, Marton commented on HDDS-345:
---
Thank you [~nandakumar131] the patch. I created a new build and run a full
acceptance test and everything worked well.
It looks good to me overall, one minor thing:
Could you please change the RocksDbStore.java L250 to use delete instead of
remove? (They do the same but remove is deprecated...).
> Upgrade RocksDB version from 5.8.0 to 5.14.2
>
>
> Key: HDDS-345
> URL: https://issues.apache.org/jira/browse/HDDS-345
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode, Ozone Manager, SCM
>Affects Versions: 0.2.1
>Reporter: Nanda kumar
>Assignee: Nanda kumar
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-345.000.patch
>
>
> We have been using RocksDB version {{5.8.0}}, this can be upgraded to the
> latest {{5.14.2}} version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-345) Upgrade RocksDB version from 5.8.0 to 5.14.2
[
https://issues.apache.org/jira/browse/HDDS-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575806#comment-16575806
]
genericqa commented on HDDS-345:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
40m 29s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 26s{color}
| {color:red} hadoop-hdds_common generated 1 new + 0 unchanged - 0 fixed = 1
total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 22s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
54s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 58m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 |
| JIRA Issue | HDDS-345 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12935075/HDDS-345.000.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient xml |
| uname | Linux 0698c500bb29 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 08d5060 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| javac |
https://builds.apache.org/job/PreCommit-HDDS-Build/747/artifact/out/diff-compile-javac-hadoop-hdds_common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/747/testReport/ |
| Max. process+thread count | 301 (vs. ulimit of 1) |
| modules | C: hadoop-hdds/common U: hadoop-hdds/common |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/747/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Upgrade RocksDB version from 5.8.0 to 5.14.2
>
>
> Key: HDDS-345
> URL: https://issues.apache.org/jira/browse/HDDS-345
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode, Ozone Manager, SCM
>
