[jira] [Commented] (HDDS-425) Move unit test of the genconf tool to hadoop-ozone/tools module
[ https://issues.apache.org/jira/browse/HDDS-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612158#comment-16612158 ] Dinesh Chitlangia commented on HDDS-425: [~elek] - Thank you for review and commit. > Move unit test of the genconf tool to hadoop-ozone/tools module > --- > > Key: HDDS-425 > URL: https://issues.apache.org/jira/browse/HDDS-425 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: Tools >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Fix For: 0.2.1, 0.3.0 > > Attachments: HDDS-425.001.patch > > > Based on review comment from [~elek] in HDDS-417, this Jira proposes to move > unit test of genconf tool to hadoop-ozone/tools module. It doesn't require > miniozone cluster so it shouldn't be in the integration test module. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-425) Move unit test of the genconf tool to hadoop-ozone/tools module
[ https://issues.apache.org/jira/browse/HDDS-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611884#comment-16611884 ] Hudson commented on HDDS-425: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14930 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14930/]) HDDS-425. Move unit test of the genconf tool to hadoop-ozone/tools (elek: rev 901156716990fa00b44515dafcb9916c20556a0e) * (delete) hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/genconf/TestGenerateOzoneRequiredConfigurations.java * (add) hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/genconf/TestGenerateOzoneRequiredConfigurations.java * (add) hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/genconf/package-info.java > Move unit test of the genconf tool to hadoop-ozone/tools module > --- > > Key: HDDS-425 > URL: https://issues.apache.org/jira/browse/HDDS-425 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: Tools >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Fix For: 0.2.1, 0.3.0 > > Attachments: HDDS-425.001.patch > > > Based on review comment from [~elek] in HDDS-417, this Jira proposes to move > unit test of genconf tool to hadoop-ozone/tools module. It doesn't require > miniozone cluster so it shouldn't be in the integration test module. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-425) Move unit test of the genconf tool to hadoop-ozone/tools module
[ https://issues.apache.org/jira/browse/HDDS-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611780#comment-16611780 ] Elek, Marton commented on HDDS-425: --- +1. Thanks to do this. I like to have more local unit tests instead of slower integration/miniozone tests. Will commit it to trunk/ozone-0.2 shortly... > Move unit test of the genconf tool to hadoop-ozone/tools module > --- > > Key: HDDS-425 > URL: https://issues.apache.org/jira/browse/HDDS-425 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: Tools >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Fix For: 0.3.0 > > Attachments: HDDS-425.001.patch > > > Based on review comment from [~elek] in HDDS-417, this Jira proposes to move > unit test of genconf tool to hadoop-ozone/tools module. It doesn't require > miniozone cluster so it shouldn't be in the integration test module. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-425) Move unit test of the genconf tool to hadoop-ozone/tools module
[ https://issues.apache.org/jira/browse/HDDS-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609856#comment-16609856 ] Dinesh Chitlangia commented on HDDS-425: Test Failure not related to patch. License failure is due to the heap dump file generated by test failure. > Move unit test of the genconf tool to hadoop-ozone/tools module > --- > > Key: HDDS-425 > URL: https://issues.apache.org/jira/browse/HDDS-425 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: Tools >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Fix For: 0.3.0 > > Attachments: HDDS-425.001.patch > > > Based on review comment from [~elek] in HDDS-417, this Jira proposes to move > unit test of genconf tool to hadoop-ozone/tools module. It doesn't require > miniozone cluster so it shouldn't be in the integration test module. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-425) Move unit test of the genconf tool to hadoop-ozone/tools module
[
https://issues.apache.org/jira/browse/HDDS-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609765#comment-16609765
]
Hadoop QA commented on HDDS-425:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
41s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 28s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 20s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} tools in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 30s{color}
| {color:red} integration-test in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
33s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 67m 49s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ozone.freon.TestDataValidate |
| | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 |
| JIRA Issue | HDDS-425 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12939140/HDDS-425.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux d8cb6361ec23
