[jira] [Commented] (HDDS-77) Key replication factor and type should be stored per key by Ozone Manager
[ https://issues.apache.org/jira/browse/HDDS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479256#comment-16479256 ] Hudson commented on HDDS-77: SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14217 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14217/]) HDDS-77. Key replication factor and type should be stored per key by (xyao: rev 41ae5c50024e3682b61df6f391d0fe63591ac92b) * (edit) hadoop-ozone/common/src/main/proto/KeySpaceManagerProtocol.proto * (edit) hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/KeySpaceManagerProtocolServerSideTranslatorPB.java * (edit) hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/ksm/KeyManagerImpl.java * (edit) hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/ksm/protocolPB/KeySpaceManagerProtocolClientSideTranslatorPB.java * (edit) hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/ksm/helpers/KsmKeyInfo.java > Key replication factor and type should be stored per key by Ozone Manager > - > > Key: HDDS-77 > URL: https://issues.apache.org/jira/browse/HDDS-77 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Manager >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Labels: reviewed > Fix For: 0.2.1 > > Attachments: HDDS-77.001.patch > > > Currently for a key, a client requests for multiple blocks through allocate > block calls. However it is possible for the allocate block call to have a > different replication type and factor than the blocks allocated during create > key. > This jira proposes to store the replication factor and type values inside the > OzoneManager and re-use the values for the subsequent block allocation calls. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-77) Key replication factor and type should be stored per key by Ozone Manager
[ https://issues.apache.org/jira/browse/HDDS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479208#comment-16479208 ] Xiaoyu Yao commented on HDDS-77: Thanks [~msingh] for working on this. The patch looks good to me. +1, I will commit it shortly. > Key replication factor and type should be stored per key by Ozone Manager > - > > Key: HDDS-77 > URL: https://issues.apache.org/jira/browse/HDDS-77 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Manager >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: HDDS-77.001.patch > > > Currently for a key, a client requests for multiple blocks through allocate > block calls. However it is possible for the allocate block call to have a > different replication type and factor than the blocks allocated during create > key. > This jira proposes to store the replication factor and type values inside the > OzoneManager and re-use the values for the subsequent block allocation calls. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-77) Key replication factor and type should be stored per key by Ozone Manager
[ https://issues.apache.org/jira/browse/HDDS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479012#comment-16479012 ] Nanda kumar commented on HDDS-77: - Thanks [~msingh] for reporting and working on this. +1 (non-binding), the patch looks good to me. > Key replication factor and type should be stored per key by Ozone Manager > - > > Key: HDDS-77 > URL: https://issues.apache.org/jira/browse/HDDS-77 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Manager >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: HDDS-77.001.patch > > > Currently for a key, a client requests for multiple blocks through allocate > block calls. However it is possible for the allocate block call to have a > different replication type and factor than the blocks allocated during create > key. > This jira proposes to store the replication factor and type values inside the > OzoneManager and re-use the values for the subsequent block allocation calls. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-77) Key replication factor and type should be stored per key by Ozone Manager
[
https://issues.apache.org/jira/browse/HDDS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477460#comment-16477460
]
genericqa commented on HDDS-77:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 37s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
38s{color} | {color:red} hadoop-ozone/ozone-manager in trunk has 1 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 41s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
31s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} ozone-manager in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 63m 0s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-77 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12923680/HDDS-77.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle cc |
| uname | Linux 9035f1e47d08 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk /
