[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688541#comment-16688541 ] Hanisha Koneru commented on HDDS-819: - Thanks [~arpitagarwal] for reviewing and committing the patch. > Match OzoneFileSystem behavior with S3AFileSystem > - > > Key: HDDS-819 > URL: https://issues.apache.org/jira/browse/HDDS-819 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Filesystem >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.4.0 > > Attachments: HDDS-819.001.patch, HDDS-819.002.patch, > HDDS-819.003.patch > > > To match the behavior of o3fs with that of the S3AFileSystem, following > changes need to be made to OzoneFileSystem. > # When creating files, we should add only 1 key. Keys corresponding to the > parent directories should not be created. > # {{GetFileStatus}} should return the status for fake directories > (directories which do not actually exist as a key but there exists a key > which is a child of this directory). For example, if there exists a key > _/dir1/dir2/file2_, {{GetFileStatus("/dir1/")}} should return _/dir1/_ as a > directory. > # {{ListStatus}} on a directory should list fake sub-directories also along > with files. > # {\{ListStatus}} on a directory should also files and sub-directories with > the same name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687320#comment-16687320 ] Hudson commented on HDDS-819: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15428 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/15428/]) HDDS-819. Match OzoneFileSystem behavior with S3AFileSystem. Contributed (arp: rev bac8807c8b7abb4864aed921585f6e6fc5e9cd5c) * (edit) hadoop-ozone/ozonefs/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java * (edit) hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OzoneFileSystem.java > Match OzoneFileSystem behavior with S3AFileSystem > - > > Key: HDDS-819 > URL: https://issues.apache.org/jira/browse/HDDS-819 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Filesystem >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Fix For: 0.4.0 > > Attachments: HDDS-819.001.patch, HDDS-819.002.patch, > HDDS-819.003.patch > > > To match the behavior of o3fs with that of the S3AFileSystem, following > changes need to be made to OzoneFileSystem. > # When creating files, we should add only 1 key. Keys corresponding to the > parent directories should not be created. > # {{GetFileStatus}} should return the status for fake directories > (directories which do not actually exist as a key but there exists a key > which is a child of this directory). For example, if there exists a key > _/dir1/dir2/file2_, {{GetFileStatus("/dir1/")}} should return _/dir1/_ as a > directory. > # {{ListStatus}} on a directory should list fake sub-directories also along > with files. > # {\{ListStatus}} on a directory should also files and sub-directories with > the same name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687096#comment-16687096 ] Arpit Agarwal commented on HDDS-819: +1 for the v3 patch. Can you run the contract tests if you haven't done so already? > Match OzoneFileSystem behavior with S3AFileSystem > - > > Key: HDDS-819 > URL: https://issues.apache.org/jira/browse/HDDS-819 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Attachments: HDDS-819.001.patch, HDDS-819.002.patch, > HDDS-819.003.patch > > > To match the behavior of o3fs with that of the S3AFileSystem, following > changes need to be made to OzoneFileSystem. > # When creating files, we should add only 1 key. Keys corresponding to the > parent directories should not be created. > # {{GetFileStatus}} should return the status for fake directories > (directories which do not actually exist as a key but there exists a key > which is a child of this directory). For example, if there exists a key > _/dir1/dir2/file2_, {{GetFileStatus("/dir1/")}} should return _/dir1/_ as a > directory. > # {{ListStatus}} on a directory should list fake sub-directories also along > with files. > # {\{ListStatus}} on a directory should also files and sub-directories with > the same name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684562#comment-16684562 ] Hadoop QA commented on HDDS-819: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m 36s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 0s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 35s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 44s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 59s{color} | {color:green} ozonefs in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 27s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 58m 58s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f | | JIRA Issue | HDDS-819 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12947917/HDDS-819.003.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux a18e0a924b36 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / b6d4e19 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/PreCommit-HDDS-Build/1692/testReport/ | | Max. process+thread count | 2628 (vs. ulimit of 1) | | modules | C: hadoop-ozone/ozonefs U: hadoop-ozone/ozonefs | | Console output | https://builds.apache.org/job/PreCommit-HDDS-Build/1692/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Match OzoneFileSystem behavior with S3AFileSystem > - > > Key: HDDS-819 > URL: https://issues.apache.org/jira/browse/HDDS-819 >
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684478#comment-16684478 ] Hanisha Koneru commented on HDDS-819: - Thank you [~arpitagarwal] for the review. I have updated the patch to replace ListStatusIterator#subDirPaths and added javadocs for the new functions. > Match OzoneFileSystem behavior with S3AFileSystem > - > > Key: HDDS-819 > URL: https://issues.apache.org/jira/browse/HDDS-819 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Attachments: HDDS-819.001.patch, HDDS-819.002.patch, > HDDS-819.003.patch > > > To match the behavior of o3fs with that of the S3AFileSystem, following > changes need to be made to OzoneFileSystem. > # When creating files, we should add only 1 key. Keys corresponding to the > parent directories should not be created. > # {{GetFileStatus}} should return the status for fake directories > (directories which do not actually exist as a key but there exists a key > which is a child of this directory). For example, if there exists a key > _/dir1/dir2/file2_, {{GetFileStatus("/dir1/")}} should return _/dir1/_ as a > directory. > # {{ListStatus}} on a directory should list fake sub-directories also along > with files. > # {\{ListStatus}} on a directory should also files and sub-directories with > the same name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684326#comment-16684326 ] Arpit Agarwal commented on HDDS-819: Thanks for taking care of this [~hanishakoneru] and the background work on comparing the o3fs behavior with S3A. The changes look good to me. Let's replace ListStatusIterator#subDirPaths with a map for performance. I haven't reviewed the tests yet. > Match OzoneFileSystem behavior with S3AFileSystem > - > > Key: HDDS-819 > URL: https://issues.apache.org/jira/browse/HDDS-819 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Attachments: HDDS-819.001.patch, HDDS-819.002.patch > > > To match the behavior of o3fs with that of the S3AFileSystem, following > changes need to be made to OzoneFileSystem. > # When creating files, we should add only 1 key. Keys corresponding to the > parent directories should not be created. > # {{GetFileStatus}} should return the status for fake directories > (directories which do not actually exist as a key but there exists a key > which is a child of this directory). For example, if there exists a key > _/dir1/dir2/file2_, {{GetFileStatus("/dir1/")}} should return _/dir1/_ as a > directory. > # {{ListStatus}} on a directory should list fake sub-directories also along > with files. > # {\{ListStatus}} on a directory should also files and sub-directories with > the same name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682068#comment-16682068 ] Hadoop QA commented on HDDS-819: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 22s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m 40s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 38s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 21s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 49s{color} | {color:red} ozonefs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 27s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 63m 3s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.fs.ozone.contract.ITestOzoneContractMkdir | | | hadoop.fs.ozone.contract.ITestOzoneContractDelete | | | hadoop.fs.ozone.contract.ITestOzoneContractGetFileStatus | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f | | JIRA Issue | HDDS-819 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12947641/HDDS-819.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux abf5a261f780 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 9fe50b4 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDDS-Build/1665/artifact/out/patch-unit-hadoop-ozone_ozonefs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDDS-Build/1665/testReport/ | | Max. process+thread count | 3126 (vs. ulimit of 1) | | modules | C: hadoop-ozone/ozonefs U: hadoop-ozone/ozonefs | | Console output | https://builds.apache.org/job/PreCommit-HDDS-Build/1665/console | |
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682008#comment-16682008 ] Hanisha Koneru commented on HDDS-819: - Thanks for the offline discussion [~arpitagarwal]. I updated the patch such that listStatus would also return files and sub-dirs with the same name. Also fixed checkstyle and findbug errors. > Match OzoneFileSystem behavior with S3AFileSystem > - > > Key: HDDS-819 > URL: https://issues.apache.org/jira/browse/HDDS-819 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Attachments: HDDS-819.001.patch, HDDS-819.002.patch > > > To match the behavior of o3fs with that of the S3AFileSystem, following > changes need to be made to OzoneFileSystem. > # When creating files, we should add only 1 key. Keys corresponding to the > parent directories should not be created. > # {{GetFileStatus}} should return the status for fake directories > (directories which do not actually exist as a key but there exists a key > which is a child of this directory). For example, if there exists a key > _/dir1/dir2/file2_, {{GetFileStatus("/dir1/")}} should return _/dir1/_ as a > directory. > # {{ListStatus}} on a directory should list fake sub-directories also along > with files. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679334#comment-16679334 ] Mukul Kumar Singh commented on HDDS-819: Thanks for working on this [~hanishakoneru], The Contract tests are failing with this patch. > Match OzoneFileSystem behavior with S3AFileSystem > - > > Key: HDDS-819 > URL: https://issues.apache.org/jira/browse/HDDS-819 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Attachments: HDDS-819.001.patch > > > To match the behavior of o3fs with that of the S3AFileSystem, following > changes need to be made to OzoneFileSystem. > 1. When creating files, we should add only 1 key. Keys corresponding to the > parent directories should not be created. > 2. {{GetFileStatus}} should return the status for fake directories > (directories which do not actually exist as a key but there exists a key > which is a child of this directory). For example, if there exists a key > _/dir1/dir2/file2_, {{GetFileStatus("/dir1/")}} should return _/dir1/_ as a > directory. > 3. {{ListStatus}} on a directory should list fake sub-directories. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679141#comment-16679141 ] Hadoop QA commented on HDDS-819: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 27s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 35s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 32s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 12s{color} | {color:orange} hadoop-ozone/ozonefs: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 20s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 39s{color} | {color:red} hadoop-ozone/ozonefs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 24s{color} | {color:red} ozonefs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 29s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 62m 26s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-ozone/ozonefs | | | Dead store to key in org.apache.hadoop.fs.ozone.OzoneFileSystem.o3Exists(Path) At OzoneFileSystem.java:org.apache.hadoop.fs.ozone.OzoneFileSystem.o3Exists(Path) At OzoneFileSystem.java:[line 446] | | Failed junit tests | hadoop.fs.ozone.contract.ITestOzoneContractMkdir | | | hadoop.fs.ozone.contract.ITestOzoneContractDistCp | | | hadoop.fs.ozone.contract.ITestOzoneContractSeek | | | hadoop.fs.ozone.contract.ITestOzoneContractGetFileStatus | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f | | JIRA Issue | HDDS-819 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12947305/HDDS-819.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 02deb5bb27d1 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / c96cbe8 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | |
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680330#comment-16680330 ] Hadoop QA commented on HDDS-819: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m 43s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 20s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 30s{color} | {color:green} trunk passed {color} | | {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 11m 9s{color} | {color:red} branch has errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 11s{color} | {color:orange} hadoop-ozone/ozonefs: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 11m 0s{color} | {color:red} patch has errors when building and testing our client artifacts. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 35s{color} | {color:red} hadoop-ozone/ozonefs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 22s{color} | {color:red} ozonefs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 49m 8s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-ozone/ozonefs | | | Dead store to key in org.apache.hadoop.fs.ozone.OzoneFileSystem.o3Exists(Path) At OzoneFileSystem.java:org.apache.hadoop.fs.ozone.OzoneFileSystem.o3Exists(Path) At OzoneFileSystem.java:[line 446] | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f | | JIRA Issue | HDDS-819 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12947305/HDDS-819.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 1a8a8dc4be7c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 31614bc | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-HDDS-Build/1645/artifact/out/diff-checkstyle-hadoop-ozone_ozonefs.txt | | findbugs | https://builds.apache.org/job/PreCommit-HDDS-Build/1645/artifact/out/new-findbugs-hadoop-ozone_ozonefs.html |
[jira] [Commented] (HDDS-819) Match OzoneFileSystem behavior with S3AFileSystem
[ https://issues.apache.org/jira/browse/HDDS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680221#comment-16680221 ] Hanisha Koneru commented on HDDS-819: - Contract tests are passing for me locally. I have re-triggered a Jenkins run. > Match OzoneFileSystem behavior with S3AFileSystem > - > > Key: HDDS-819 > URL: https://issues.apache.org/jira/browse/HDDS-819 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Hanisha Koneru >Assignee: Hanisha Koneru >Priority: Major > Attachments: HDDS-819.001.patch > > > To match the behavior of o3fs with that of the S3AFileSystem, following > changes need to be made to OzoneFileSystem. > 1. When creating files, we should add only 1 key. Keys corresponding to the > parent directories should not be created. > 2. {{GetFileStatus}} should return the status for fake directories > (directories which do not actually exist as a key but there exists a key > which is a child of this directory). For example, if there exists a key > _/dir1/dir2/file2_, {{GetFileStatus("/dir1/")}} should return _/dir1/_ as a > directory. > 3. {{ListStatus}} on a directory should list fake sub-directories. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org