[jira] [Commented] (HDDS-971) ContainerDataConstructor throws exception on QUASI_CLOSED and UNHEALTHY container state
[
https://issues.apache.org/jira/browse/HDDS-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745249#comment-16745249
]
Lokesh Jain commented on HDDS-971:
--
[~bharatviswa] Thanks for reviewing and committing the patch! I will create a
new Jira for fixing TestContainerDataYaml.
> ContainerDataConstructor throws exception on QUASI_CLOSED and UNHEALTHY
> container state
> ---
>
> Key: HDDS-971
> URL: https://issues.apache.org/jira/browse/HDDS-971
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-971.001.patch
>
>
> We need to define QUASI_CLOSED and UNHEALTHY state in
> ContainerDataConstructor class logic. Currently the code uses switch-case for
> determining the state. The logic can be replaced with
> {code:java}
> ContainerProtos.ContainerDataProto.State.valueOf(state)
> {code}
> call. The Jira also fixes test failure TestKeys#testPutAndGetKeyWithDnRestart.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-971) ContainerDataConstructor throws exception on QUASI_CLOSED and UNHEALTHY container state
[
https://issues.apache.org/jira/browse/HDDS-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744600#comment-16744600
]
Bharat Viswanadham commented on HDDS-971:
-
Hi [~ljain]
I have missed that test failure is related to the patch.
There is one test failure related to this, TestContainerDataYaml, could you
have a look into this.
I have committed this, we can open a new Jira to fix this test case.
> ContainerDataConstructor throws exception on QUASI_CLOSED and UNHEALTHY
> container state
> ---
>
> Key: HDDS-971
> URL: https://issues.apache.org/jira/browse/HDDS-971
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-971.001.patch
>
>
> We need to define QUASI_CLOSED and UNHEALTHY state in
> ContainerDataConstructor class logic. Currently the code uses switch-case for
> determining the state. The logic can be replaced with
> {code:java}
> ContainerProtos.ContainerDataProto.State.valueOf(state)
> {code}
> call. The Jira also fixes test failure TestKeys#testPutAndGetKeyWithDnRestart.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-971) ContainerDataConstructor throws exception on QUASI_CLOSED and UNHEALTHY container state
[
https://issues.apache.org/jira/browse/HDDS-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744602#comment-16744602
]
Hudson commented on HDDS-971:
-
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #15783 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/15783/])
HDDS-971. ContainerDataConstructor throws exception on QUASI_CLOSED and
(bharat: rev 96ea464aaadeadc1ef149dab93813bcfd94fa21a)
* (edit)
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerDataYaml.java
* (edit)
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerReader.java
> ContainerDataConstructor throws exception on QUASI_CLOSED and UNHEALTHY
> container state
> ---
>
> Key: HDDS-971
> URL: https://issues.apache.org/jira/browse/HDDS-971
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-971.001.patch
>
>
> We need to define QUASI_CLOSED and UNHEALTHY state in
> ContainerDataConstructor class logic. Currently the code uses switch-case for
> determining the state. The logic can be replaced with
> {code:java}
> ContainerProtos.ContainerDataProto.State.valueOf(state)
> {code}
> call. The Jira also fixes test failure TestKeys#testPutAndGetKeyWithDnRestart.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-971) ContainerDataConstructor throws exception on QUASI_CLOSED and UNHEALTHY container state
[
https://issues.apache.org/jira/browse/HDDS-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744597#comment-16744597
]
Bharat Viswanadham commented on HDDS-971:
-
+1 LGTM.
I will commit this shortly.
> ContainerDataConstructor throws exception on QUASI_CLOSED and UNHEALTHY
> container state
> ---
>
> Key: HDDS-971
> URL: https://issues.apache.org/jira/browse/HDDS-971
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
> Attachments: HDDS-971.001.patch
>
>
> We need to define QUASI_CLOSED and UNHEALTHY state in
> ContainerDataConstructor class logic. Currently the code uses switch-case for
> determining the state. The logic can be replaced with
> {code:java}
> ContainerProtos.ContainerDataProto.State.valueOf(state)
> {code}
> call. The Jira also fixes test failure TestKeys#testPutAndGetKeyWithDnRestart.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-971) ContainerDataConstructor throws exception on QUASI_CLOSED and UNHEALTHY container state
[
https://issues.apache.org/jira/browse/HDDS-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739304#comment-16739304
]
Hadoop QA commented on HDDS-971:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
28s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 30m 48s{color}
| {color:red} hadoop-ozone in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 12s{color}
| {color:red} hadoop-hdds in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 25s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ozone.client.rpc.TestFailureHandlingByClient |
| | hadoop.ozone.container.common.impl.TestContainerDataYaml |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-971 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12954408/HDDS-971.001.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle |
| uname | Linux 3034ee4a30f9 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct
5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HDDS-Build/ozone.sh |
| git revision | trunk / 2091d1a |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/2034/artifact/out/patch-unit-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/2034/artifact/out/patch-unit-hadoop-hdds.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/2034/testReport/ |
| Max. process+thread count | 1069 (vs. ulimit of 1) |
| modules | C: hadoop-hdds/container-service U: hadoop-hdds/container-service |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/2034/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> ContainerDataConstructor throws exception on QUASI_CLOSED and UNHEALTHY
> container state
> ---
>
> Key: HDDS-971
> URL: https://issues.apache.org/jira/browse/HDDS-971
> Project:
