[jira] [Commented] (HDFS-10733) NameNode terminated after full GC thinking QJM is unresponsive.
[ https://issues.apache.org/jira/browse/HDFS-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133590#comment-16133590 ] Erik Krogen commented on HDFS-10733: [~yangjiandan], you are absolutely right. I have filed HDFS-12323 for this bug. > NameNode terminated after full GC thinking QJM is unresponsive. > --- > > Key: HDFS-10733 > URL: https://issues.apache.org/jira/browse/HDFS-10733 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, qjm >Affects Versions: 2.6.4 >Reporter: Konstantin Shvachko >Assignee: Vinitha Reddy Gankidi > Fix For: 2.8.0, 2.9.0, 2.7.4, 3.0.0-alpha2 > > Attachments: HDFS-10733.001.patch, HDFS-10733.002.patch > > > NameNode went into full GC while in {{AsyncLoggerSet.waitForWriteQuorum()}}. > After completing GC it checks if the timeout for quorum is reached. If the GC > was long enough the timeout can expire, and {{QuorumCall.waitFor()}} will > throw {{TimeoutExcpetion}}. Finally {{FSEditLog.logSync()}} catches the > exception and terminates NameNode. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10733) NameNode terminated after full GC thinking QJM is unresponsive.
[ https://issues.apache.org/jira/browse/HDFS-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091150#comment-16091150 ] Jiandan Yang commented on HDFS-10733: -- [~redvine] I would like to ask you a question for the following code. When the fullgc time has far exceeded the value of 'millis', (et + millis) will be negative and then a TimeoutException will be thrown. How about et=now+millis? {code:java} if (shouldIncreaseQuorumTimeout(-rem, millis)) { et = et + millis; } {code} > NameNode terminated after full GC thinking QJM is unresponsive. > --- > > Key: HDFS-10733 > URL: https://issues.apache.org/jira/browse/HDFS-10733 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, qjm >Affects Versions: 2.6.4 >Reporter: Konstantin Shvachko >Assignee: Vinitha Reddy Gankidi > Fix For: 2.8.0, 2.9.0, 2.7.4, 3.0.0-alpha2 > > Attachments: HDFS-10733.001.patch, HDFS-10733.002.patch > > > NameNode went into full GC while in {{AsyncLoggerSet.waitForWriteQuorum()}}. > After completing GC it checks if the timeout for quorum is reached. If the GC > was long enough the timeout can expire, and {{QuorumCall.waitFor()}} will > throw {{TimeoutExcpetion}}. Finally {{FSEditLog.logSync()}} catches the > exception and terminates NameNode. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10733) NameNode terminated after full GC thinking QJM is unresponsive.
[ https://issues.apache.org/jira/browse/HDFS-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828811#comment-15828811 ] Hudson commented on HDFS-10733: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11135 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11135/]) HDFS-10733. NameNode terminated after full GC thinking QJM is (shv: rev 8a0fa0f7e88c45a98c6f266d6349cb426dd06495) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumCall.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumCall.java > NameNode terminated after full GC thinking QJM is unresponsive. > --- > > Key: HDFS-10733 > URL: https://issues.apache.org/jira/browse/HDFS-10733 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, qjm >Affects Versions: 2.6.4 >Reporter: Konstantin Shvachko >Assignee: Vinitha Reddy Gankidi > Fix For: 2.8.0, 2.9.0, 2.7.4, 3.0.0-alpha2 > > Attachments: HDFS-10733.001.patch, HDFS-10733.002.patch > > > NameNode went into full GC while in {{AsyncLoggerSet.waitForWriteQuorum()}}. > After completing GC it checks if the timeout for quorum is reached. If the GC > was long enough the timeout can expire, and {{QuorumCall.waitFor()}} will > throw {{TimeoutExcpetion}}. Finally {{FSEditLog.logSync()}} catches the > exception and terminates NameNode. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10733) NameNode terminated after full GC thinking QJM is unresponsive.
[ https://issues.apache.org/jira/browse/HDFS-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819253#comment-15819253 ] Konstantin Shvachko commented on HDFS-10733: +1 on the latest patch. Failed tests passed locally for me. Will commit in a bit. > NameNode terminated after full GC thinking QJM is unresponsive. > --- > > Key: HDFS-10733 > URL: https://issues.apache.org/jira/browse/HDFS-10733 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, qjm >Affects Versions: 2.6.4 >Reporter: Konstantin Shvachko >Assignee: Vinitha Reddy Gankidi > Attachments: HDFS-10733.001.patch, HDFS-10733.002.patch > > > NameNode went into full GC while in {{AsyncLoggerSet.waitForWriteQuorum()}}. > After completing GC it checks if the timeout for quorum is reached. If the GC > was long enough the timeout can expire, and {{QuorumCall.waitFor()}} will > throw {{TimeoutExcpetion}}. Finally {{FSEditLog.logSync()}} catches the > exception and terminates NameNode. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10733) NameNode terminated after full GC thinking QJM is unresponsive.
[ https://issues.apache.org/jira/browse/HDFS-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817204#comment-15817204 ] Hadoop QA commented on HDFS-10733: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 50s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 57s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 54s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 83m 9s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 34s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}110m 9s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean | | | org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:a9ad5d6 | | JIRA Issue | HDFS-10733 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12846719/HDFS-10733.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 9e39f19c6ee1 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 4db119b | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/18142/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/18142/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/18142/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > NameNode terminated after full GC thinking QJM is unresponsive. > --- > > Key: HDFS-10733 > URL: https://issues.apache.org/jira/browse/HDFS-10733 > Project: Hadoop HDFS > Issue Type: Bug >
[jira] [Commented] (HDFS-10733) NameNode terminated after full GC thinking QJM is unresponsive.
[ https://issues.apache.org/jira/browse/HDFS-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816705#comment-15816705 ] Vinitha Reddy Gankidi commented on HDFS-10733: -- [~shv] I agree. Attached a new patch with this change. > NameNode terminated after full GC thinking QJM is unresponsive. > --- > > Key: HDFS-10733 > URL: https://issues.apache.org/jira/browse/HDFS-10733 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, qjm >Affects Versions: 2.6.4 >Reporter: Konstantin Shvachko >Assignee: Vinitha Reddy Gankidi > Attachments: HDFS-10733.001.patch, HDFS-10733.002.patch > > > NameNode went into full GC while in {{AsyncLoggerSet.waitForWriteQuorum()}}. > After completing GC it checks if the timeout for quorum is reached. If the GC > was long enough the timeout can expire, and {{QuorumCall.waitFor()}} will > throw {{TimeoutExcpetion}}. Finally {{FSEditLog.logSync()}} catches the > exception and terminates NameNode. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10733) NameNode terminated after full GC thinking QJM is unresponsive.
[ https://issues.apache.org/jira/browse/HDFS-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816414#comment-15816414 ] Konstantin Shvachko commented on HDFS-10733: This looks reasonable to me. Similar to {{HeartbeatManager}} approach. One nit that {{assertEquals()}} should print a meaningful message rather than just asserting. I see the other usages do not have the message, but let's at least not multiply the wrong pattern with new test cases. > NameNode terminated after full GC thinking QJM is unresponsive. > --- > > Key: HDFS-10733 > URL: https://issues.apache.org/jira/browse/HDFS-10733 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, qjm >Affects Versions: 2.6.4 >Reporter: Konstantin Shvachko >Assignee: Vinitha Reddy Gankidi > Attachments: HDFS-10733.001.patch > > > NameNode went into full GC while in {{AsyncLoggerSet.waitForWriteQuorum()}}. > After completing GC it checks if the timeout for quorum is reached. If the GC > was long enough the timeout can expire, and {{QuorumCall.waitFor()}} will > throw {{TimeoutExcpetion}}. Finally {{FSEditLog.logSync()}} catches the > exception and terminates NameNode. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10733) NameNode terminated after full GC thinking QJM is unresponsive.
[ https://issues.apache.org/jira/browse/HDFS-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812538#comment-15812538 ] Vinitha Reddy Gankidi commented on HDFS-10733: -- [~kihwal] Thanks for the great suggestion. I have attached a patch that increases the endtime/timeout if there is a long pause due to a Full GC in NN. The unit test included asserts that a timeout exception is thrown instead of increasing the timeout as in the case of a Full GC if there indeed aren't any responses from the journal nodes. Please take a look. > NameNode terminated after full GC thinking QJM is unresponsive. > --- > > Key: HDFS-10733 > URL: https://issues.apache.org/jira/browse/HDFS-10733 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, qjm >Affects Versions: 2.6.4 >Reporter: Konstantin Shvachko >Assignee: Vinitha Reddy Gankidi > Attachments: HDFS-10733.001.patch > > > NameNode went into full GC while in {{AsyncLoggerSet.waitForWriteQuorum()}}. > After completing GC it checks if the timeout for quorum is reached. If the GC > was long enough the timeout can expire, and {{QuorumCall.waitFor()}} will > throw {{TimeoutExcpetion}}. Finally {{FSEditLog.logSync()}} catches the > exception and terminates NameNode. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10733) NameNode terminated after full GC thinking QJM is unresponsive.
[ https://issues.apache.org/jira/browse/HDFS-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413811#comment-15413811 ] Kihwal Lee commented on HDFS-10733: --- Can we something similar to HDFS-9107? > NameNode terminated after full GC thinking QJM is unresponsive. > --- > > Key: HDFS-10733 > URL: https://issues.apache.org/jira/browse/HDFS-10733 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, qjm >Affects Versions: 2.6.4 >Reporter: Konstantin Shvachko > > NameNode went into full GC while in {{AsyncLoggerSet.waitForWriteQuorum()}}. > After completing GC it checks if the timeout for quorum is reached. If the GC > was long enough the timeout can expire, and {{QuorumCall.waitFor()}} will > throw {{TimeoutExcpetion}}. Finally {{FSEditLog.logSync()}} catches the > exception and terminates NameNode. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org