[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454972#comment-16454972
]
Hudson commented on HDFS-10932:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14070/])
HDFS-10932. Ozone: fix XceiverClient slow shutdown. Contributed by Chen
(omalley: rev d0422a74ea41f53d3dabf6b558f30e3d3dac9b6d)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/container/common/transport/client/XceiverClient.java
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
> URL: https://issues.apache.org/jira/browse/HDFS-10932
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Chen Liang
>Assignee: Chen Liang
>Priority: Major
> Attachments: HDFS-10932-HDFS-7240.002.patch,
> HDFS-10932-HDFS-7240.002.patch, HDFS-10932.001.patch
>
>
> Currently {{XceiverClient}} is the underlying entity of
> {{DistributedStorageHandler.newKeyWriter()}} and
> {{DistributedStorageHandler.newKeyReader()}} for making call to container
> for read/write. When {{XceiverClient}} gets closed,
> {{group.shutdownGracefully()}} gets called, which is an asynchronous call.
> A problem is that this asynchronous call has default quiet period of 2
> seconds before it actually shutdown, so if we have a burst of read/write
> calls, we would end up having threads created faster than they got
> terminated, reaching system limit at some point.
> Ideally, this needs to be fixed with cached clients instead of creating new
> thread each time. This JIRA only tries to give a temporary fix for the time
> being.
> Thanks [~anu] for the offline discussion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450529#comment-16450529
]
Hudson commented on HDFS-10932:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14057/])
HDFS-10932. Ozone: fix XceiverClient slow shutdown. Contributed by Chen
(aengineer: rev 4217f8520266380db436ad520399eb86ca7b669a)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/container/common/transport/client/XceiverClient.java
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
> URL: https://issues.apache.org/jira/browse/HDFS-10932
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Chen Liang
>Assignee: Chen Liang
>Priority: Major
> Attachments: HDFS-10932-HDFS-7240.002.patch,
> HDFS-10932-HDFS-7240.002.patch, HDFS-10932.001.patch
>
>
> Currently {{XceiverClient}} is the underlying entity of
> {{DistributedStorageHandler.newKeyWriter()}} and
> {{DistributedStorageHandler.newKeyReader()}} for making call to container
> for read/write. When {{XceiverClient}} gets closed,
> {{group.shutdownGracefully()}} gets called, which is an asynchronous call.
> A problem is that this asynchronous call has default quiet period of 2
> seconds before it actually shutdown, so if we have a burst of read/write
> calls, we would end up having threads created faster than they got
> terminated, reaching system limit at some point.
> Ideally, this needs to be fixed with cached clients instead of creating new
> thread each time. This JIRA only tries to give a temporary fix for the time
> being.
> Thanks [~anu] for the offline discussion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537475#comment-15537475
]
Anu Engineer commented on HDFS-10932:
-
+1, I will commit this now.
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
> URL: https://issues.apache.org/jira/browse/HDFS-10932
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HDFS-10932-HDFS-7240.002.patch,
> HDFS-10932-HDFS-7240.002.patch, HDFS-10932.001.patch
>
>
> Currently {{XceiverClient}} is the underlying entity of
> {{DistributedStorageHandler.newKeyWriter()}} and
> {{DistributedStorageHandler.newKeyReader()}} for making call to container
> for read/write. When {{XceiverClient}} gets closed,
> {{group.shutdownGracefully()}} gets called, which is an asynchronous call.
> A problem is that this asynchronous call has default quiet period of 2
> seconds before it actually shutdown, so if we have a burst of read/write
> calls, we would end up having threads created faster than they got
> terminated, reaching system limit at some point.
> Ideally, this needs to be fixed with cached clients instead of creating new
> thread each time. This JIRA only tries to give a temporary fix for the time
> being.
> Thanks [~anu] for the offline discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537451#comment-15537451
]
Hadoop QA commented on HDFS-10932:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
27s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
56s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
56s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
18s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 61m 49s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 83m 30s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.TestCrcCorruption |
| | hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover |
| | hadoop.hdfs.server.datanode.TestBlockPoolManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HDFS-10932 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12831170/HDFS-10932-HDFS-7240.002.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux cc2000c7987f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | HDFS-7240 / 595257e |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/16954/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/16954/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/16954/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
>
[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537070#comment-15537070
]
Anu Engineer commented on HDFS-10932:
-
scheduled a new build
https://builds.apache.org/job/PreCommit-HDFS-Build/16954/
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
> URL: https://issues.apache.org/jira/browse/HDFS-10932
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HDFS-10932-HDFS-7240.002.patch,
> HDFS-10932-HDFS-7240.002.patch, HDFS-10932.001.patch
>
>
> Currently {{XceiverClient}} is the underlying entity of
> {{DistributedStorageHandler.newKeyWriter()}} and
> {{DistributedStorageHandler.newKeyReader()}} for making call to container
> for read/write. When {{XceiverClient}} gets closed,
> {{group.shutdownGracefully()}} gets called, which is an asynchronous call.
> A problem is that this asynchronous call has default quiet period of 2
> seconds before it actually shutdown, so if we have a burst of read/write
> calls, we would end up having threads created faster than they got
> terminated, reaching system limit at some point.
> Ideally, this needs to be fixed with cached clients instead of creating new
> thread each time. This JIRA only tries to give a temporary fix for the time
> being.
> Thanks [~anu] for the offline discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537065#comment-15537065
]
Chen Liang commented on HDFS-10932:
---
Sure! I updated the patch a second time to trigger the Jenkins check.
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
> URL: https://issues.apache.org/jira/browse/HDFS-10932
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HDFS-10932-HDFS-7240.002.patch,
> HDFS-10932-HDFS-7240.002.patch, HDFS-10932.001.patch
>
>
> Currently {{XceiverClient}} is the underlying entity of
> {{DistributedStorageHandler.newKeyWriter()}} and
> {{DistributedStorageHandler.newKeyReader()}} for making call to container
> for read/write. When {{XceiverClient}} gets closed,
> {{group.shutdownGracefully()}} gets called, which is an asynchronous call.
> A problem is that this asynchronous call has default quiet period of 2
> seconds before it actually shutdown, so if we have a burst of read/write
> calls, we would end up having threads created faster than they got
> terminated, reaching system limit at some point.
> Ideally, this needs to be fixed with cached clients instead of creating new
> thread each time. This JIRA only tries to give a temporary fix for the time
> being.
> Thanks [~anu] for the offline discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537044#comment-15537044
]
Anu Engineer commented on HDFS-10932:
-
[~vagarychen] Thanks for checking. Since the exception says "Exception
connecting XceiverClient." and the change was in the XceiverClient, I will just
get one more run from Jenkins. Just want to make sure that we are not
introducing any regressions.
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
> URL: https://issues.apache.org/jira/browse/HDFS-10932
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HDFS-10932-HDFS-7240.002.patch, HDFS-10932.001.patch
>
>
> Currently {{XceiverClient}} is the underlying entity of
> {{DistributedStorageHandler.newKeyWriter()}} and
> {{DistributedStorageHandler.newKeyReader()}} for making call to container
> for read/write. When {{XceiverClient}} gets closed,
> {{group.shutdownGracefully()}} gets called, which is an asynchronous call.
> A problem is that this asynchronous call has default quiet period of 2
> seconds before it actually shutdown, so if we have a burst of read/write
> calls, we would end up having threads created faster than they got
> terminated, reaching system limit at some point.
> Ideally, this needs to be fixed with cached clients instead of creating new
> thread each time. This JIRA only tries to give a temporary fix for the time
> being.
> Thanks [~anu] for the offline discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537032#comment-15537032
]
Chen Liang commented on HDFS-10932:
---
The failed tests do not seem to be related, local runs do not have the test
fails in {{TestOzoneRestWithMiniCluster}} and {{TestBlockTokenWithDFSStriped}},
but {{TestBlockPoolManager.testFederationRefresh}} has been consistently
failing locally with the patch AND without the patch. May need to fix it
separately.
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
> URL: https://issues.apache.org/jira/browse/HDFS-10932
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HDFS-10932-HDFS-7240.002.patch, HDFS-10932.001.patch
>
>
> Currently {{XceiverClient}} is the underlying entity of
> {{DistributedStorageHandler.newKeyWriter()}} and
> {{DistributedStorageHandler.newKeyReader()}} for making call to container
> for read/write. When {{XceiverClient}} gets closed,
> {{group.shutdownGracefully()}} gets called, which is an asynchronous call.
> A problem is that this asynchronous call has default quiet period of 2
> seconds before it actually shutdown, so if we have a burst of read/write
> calls, we would end up having threads created faster than they got
> terminated, reaching system limit at some point.
> Ideally, this needs to be fixed with cached clients instead of creating new
> thread each time. This JIRA only tries to give a temporary fix for the time
> being.
> Thanks [~anu] for the offline discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536798#comment-15536798
]
Hadoop QA commented on HDFS-10932:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
29s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
59s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
5s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 58m 32s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 83m 7s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ozone.web.TestOzoneRestWithMiniCluster |
| | hadoop.hdfs.server.datanode.TestBlockPoolManager |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HDFS-10932 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12831132/HDFS-10932-HDFS-7240.002.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 4a76345ad3b5 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | HDFS-7240 / 595257e |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/16949/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/16949/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/16949/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534637#comment-15534637
]
Hadoop QA commented on HDFS-10932:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HDFS-10932 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-10932 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12831020/HDFS-10932.001.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/16936/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
> URL: https://issues.apache.org/jira/browse/HDFS-10932
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HDFS-10932.001.patch
>
>
> Currently {{XceiverClient}} is the underlying entity of
> {{DistributedStorageHandler.newKeyWriter()}} and
> {{DistributedStorageHandler.newKeyReader()}} for making call to container
> for read/write. When {{XceiverClient}} gets closed,
> {{group.shutdownGracefully()}} gets called, which is an asynchronous call.
> A problem is that this asynchronous call has default quiet period of 2
> seconds before it actually shutdown, so if we have a burst of read/write
> calls, we would end up having threads created faster than they got
> terminated, reaching system limit at some point.
> Ideally, this needs to be fixed with cached clients instead of creating new
> thread each time. This JIRA only tries to give a temporary fix for the time
> being.
> Thanks [~anu] for the offline discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10932) Ozone : fix XceiverClient slow shutdown
[
https://issues.apache.org/jira/browse/HDFS-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534352#comment-15534352
]
Anu Engineer commented on HDFS-10932:
-
+1 , pending jenkins. I think we should have this patch until we have a
XceiverClientFactory class that can manage the caching.
> Ozone : fix XceiverClient slow shutdown
> ---
>
> Key: HDFS-10932
> URL: https://issues.apache.org/jira/browse/HDFS-10932
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HDFS-10932.001.patch
>
>
> Currently {{XceiverClient}} is the underlying entity of
> {{DistributedStorageHandler.newKeyWriter()}} and
> {{DistributedStorageHandler.newKeyReader()}} for making call to container
> for read/write. When {{XceiverClient}} gets closed,
> {{group.shutdownGracefully()}} gets called, which is an asynchronous call.
> A problem is that this asynchronous call has default quiet period of 2
> seconds before it actually shutdown, so if we have a burst of read/write
> calls, we would end up having threads created faster than they got
> terminated, reaching system limit at some point.
> Ideally, this needs to be fixed with cached clients instead of creating new
> thread each time. This JIRA only tries to give a temporary fix for the time
> being.
> Thanks [~anu] for the offline discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
