[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15577304#comment-15577304 ] Yiqun Lin commented on HDFS-10990: -- Thanks [~kihwal] for the final commit! > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Fix For: 2.8.0, 3.0.0-alpha2 > > Attachments: HDFS-10990.001.patch, HDFS-10990.002.patch, > HDFS-10990.003.patch, HDFS-10990.004.branch-2.patch, HDFS-10990.004.patch > > > After HDFS-10426, the test {{TestPendingInvalidateBlock#testPendingDeletion}} > still fails sometimes. As [~iwasakims] commented in > HDFS-10426(https://issues.apache.org/jira/browse/HDFS-10426?focusedCommentId=15539826=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15539826), > we should add a line {{DFSTestUtil.waitForReplication}} to wait for the IBR > and not do the assert opertion first. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575868#comment-15575868 ] Hudson commented on HDFS-10990: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10611 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10611/]) HDFS-10990. TestPendingInvalidateBlock should wait for IBRs. Contributed (kihwal: rev 8a9f6635a33e9648e9396e9ec5571fa34aa0c773) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Fix For: 2.8.0, 3.0.0-alpha2 > > Attachments: HDFS-10990.001.patch, HDFS-10990.002.patch, > HDFS-10990.003.patch, HDFS-10990.004.branch-2.patch, HDFS-10990.004.patch > > > After HDFS-10426, the test {{TestPendingInvalidateBlock#testPendingDeletion}} > still fails sometimes. As [~iwasakims] commented in > HDFS-10426(https://issues.apache.org/jira/browse/HDFS-10426?focusedCommentId=15539826=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15539826), > we should add a line {{DFSTestUtil.waitForReplication}} to wait for the IBR > and not do the assert opertion first. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575807#comment-15575807 ] Kihwal Lee commented on HDFS-10990: --- +1 > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-10990.001.patch, HDFS-10990.002.patch, > HDFS-10990.003.patch, HDFS-10990.004.branch-2.patch, HDFS-10990.004.patch > > > After HDFS-10426, the test {{TestPendingInvalidateBlock#testPendingDeletion}} > still fails sometimes. As [~iwasakims] commented in > HDFS-10426(https://issues.apache.org/jira/browse/HDFS-10426?focusedCommentId=15539826=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15539826), > we should add a line {{DFSTestUtil.waitForReplication}} to wait for the IBR > and not do the assert opertion first. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575003#comment-15575003 ] Yiqun Lin commented on HDFS-10990: -- Thanks [~andrew.wang] for updating the patch. The jenkins's result showed that the new patch can be passed both in trunk and branch-2. > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-10990.001.patch, HDFS-10990.002.patch, > HDFS-10990.003.patch, HDFS-10990.004.branch-2.patch, HDFS-10990.004.patch > > > After HDFS-10426, the test {{TestPendingInvalidateBlock#testPendingDeletion}} > still fails sometimes. As [~iwasakims] commented in > HDFS-10426(https://issues.apache.org/jira/browse/HDFS-10426?focusedCommentId=15539826=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15539826), > we should add a line {{DFSTestUtil.waitForReplication}} to wait for the IBR > and not do the assert opertion first. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574082#comment-15574082 ] Hadoop QA commented on HDFS-10990: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m 10s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 30s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s{color} | {color:green} branch-2 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s{color} | {color:green} branch-2 passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 26s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 52s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 55s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} branch-2 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 36s{color} | {color:green} branch-2 passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 31s{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 49m 51s{color} | {color:green} hadoop-hdfs in the patch passed with JDK v1.7.0_111. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 26s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}136m 50s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:b59b8b7 | | JIRA Issue | HDFS-10990 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12833269/HDFS-10990.004.branch-2.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux e96bdd41f459 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | branch-2 / ad69baf | | Default Java | 1.7.0_111 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 | | findbugs | v3.0.0 | | JDK v1.7.0_111 Test Results |
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573482#comment-15573482 ] Hadoop QA commented on HDFS-10990: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m 1s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 8s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 56s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 51s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 61m 47s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 95m 12s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Issue | HDFS-10990 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12833198/HDFS-10990.004.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 8aff1f8483c6 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 0a85d07 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/17141/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/17141/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/17141/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573122#comment-15573122 ] Hudson commented on HDFS-10990: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10607 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10607/]) Revert "HDFS-10990. TestPendingInvalidateBlock should wait for IBRs. (wang: rev 8c721aa00a47a976959e3861ddd742f09db432fc) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-10990.001.patch, HDFS-10990.002.patch, > HDFS-10990.003.patch, HDFS-10990.004.patch > > > After HDFS-10426, the test {{TestPendingInvalidateBlock#testPendingDeletion}} > still fails sometimes. As [~iwasakims] commented in > HDFS-10426(https://issues.apache.org/jira/browse/HDFS-10426?focusedCommentId=15539826=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15539826), > we should add a line {{DFSTestUtil.waitForReplication}} to wait for the IBR > and not do the assert opertion first. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572980#comment-15572980 ] Kihwal Lee commented on HDFS-10990: --- It looks like branch-2 build is failing after this. > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Fix For: 2.8.0, 3.0.0-alpha2 > > Attachments: HDFS-10990.001.patch, HDFS-10990.002.patch, > HDFS-10990.003.patch > > > After HDFS-10426, the test {{TestPendingInvalidateBlock#testPendingDeletion}} > still fails sometimes. As [~iwasakims] commented in > HDFS-10426(https://issues.apache.org/jira/browse/HDFS-10426?focusedCommentId=15539826=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15539826), > we should add a line {{DFSTestUtil.waitForReplication}} to wait for the IBR > and not do the assert opertion first. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572860#comment-15572860 ] Hudson commented on HDFS-10990: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10605 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10605/]) HDFS-10990. TestPendingInvalidateBlock should wait for IBRs. Contributed (wang: rev fdce515091f0a61ffd6c9ae464a68447dedf1124) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Fix For: 2.8.0, 3.0.0-alpha2 > > Attachments: HDFS-10990.001.patch, HDFS-10990.002.patch, > HDFS-10990.003.patch > > > After HDFS-10426, the test {{TestPendingInvalidateBlock#testPendingDeletion}} > still fails sometimes. As [~iwasakims] commented in > HDFS-10426(https://issues.apache.org/jira/browse/HDFS-10426?focusedCommentId=15539826=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15539826), > we should add a line {{DFSTestUtil.waitForReplication}} to wait for the IBR > and not do the assert opertion first. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571980#comment-15571980 ] Yiqun Lin commented on HDFS-10990: -- The failed test are not related. Hi, [~andrew.wang], can make a quick look if the latest patch looks good to you? I see that this test was frequently fails recently(In HDFS-11003, it fails again:(, link address: https://builds.apache.org/job/PreCommit-HDFS-Build/17135/testReport/). > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-10990.001.patch, HDFS-10990.002.patch, > HDFS-10990.003.patch > > > After HDFS-10426, the test {{TestPendingInvalidateBlock#testPendingDeletion}} > still fails sometimes. As [~iwasakims] commented in > HDFS-10426(https://issues.apache.org/jira/browse/HDFS-10426?focusedCommentId=15539826=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15539826), > we should add a line {{DFSTestUtil.waitForReplication}} to wait for the IBR > and not do the assert opertion first. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567458#comment-15567458 ] Hadoop QA commented on HDFS-10990: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 18s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 47s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 52s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 42s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 61m 11s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 80m 54s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.TestDecommissioningStatus | | | hadoop.hdfs.TestRenameWhileOpen | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Issue | HDFS-10990 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832813/HDFS-10990.003.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 2bafbc019336 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / b84c489 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/17117/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/17117/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/17117/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor >
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566786#comment-15566786 ] Andrew Wang commented on HDFS-10990: Thanks for working on this Yiqun Lin, LGTM overall some really small nits: * Consider renaming {{waitForBlocksToDelete(int)}} to something like {{waitForNumPendingDeletionBlocks}}, wasn't clear to me what this method was doing based on the name. * Consider renaming {{remainedBlocks}} to just {{numBlocks}} if you do the above, more clear and grammatical. > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-10990.001.patch, HDFS-10990.002.patch > > > After HDFS-10426, the test {{TestPendingInvalidateBlock#testPendingDeletion}} > still fails sometimes. As [~iwasakims] commented in > HDFS-10426(https://issues.apache.org/jira/browse/HDFS-10426?focusedCommentId=15539826=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15539826), > we should add a line {{DFSTestUtil.waitForReplication}} to wait for the IBR > and not do the assert opertion first. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10990) TestPendingInvalidateBlock should wait for IBRs
[ https://issues.apache.org/jira/browse/HDFS-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562000#comment-15562000 ] Hadoop QA commented on HDFS-10990: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 7s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 26s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 50s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 38s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 50s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 74m 42s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 93m 40s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Issue | HDFS-10990 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832437/HDFS-10990.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 87960cff3cd9 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / af50da3 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/17080/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/17080/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/17080/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > TestPendingInvalidateBlock should wait for IBRs > --- > > Key: HDFS-10990 > URL: https://issues.apache.org/jira/browse/HDFS-10990 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: