[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731103#comment-15731103 ] Hudson commented on HDFS-11140: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10967 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10967/]) HDFS-11140. Directory Scanner should log startup message time correctly. (aajisaka: rev 0857641f62778fad64e8158d78320efb0c8b417c) * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java Revert "HDFS-11140. Directory Scanner should log startup message time (aajisaka: rev deb4743b2c3bb5c23842f0e224b89e41ef2d36d4) * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java HDFS-11140. Directory Scanner should log startup message time correctly. (aajisaka: rev 9ef89ede2f18c76c601fd585cb9d47511f5fc3ed) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java > Directory Scanner should log startup message time correctly > --- > > Key: HDFS-11140 > URL: https://issues.apache.org/jira/browse/HDFS-11140 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.1 >Reporter: Xiao Chen >Assignee: Yiqun Lin >Priority: Minor > Labels: newbie > Fix For: 2.8.0, 3.0.0-alpha2 > > Attachments: HDFS-11140.001.patch, HDFS-11140.002.patch > > > When DirectoryScanner is enabled, one can see the following log: > {noformat} > INFO org.apache.hadoop.hdfs.server.datanode.DirectoryScanner: Periodic > Directory Tree Verification scan starting at 1479189895562ms with interval of > 2160ms > {noformat} > The first is epoch time and should not have 'ms'. Or better yet, we can > change it to a human-readable format. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731063#comment-15731063 ] Akira Ajisaka commented on HDFS-11140: -- +1, checking this in. > Directory Scanner should log startup message time correctly > --- > > Key: HDFS-11140 > URL: https://issues.apache.org/jira/browse/HDFS-11140 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.1 >Reporter: Xiao Chen >Assignee: Yiqun Lin >Priority: Trivial > Labels: newbie > Attachments: HDFS-11140.001.patch, HDFS-11140.002.patch > > > When DirectoryScanner is enabled, one can see the following log: > {noformat} > INFO org.apache.hadoop.hdfs.server.datanode.DirectoryScanner: Periodic > Directory Tree Verification scan starting at 1479189895562ms with interval of > 2160ms > {noformat} > The first is epoch time and should not have 'ms'. Or better yet, we can > change it to a human-readable format. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675351#comment-15675351 ] Yiqun Lin commented on HDFS-11140: -- Thanks [~xyao] for the review, the failed test is not related. Feel free to have a commit. Thanks. > Directory Scanner should log startup message time correctly > --- > > Key: HDFS-11140 > URL: https://issues.apache.org/jira/browse/HDFS-11140 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.1 >Reporter: Xiao Chen >Assignee: Yiqun Lin >Priority: Trivial > Labels: newbie > Attachments: HDFS-11140.001.patch, HDFS-11140.002.patch > > > When DirectoryScanner is enabled, one can see the following log: > {noformat} > INFO org.apache.hadoop.hdfs.server.datanode.DirectoryScanner: Periodic > Directory Tree Verification scan starting at 1479189895562ms with interval of > 2160ms > {noformat} > The first is epoch time and should not have 'ms'. Or better yet, we can > change it to a human-readable format. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669201#comment-15669201 ] Hadoop QA commented on HDFS-11140: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 7s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 54s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 16s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 59s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 55m 35s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 74m 45s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.TestDecommissioningStatus | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:a9ad5d6 | | JIRA Issue | HDFS-11140 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12839094/HDFS-11140.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 48fa9716ddc5 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 61c0bed | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/17579/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/17579/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/17579/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Directory Scanner should log startup message time correctly > --- > > Key: HDFS-11140 > URL: https://issues.apache.org/jira/browse/HDFS-11140 > Project: Hadoop HDFS > Issue
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669080#comment-15669080 ] Xiaoyu Yao commented on HDFS-11140: --- Thanks [~linyiqun] for the udpate. +1 for v2 patch pending Jenkins. > Directory Scanner should log startup message time correctly > --- > > Key: HDFS-11140 > URL: https://issues.apache.org/jira/browse/HDFS-11140 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.1 >Reporter: Xiao Chen >Assignee: Yiqun Lin >Priority: Trivial > Labels: newbie > Attachments: HDFS-11140.001.patch, HDFS-11140.002.patch > > > When DirectoryScanner is enabled, one can see the following log: > {noformat} > INFO org.apache.hadoop.hdfs.server.datanode.DirectoryScanner: Periodic > Directory Tree Verification scan starting at 1479189895562ms with interval of > 2160ms > {noformat} > The first is epoch time and should not have 'ms'. Or better yet, we can > change it to a human-readable format. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667680#comment-15667680 ] Xiaoyu Yao commented on HDFS-11140: --- Thanks [~linyiqun] for the explanation. That makes sense to me. One more suggestion: we can format firstScanTime into human readable format with a simpler patch using apache common's FastDateFormat like below . {code} org.apache.commons.lang.time.FastDateFormat.getInstance().format(firstScanTime) {code} > Directory Scanner should log startup message time correctly > --- > > Key: HDFS-11140 > URL: https://issues.apache.org/jira/browse/HDFS-11140 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.1 >Reporter: Xiao Chen >Assignee: Yiqun Lin >Priority: Trivial > Labels: newbie > Attachments: HDFS-11140.001.patch > > > When DirectoryScanner is enabled, one can see the following log: > {noformat} > INFO org.apache.hadoop.hdfs.server.datanode.DirectoryScanner: Periodic > Directory Tree Verification scan starting at 1479189895562ms with interval of > 2160ms > {noformat} > The first is epoch time and should not have 'ms'. Or better yet, we can > change it to a human-readable format. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667468#comment-15667468 ] Yiqun Lin commented on HDFS-11140: -- The test {{TestLargeBlockReport}} fails two times, filed HDFS-11142 to track that. > Directory Scanner should log startup message time correctly > --- > > Key: HDFS-11140 > URL: https://issues.apache.org/jira/browse/HDFS-11140 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.1 >Reporter: Xiao Chen >Assignee: Yiqun Lin >Priority: Trivial > Labels: newbie > Attachments: HDFS-11140.001.patch > > > When DirectoryScanner is enabled, one can see the following log: > {noformat} > INFO org.apache.hadoop.hdfs.server.datanode.DirectoryScanner: Periodic > Directory Tree Verification scan starting at 1479189895562ms with interval of > 2160ms > {noformat} > The first is epoch time and should not have 'ms'. Or better yet, we can > change it to a human-readable format. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667014#comment-15667014 ] Hadoop QA commented on HDFS-11140: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 25s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 48s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 51s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 41s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 50s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 75m 16s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 93m 46s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-hdfs-project/hadoop-hdfs | | | Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DirectoryScanner.start() At DirectoryScanner.java:java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DirectoryScanner.start() At DirectoryScanner.java:[line 277] | | Failed junit tests | hadoop.hdfs.TestBlockStoragePolicy | | | hadoop.hdfs.server.datanode.TestLargeBlockReport | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:a9ad5d6 | | JIRA Issue | HDFS-11140 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12838948/HDFS-11140.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux e9095752092b 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 7ffb994 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/17571/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/17571/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results |
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666820#comment-15666820 ] Yiqun Lin commented on HDFS-11140: -- Thanks [~xyao] for the comments. {quote} How about removing the starting timestamp as the log4j always has that info at the beginning of each log entry? {quote} Here the time of log4j info is not the real start time of DirectoryScanner. There is an additional offset time that randoming from 0 to {{scanPeriod}} that will be increased to the start time. Attach the new patch to fix checkstyle warnings. > Directory Scanner should log startup message time correctly > --- > > Key: HDFS-11140 > URL: https://issues.apache.org/jira/browse/HDFS-11140 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.1 >Reporter: Xiao Chen >Assignee: Yiqun Lin >Priority: Trivial > Labels: newbie > Attachments: HDFS-11140.001.patch > > > When DirectoryScanner is enabled, one can see the following log: > {noformat} > INFO org.apache.hadoop.hdfs.server.datanode.DirectoryScanner: Periodic > Directory Tree Verification scan starting at 1479189895562ms with interval of > 2160ms > {noformat} > The first is epoch time and should not have 'ms'. Or better yet, we can > change it to a human-readable format. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666403#comment-15666403 ] Hadoop QA commented on HDFS-11140: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 25s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 51s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 40s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 23s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 42 unchanged - 0 fixed = 43 total (was 42) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 91m 47s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}110m 46s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR | | | hadoop.hdfs.server.datanode.TestLargeBlockReport | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:a9ad5d6 | | JIRA Issue | HDFS-11140 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12838922/HDFS-11140.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux a437211d7358 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / b7070f3 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/17569/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/17569/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/17569/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/17569/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666311#comment-15666311 ] Xiaoyu Yao commented on HDFS-11140: --- Thanks [~xiaochen] for reporting the issue and [~linyiqun] for posting the patch. How about removing the starting timestamp as the log4j always has that info at the beginning of each log entry? This way we don't need to add logic to covert the epoch and unit test for it. {code} INFO org.apache.hadoop.hdfs.server.datanode.DirectoryScanner: Periodic Directory Tree Verification scan starting with interval of 2160ms {code} > Directory Scanner should log startup message time correctly > --- > > Key: HDFS-11140 > URL: https://issues.apache.org/jira/browse/HDFS-11140 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.1 >Reporter: Xiao Chen >Assignee: Yiqun Lin >Priority: Trivial > Labels: newbie > Attachments: HDFS-11140.001.patch > > > When DirectoryScanner is enabled, one can see the following log: > {noformat} > INFO org.apache.hadoop.hdfs.server.datanode.DirectoryScanner: Periodic > Directory Tree Verification scan starting at 1479189895562ms with interval of > 2160ms > {noformat} > The first is epoch time and should not have 'ms'. Or better yet, we can > change it to a human-readable format. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11140) Directory Scanner should log startup message time correctly
[ https://issues.apache.org/jira/browse/HDFS-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665826#comment-15665826 ] Brahma Reddy Battula commented on HDFS-11140: - Moved to hadoop-hdfs. > Directory Scanner should log startup message time correctly > --- > > Key: HDFS-11140 > URL: https://issues.apache.org/jira/browse/HDFS-11140 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.1 >Reporter: Xiao Chen >Priority: Trivial > Labels: newbie > > When DirectoryScanner is enabled, one can see the following log: > {noformat} > INFO org.apache.hadoop.hdfs.server.datanode.DirectoryScanner: Periodic > Directory Tree Verification scan starting at 1479189895562ms with interval of > 2160ms > {noformat} > The first is epoch time and should not have 'ms'. Or better yet, we can > change it to a human-readable format. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org