[jira] [Commented] (HDFS-11290) TestFSNameSystemMBean should wait until JMX cache is cleared
[ https://issues.apache.org/jira/browse/HDFS-11290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827719#comment-15827719 ] Hudson commented on HDFS-11290: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11133 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11133/]) HDFS-11290. TestFSNameSystemMBean should wait until JMX cache is (aajisaka: rev b1a9ec856b572894e769f052aea2340fc3f23c78) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystemMBean.java > TestFSNameSystemMBean should wait until JMX cache is cleared > > > Key: HDFS-11290 > URL: https://issues.apache.org/jira/browse/HDFS-11290 > Project: Hadoop HDFS > Issue Type: Test > Components: test >Affects Versions: 2.8.0 >Reporter: Akira Ajisaka >Assignee: Erik Krogen > Fix For: 2.9.0, 3.0.0-alpha2 > > Attachments: HDFS-11290.000.patch, HDFS-11290.001.patch > > > TestFSNamesystemMBean#testWithFSNamesystemWriteLock and > #testWithFSEditLogLock get metrics after locking FSNameSystem/FSEditLog, but > when the metrics are cached, the tests success even if the metrics acquire > the locks. The tests should wait until the cache is cleared. > This issue was reported by [~xkrogen] in HDFS-11180. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11290) TestFSNameSystemMBean should wait until the cache is cleared
[ https://issues.apache.org/jira/browse/HDFS-11290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827646#comment-15827646 ] Akira Ajisaka commented on HDFS-11290: -- +1 > TestFSNameSystemMBean should wait until the cache is cleared > > > Key: HDFS-11290 > URL: https://issues.apache.org/jira/browse/HDFS-11290 > Project: Hadoop HDFS > Issue Type: Test > Components: test >Affects Versions: 2.8.0 >Reporter: Akira Ajisaka >Assignee: Erik Krogen > Attachments: HDFS-11290.000.patch, HDFS-11290.001.patch > > > TestFSNamesystemMBean#testWithFSNamesystemWriteLock and > #testWithFSEditLogLock get metrics after locking FSNameSystem/FSEditLog, but > when the metrics are cached, the tests success even if the metrics acquire > the locks. The tests should wait until the cache is cleared. > This issue was reported by [~xkrogen] in HDFS-11180. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11290) TestFSNameSystemMBean should wait until the cache is cleared
[
https://issues.apache.org/jira/browse/HDFS-11290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826584#comment-15826584
]
Hadoop QA commented on HDFS-11290:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}101m
15s{color} | {color:green} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}127m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HDFS-11290 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12847857/HDFS-11290.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 5379a8265a88 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29
20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 78b487b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/18190/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/18190/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> TestFSNameSystemMBean should wait until the cache is cleared
>
>
> Key: HDFS-11290
> URL: https://issues.apache.org/jira/browse/HDFS-11290
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
>Affects Versions: 2.8.0
>Reporter: Akira Ajisaka
>Assignee: Erik Krogen
> Attachments: HDFS-11290.000.patch, HDFS-11290.001.patch
>
>
> TestFSNamesystemMBean#testWithFSNamesystemWriteLock and
> #testWithFSEditLogLock get metrics after locking FSNameSystem/FSEditLog, but
> when the
[jira] [Commented] (HDFS-11290) TestFSNameSystemMBean should wait until the cache is cleared
[
https://issues.apache.org/jira/browse/HDFS-11290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825712#comment-15825712
]
Akira Ajisaka commented on HDFS-11290:
--
Thanks [~xkrogen] for providing a patch. Mostly looks good to me.
{code}
+new ConfigBuilder().add("namenode.period", jmxCachePeriod)
+.save("hadoop-metrics2.properties");
{code}
Would you use {{TestMetricsConfig.getTestFilename}} to generate the metrics
config file to {{hadoop-hdfs-project/hadoop-hdfs/target/test-class}}? I'm +1 if
that is addressed.
> TestFSNameSystemMBean should wait until the cache is cleared
>
>
> Key: HDFS-11290
> URL: https://issues.apache.org/jira/browse/HDFS-11290
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
>Affects Versions: 2.8.0
>Reporter: Akira Ajisaka
>Assignee: Erik Krogen
> Attachments: HDFS-11290.000.patch
>
>
> TestFSNamesystemMBean#testWithFSNamesystemWriteLock and
> #testWithFSEditLogLock get metrics after locking FSNameSystem/FSEditLog, but
> when the metrics are cached, the tests success even if the metrics acquire
> the locks. The tests should wait until the cache is cleared.
> This issue was reported by [~xkrogen] in HDFS-11180.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
