[jira] [Commented] (HDFS-11880) Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo from KSM wrappers
[ https://issues.apache.org/jira/browse/HDFS-11880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041714#comment-16041714 ] Xiaoyu Yao commented on HDFS-11880: --- Thanks [~nandakumar131] for the patch. The latest patch looks good to me. +1. Only one minor javadoc issue: KsmBucketInfo.java line 94/110 that I will update at commit time. I noticed that OzoneConsts.java is moved into hadoop-hdfs-client with this change. Some of the const are used only by KSM/SCM server. We might consider have a OzoneClientConsts.java for those client only constants. We can do that in a follow up JIRA. > Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo > from KSM wrappers > --- > > Key: HDFS-11880 > URL: https://issues.apache.org/jira/browse/HDFS-11880 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Nandakumar >Assignee: Nandakumar > Attachments: HDFS-11880-HDFS-7240.000.patch, > HDFS-11880-HDFS-7240.001.patch > > > KSM wrappers like KsmBucketInfo and KsmBucketArgs are using protobuf formats > such as StorageTypeProto and OzoneAclInfo, this jira is to remove the > dependency and use {{StorageType}} and {{OzoneAcl}} instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11880) Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo from KSM wrappers
[ https://issues.apache.org/jira/browse/HDFS-11880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040943#comment-16040943 ] Hadoop QA commented on HDFS-11880: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 5 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 48s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 39s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 42s{color} | {color:green} HDFS-7240 passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 44s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs-client in HDFS-7240 has 2 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 55s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in HDFS-7240 has 10 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 36s{color} | {color:green} HDFS-7240 passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 7s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 31s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 39s{color} | {color:orange} hadoop-hdfs-project: The patch generated 3 new + 7 unchanged - 4 fixed = 10 total (was 11) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 17s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 68m 59s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}108m 48s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting | | | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140 | | | hadoop.ozone.scm.TestContainerSQLCli | | | hadoop.hdfs.TestDFSRSDefault10x4StripedOutputStreamWithFailure | | Timed out junit tests | org.apache.hadoop.ozone.container.ozoneimpl.TestRatisManager | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:14b5c93 | | JIRA Issue | HDFS-11880 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12871828/HDFS-11880-HDFS-7240.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux dfc0e0939b9c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | HDFS-7240 / 9961fa3 | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC1 | | findbugs |
[jira] [Commented] (HDFS-11880) Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo from KSM wrappers
[ https://issues.apache.org/jira/browse/HDFS-11880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040778#comment-16040778 ] Nandakumar commented on HDFS-11880: --- Thanks [~anu]. Rebased the changes and uploaded a new patch. Please review. > Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo > from KSM wrappers > --- > > Key: HDFS-11880 > URL: https://issues.apache.org/jira/browse/HDFS-11880 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Nandakumar >Assignee: Nandakumar > Attachments: HDFS-11880-HDFS-7240.000.patch, > HDFS-11880-HDFS-7240.001.patch > > > KSM wrappers like KsmBucketInfo and KsmBucketArgs are using protobuf formats > such as StorageTypeProto and OzoneAclInfo, this jira is to remove the > dependency and use {{StorageType}} and {{OzoneAcl}} instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11880) Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo from KSM wrappers
[ https://issues.apache.org/jira/browse/HDFS-11880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039893#comment-16039893 ] Anu Engineer commented on HDFS-11880: - [~nandakumar131] Can you please rebase this patch and resubmit ? Thanks in advance > Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo > from KSM wrappers > --- > > Key: HDFS-11880 > URL: https://issues.apache.org/jira/browse/HDFS-11880 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Nandakumar >Assignee: Nandakumar > Attachments: HDFS-11880-HDFS-7240.000.patch > > > KSM wrappers like KsmBucketInfo and KsmBucketArgs are using protobuf formats > such as StorageTypeProto and OzoneAclInfo, this jira is to remove the > dependency and use {{StorageType}} and {{OzoneAcl}} instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11880) Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo from KSM wrappers
[ https://issues.apache.org/jira/browse/HDFS-11880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036748#comment-16036748 ] Hadoop QA commented on HDFS-11880: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color} | {color:red} HDFS-11880 does not apply to HDFS-7240. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HDFS-11880 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12871091/HDFS-11880-HDFS-7240.000.patch | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/19767/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo > from KSM wrappers > --- > > Key: HDFS-11880 > URL: https://issues.apache.org/jira/browse/HDFS-11880 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Nandakumar >Assignee: Nandakumar > Attachments: HDFS-11880-HDFS-7240.000.patch > > > KSM wrappers like KsmBucketInfo and KsmBucketArgs are using protobuf formats > such as StorageTypeProto and OzoneAclInfo, this jira is to remove the > dependency and use {{StorageType}} and {{OzoneAcl}} instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11880) Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo from KSM wrappers
[ https://issues.apache.org/jira/browse/HDFS-11880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035705#comment-16035705 ] Nandakumar commented on HDFS-11880: --- The following classes are moved from {{hadoop-hdfs-project/hadoop-hdfs}} to {{hadoop-hdfs-project/hadoop-hdfs-client}} * OzoneConsts * OzoneAcl * TestOzoneAcls > Ozone: KSM: Remove protobuf formats such as StorageTypeProto and OzoneAclInfo > from KSM wrappers > --- > > Key: HDFS-11880 > URL: https://issues.apache.org/jira/browse/HDFS-11880 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Nandakumar >Assignee: Nandakumar > Attachments: HDFS-11880-HDFS-7240.000.patch > > > KSM wrappers like KsmBucketInfo and KsmBucketArgs are using protobuf formats > such as StorageTypeProto and OzoneAclInfo, this jira is to remove the > dependency and use {{StorageType}} and {{OzoneAcl}} instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org