[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[ https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246143#comment-16246143 ] John Zhuge commented on HDFS-12318: --- Backported to branch-2, branch-2.9, and branch-2.8. Unfortunately not clean backport for branch-2.7, skip it [~vinayrpet]? > Fix IOException condition for openInfo in DFSInputStream > > > Key: HDFS-12318 > URL: https://issues.apache.org/jira/browse/HDFS-12318 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0-beta1 >Reporter: legend >Assignee: legend > Fix For: 3.0.0-beta1 > > Attachments: HDFS-12318.001.patch, HDFS-12318.002.patch, > HDFS-12318.003.patch, HDFS-12318.patch > > > when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, > "openInfo" successfully obtains the last blcok locations, and the function > still throws IOException. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[ https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241600#comment-16241600 ] Vinayakumar B commented on HDFS-12318: -- I think this could be cherry-picked branch-2.8/2.7 as well > Fix IOException condition for openInfo in DFSInputStream > > > Key: HDFS-12318 > URL: https://issues.apache.org/jira/browse/HDFS-12318 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0-beta1 >Reporter: legend >Assignee: legend > Fix For: 3.0.0-beta1 > > Attachments: HDFS-12318.001.patch, HDFS-12318.002.patch, > HDFS-12318.003.patch, HDFS-12318.patch > > > when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, > "openInfo" successfully obtains the last blcok locations, and the function > still throws IOException. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[ https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139809#comment-16139809 ] legend commented on HDFS-12318: --- Thanks [~jzhuge] for review > Fix IOException condition for openInfo in DFSInputStream > > > Key: HDFS-12318 > URL: https://issues.apache.org/jira/browse/HDFS-12318 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0-beta1 >Reporter: legend >Assignee: legend > Fix For: 3.0.0-beta1 > > Attachments: HDFS-12318.001.patch, HDFS-12318.002.patch, > HDFS-12318.003.patch, HDFS-12318.patch > > > when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, > "openInfo" successfully obtains the last blcok locations, and the function > still throws IOException. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[ https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139751#comment-16139751 ] Hudson commented on HDFS-12318: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12235 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12235/]) HDFS-12318. Fix IOException condition for openInfo in DFSInputStream. (jzhuge: rev 3123895db0518552eb357093fddf0e8ff1a6cadf) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java * (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java > Fix IOException condition for openInfo in DFSInputStream > > > Key: HDFS-12318 > URL: https://issues.apache.org/jira/browse/HDFS-12318 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0-beta1 >Reporter: legend >Assignee: legend > Fix For: 3.0.0-beta1 > > Attachments: HDFS-12318.001.patch, HDFS-12318.002.patch, > HDFS-12318.003.patch, HDFS-12318.patch > > > when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, > "openInfo" successfully obtains the last blcok locations, and the function > still throws IOException. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[ https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139691#comment-16139691 ] legend commented on HDFS-12318: --- hi [~jzhuge] Update patch address your comments, and add a try-with-resource. * FSDataOutputStream fout is closed upon exception, using try-with-resource. The failed tests are not related to the patch. > Fix IOException condition for openInfo in DFSInputStream > > > Key: HDFS-12318 > URL: https://issues.apache.org/jira/browse/HDFS-12318 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0-beta1 >Reporter: legend >Assignee: legend > Attachments: HDFS-12318.001.patch, HDFS-12318.002.patch, > HDFS-12318.003.patch, HDFS-12318.patch > > > when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, > "openInfo" successfully obtains the last blcok locations, and the function > still throws IOException. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139541#comment-16139541
]
Hadoop QA commented on HDFS-12318:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
13s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 74m 52s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}108m 6s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.TestMaintenanceState |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 |
| | hadoop.hdfs.server.namenode.TestReconstructStripedBlocks |
| | hadoop.hdfs.TestEncryptionZones |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
| | hadoop.hdfs.web.TestWebHdfsTimeouts |
| Timed out junit tests | org.apache.hadoop.hdfs.TestLeaseRecovery2 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12318 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883475/HDFS-12318.003.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 601399de3aa5 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 652dd43 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/20835/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[ https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136143#comment-16136143 ] legend commented on HDFS-12318: --- Thanks [~jzhuge] for review and update. The failed tests seemed to be caused by CI environment. UT TestDFSInputStream passed. > Fix IOException condition for openInfo in DFSInputStream > > > Key: HDFS-12318 > URL: https://issues.apache.org/jira/browse/HDFS-12318 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0-beta1 >Reporter: legend >Assignee: legend > Attachments: HDFS-12318.001.patch, HDFS-12318.002.patch, > HDFS-12318.patch > > > when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, > "openInfo" successfully obtains the last blcok locations, and the function > still throws IOException. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135524#comment-16135524
]
Hadoop QA commented on HDFS-12318:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
55s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
19s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 64m 56s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 97m 9s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
| | hadoop.hdfs.web.TestWebHdfsTimeouts |
| | hadoop.hdfs.server.namenode.TestNamenodeCapacityReport |
| | hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12318 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12882902/HDFS-12318.002.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux f57a584781ff 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 267e19a |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/20787/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/20787/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135256#comment-16135256
]
Hadoop QA commented on HDFS-12318:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
2s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
14s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 63m
51s{color} | {color:green} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 97m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12318 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12882873/HDFS-12318.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 4a637aae55f2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 267e19a |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/20782/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client
hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/20782/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Fix IOException condition for openInfo in DFSInputStream
>
>
> Key: HDFS-12318
> URL: https://issues.apache.org/jira/browse/HDFS-12318
>
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[ https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134628#comment-16134628 ] legend commented on HDFS-12318: --- Thanks [~jzhuge] for the advice. I will add unit test for the patch. > Fix IOException condition for openInfo in DFSInputStream > > > Key: HDFS-12318 > URL: https://issues.apache.org/jira/browse/HDFS-12318 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0-beta1 >Reporter: legend >Assignee: legend > Attachments: HDFS-12318.patch > > > when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, > "openInfo" successfully obtains the last blcok locations, and the function > still throws IOException. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[ https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134625#comment-16134625 ] John Zhuge commented on HDFS-12318: --- [~legend] Great catch and thanks for the patch. I will take a look. BTW, could you add a unit test? I know unit test is tougher to write than the fix itself, but it will make sure nobody will break your fix in the future. > Fix IOException condition for openInfo in DFSInputStream > > > Key: HDFS-12318 > URL: https://issues.apache.org/jira/browse/HDFS-12318 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0-beta1 >Reporter: legend >Assignee: legend > Attachments: HDFS-12318.patch > > > when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, > "openInfo" successfully obtains the last blcok locations, and the function > still throws IOException. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[ https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134622#comment-16134622 ] legend commented on HDFS-12318: --- hi [~jzhuge], [~yzhangal] I think the patch is useful to fix the issue. > Fix IOException condition for openInfo in DFSInputStream > > > Key: HDFS-12318 > URL: https://issues.apache.org/jira/browse/HDFS-12318 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0-beta1 >Reporter: legend >Assignee: legend > Attachments: HDFS-12318.patch > > > when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, > "openInfo" successfully obtains the last blcok locations, and the function > still throws IOException. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[ https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133999#comment-16133999 ] legend commented on HDFS-12318: --- Thanks to [~vagarychen] for review > Fix IOException condition for openInfo in DFSInputStream > > > Key: HDFS-12318 > URL: https://issues.apache.org/jira/browse/HDFS-12318 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0-beta1 >Reporter: legend >Assignee: legend > Attachments: HDFS-12318.patch > > > when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1, > "openInfo" successfully obtains the last blcok locations, and the function > still throws IOException. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133317#comment-16133317
]
Chen Liang commented on HDFS-12318:
---
Seems this is a fairly tricky corner case, the check becomes problematic only
when either exactly the last retry succeeds, or {{retriesForLastBlockLength}}
is configured to be 0. So thanks [~legend-hua] for the nice catch! The patch
LGTM.
> Fix IOException condition for openInfo in DFSInputStream
>
>
> Key: HDFS-12318
> URL: https://issues.apache.org/jira/browse/HDFS-12318
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 3.0.0-beta1
>Reporter: legend
>Assignee: legend
> Attachments: HDFS-12318.patch
>
>
> when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1,
> "openInfo" successfully obtains the last blcok locations, and the function
> still throws IOException.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12318) Fix IOException condition for openInfo in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132030#comment-16132030
]
Hadoop QA commented on HDFS-12318:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
11s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 18s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12318 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12882545/HDFS-12318.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 2e90cf91265d 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 99e558b |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/20754/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client U:
hadoop-hdfs-project/hadoop-hdfs-client |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/20754/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Fix IOException condition for openInfo in DFSInputStream
>
>
> Key: HDFS-12318
> URL: https://issues.apache.org/jira/browse/HDFS-12318
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 3.0.0-beta1
>Reporter: legend
>Assignee: legend
> Attachments: HDFS-12318.patch
>
>
> when retriesForLastBlockLength == 0 and lastBlockBeingWrittenLength != -1,
> "openInfo" successfully obtains the last blcok
