[jira] [Commented] (HDFS-12796) SCM should not start if Cluster Version file does not exist
[ https://issues.apache.org/jira/browse/HDFS-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455322#comment-16455322 ] Hudson commented on HDFS-12796: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14070/]) HDFS-12796. SCM should not start if Cluster Version file does not exist. (omalley: rev 446e84357d67ba2fbb1ee1b465474caa9ee52f46) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/scm/StorageContainerManager.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java > SCM should not start if Cluster Version file does not exist > --- > > Key: HDFS-12796 > URL: https://issues.apache.org/jira/browse/HDFS-12796 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Shashikant Banerjee >Assignee: Shashikant Banerjee >Priority: Major > Fix For: HDFS-7240 > > Attachments: HDFS-12796-HDFS-7240.001.patch, > HDFS-12796-HDFS-7240.002.patch, HDFS-12796-HDFS-7240.003.patch > > > We have SCM --init command which persist the cluster Version info in the > version file. If SCM gets > started without SCM --init being done even once, it should fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12796) SCM should not start if Cluster Version file does not exist
[ https://issues.apache.org/jira/browse/HDFS-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451110#comment-16451110 ] Hudson commented on HDFS-12796: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14057/]) HDFS-12796. SCM should not start if Cluster Version file does not exist. (nanda: rev b8297b0846d20ebeed05932c5a950dd826343a07) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/scm/StorageContainerManager.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java > SCM should not start if Cluster Version file does not exist > --- > > Key: HDFS-12796 > URL: https://issues.apache.org/jira/browse/HDFS-12796 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Shashikant Banerjee >Assignee: Shashikant Banerjee >Priority: Major > Fix For: HDFS-7240 > > Attachments: HDFS-12796-HDFS-7240.001.patch, > HDFS-12796-HDFS-7240.002.patch, HDFS-12796-HDFS-7240.003.patch > > > We have SCM --init command which persist the cluster Version info in the > version file. If SCM gets > started without SCM --init being done even once, it should fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12796) SCM should not start if Cluster Version file does not exist
[ https://issues.apache.org/jira/browse/HDFS-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247342#comment-16247342 ] Nanda kumar commented on HDFS-12796: I have committed it to feature branch. Thanks for the contribution [~shashikant]. > SCM should not start if Cluster Version file does not exist > --- > > Key: HDFS-12796 > URL: https://issues.apache.org/jira/browse/HDFS-12796 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Shashikant Banerjee >Assignee: Shashikant Banerjee > Fix For: HDFS-7240 > > Attachments: HDFS-12796-HDFS-7240.001.patch, > HDFS-12796-HDFS-7240.002.patch, HDFS-12796-HDFS-7240.003.patch > > > We have SCM --init command which persist the cluster Version info in the > version file. If SCM gets > started without SCM --init being done even once, it should fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12796) SCM should not start if Cluster Version file does not exist
[ https://issues.apache.org/jira/browse/HDFS-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247334#comment-16247334 ] Nanda kumar commented on HDFS-12796: Test failures are not related, I will commit this shortly. > SCM should not start if Cluster Version file does not exist > --- > > Key: HDFS-12796 > URL: https://issues.apache.org/jira/browse/HDFS-12796 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Shashikant Banerjee >Assignee: Shashikant Banerjee > Fix For: HDFS-7240 > > Attachments: HDFS-12796-HDFS-7240.001.patch, > HDFS-12796-HDFS-7240.002.patch, HDFS-12796-HDFS-7240.003.patch > > > We have SCM --init command which persist the cluster Version info in the > version file. If SCM gets > started without SCM --init being done even once, it should fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12796) SCM should not start if Cluster Version file does not exist
[
https://issues.apache.org/jira/browse/HDFS-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247320#comment-16247320
]
Hadoop QA commented on HDFS-12796:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
44s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
12s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 48s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
15s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} HDFS-7240 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 22s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 56s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
22s{color} | {color:red} The patch generated 154 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 87m 47s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Unreaped Processes | hadoop-hdfs:7 |
| Failed junit tests | hadoop.fs.TestSymlinkHdfsFileSystem |
| | hadoop.fs.contract.hdfs.TestHDFSContractCreate |
| | hadoop.fs.viewfs.TestViewFileSystemLinkFallback |
| | hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot |
| | hadoop.fs.permission.TestStickyBit |
| | hadoop.hdfs.TestHFlush |
| | hadoop.fs.TestResolveHdfsSymlink |
| | hadoop.fs.viewfs.TestViewFileSystemLinkMergeSlash |
| | hadoop.fs.viewfs.TestViewFsWithXAttrs |
| | hadoop.fs.viewfs.TestViewFsWithAcls |
| | hadoop.fs.TestSWebHdfsFileContextMainOperations |
| | hadoop.fs.viewfs.TestViewFileSystemWithTruncate |
| | hadoop.fs.contract.hdfs.TestHDFSContractSeek |
| | hadoop.fs.viewfs.TestViewFileSystemWithAcls |
| | hadoop.fs.viewfs.TestViewFsDefaultValue |
| | hadoop.fs.TestUnbuffer |
| | hadoop.fs.shell.TestHdfsTextCommand |
| | hadoop.fs.viewfs.TestViewFsFileStatusHdfs |
| | hadoop.fs.TestFcHdfsPermission |
| | hadoop.fs.TestUrlStreamHandler |
| | hadoop.fs.viewfs.TestViewFsHdfs |
| | hadoop.fs.viewfs.TestViewFileSystemHdfs |
| | hadoop.fs.contract.hdfs.TestHDFSContractDelete |
| | hadoop.fs.TestWebHdfsFileContextMainOperations |
| | hadoop.fs.loadGenerator.TestLoadGenerator |
| | hadoop.fs.TestGlobPaths |
| | hadoop.fs
[jira] [Commented] (HDFS-12796) SCM should not start if Cluster Version file does not exist
[ https://issues.apache.org/jira/browse/HDFS-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247289#comment-16247289 ] Nanda kumar commented on HDFS-12796: +1, LGTM. Pending jenkins. > SCM should not start if Cluster Version file does not exist > --- > > Key: HDFS-12796 > URL: https://issues.apache.org/jira/browse/HDFS-12796 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Shashikant Banerjee >Assignee: Shashikant Banerjee > Fix For: HDFS-7240 > > Attachments: HDFS-12796-HDFS-7240.001.patch, > HDFS-12796-HDFS-7240.002.patch, HDFS-12796-HDFS-7240.003.patch > > > We have SCM --init command which persist the cluster Version info in the > version file. If SCM gets > started without SCM --init being done even once, it should fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12796) SCM should not start if Cluster Version file does not exist
[
https://issues.apache.org/jira/browse/HDFS-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247035#comment-16247035
]
Nanda kumar commented on HDFS-12796:
[~shashikant], thanks for updating the patch.
Sorry for not mentioning it earlier, can you change
{{exception.expect(IOException.class)}} to
{{exception.expect(SCMException.class)}}.
> SCM should not start if Cluster Version file does not exist
> ---
>
> Key: HDFS-12796
> URL: https://issues.apache.org/jira/browse/HDFS-12796
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Shashikant Banerjee
>Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12796-HDFS-7240.001.patch,
> HDFS-12796-HDFS-7240.002.patch
>
>
> We have SCM --init command which persist the cluster Version info in the
> version file. If SCM gets
> started without SCM --init being done even once, it should fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12796) SCM should not start if Cluster Version file does not exist
[
https://issues.apache.org/jira/browse/HDFS-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245983#comment-16245983
]
Nanda kumar commented on HDFS-12796:
Thanks [~shashikant] for reporting and working on the issue.
The patch looks good to me. One small comment though, instead of using {{try ..
cache ..}} block for asserting the Exception we can use
{{org.junit.rules.ExpectedException}}.
> SCM should not start if Cluster Version file does not exist
> ---
>
> Key: HDFS-12796
> URL: https://issues.apache.org/jira/browse/HDFS-12796
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Shashikant Banerjee
>Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12796-HDFS-7240.001.patch
>
>
> We have SCM --init command which persist the cluster Version info in the
> version file. If SCM gets
> started without SCM --init being done even once, it should fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
