[jira] [Commented] (HDFS-12876) Ozone: moving NodeType from OzoneConsts to Ozone.proto
[
https://issues.apache.org/jira/browse/HDFS-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455339#comment-16455339
]
Hudson commented on HDFS-12876:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14070/])
HDFS-12876. Ozone: moving NodeType from OzoneConsts to Ozone.proto. (omalley:
rev 7bba3943f0bbc6e2da487525ee2eb01725a0)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/common/Storage.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/common/StorageInfo.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/scm/SCMStorage.java
* (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/Ozone.proto
* (edit)
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
> Ozone: moving NodeType from OzoneConsts to Ozone.proto
> --
>
> Key: HDFS-12876
> URL: https://issues.apache.org/jira/browse/HDFS-12876
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: Nanda kumar
>Priority: Major
> Attachments: HDFS-12876-HDFS-7240.000.patch,
> HDFS-12876-HDFS-7240.000.patch
>
>
> Since we will be using {{NodeType}} in Service Discovery API - HDFS-12868,
> it's better to have the enum in Ozone.proto than OzoneConsts. We need
> {{NodeType}} in protobuf messages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12876) Ozone: moving NodeType from OzoneConsts to Ozone.proto
[
https://issues.apache.org/jira/browse/HDFS-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451127#comment-16451127
]
Hudson commented on HDFS-12876:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14057/])
HDFS-12876. Ozone: moving NodeType from OzoneConsts to Ozone.proto. (nanda: rev
8f7f4aa80060bc185163a07735ae35c49f220a16)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/scm/SCMStorage.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/common/Storage.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/common/StorageInfo.java
* (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/Ozone.proto
> Ozone: moving NodeType from OzoneConsts to Ozone.proto
> --
>
> Key: HDFS-12876
> URL: https://issues.apache.org/jira/browse/HDFS-12876
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: Nanda kumar
>Priority: Major
> Attachments: HDFS-12876-HDFS-7240.000.patch,
> HDFS-12876-HDFS-7240.000.patch
>
>
> Since we will be using {{NodeType}} in Service Discovery API - HDFS-12868,
> it's better to have the enum in Ozone.proto than OzoneConsts. We need
> {{NodeType}} in protobuf messages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12876) Ozone: moving NodeType from OzoneConsts to Ozone.proto
[
https://issues.apache.org/jira/browse/HDFS-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274457#comment-16274457
]
Nanda kumar commented on HDFS-12876:
I have committed it to the feature branch, thanks [~xyao] for the review.
> Ozone: moving NodeType from OzoneConsts to Ozone.proto
> --
>
> Key: HDFS-12876
> URL: https://issues.apache.org/jira/browse/HDFS-12876
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: Nanda kumar
> Attachments: HDFS-12876-HDFS-7240.000.patch,
> HDFS-12876-HDFS-7240.000.patch
>
>
> Since we will be using {{NodeType}} in Service Discovery API - HDFS-12868,
> it's better to have the enum in Ozone.proto than OzoneConsts. We need
> {{NodeType}} in protobuf messages.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12876) Ozone: moving NodeType from OzoneConsts to Ozone.proto
[
https://issues.apache.org/jira/browse/HDFS-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274450#comment-16274450
]
Nanda kumar commented on HDFS-12876:
Test failures are not related, I will commit this shortly.
> Ozone: moving NodeType from OzoneConsts to Ozone.proto
> --
>
> Key: HDFS-12876
> URL: https://issues.apache.org/jira/browse/HDFS-12876
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: Nanda kumar
> Attachments: HDFS-12876-HDFS-7240.000.patch,
> HDFS-12876-HDFS-7240.000.patch
>
>
> Since we will be using {{NodeType}} in Service Discovery API - HDFS-12868,
> it's better to have the enum in Ozone.proto than OzoneConsts. We need
> {{NodeType}} in protobuf messages.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12876) Ozone: moving NodeType from OzoneConsts to Ozone.proto
[
https://issues.apache.org/jira/browse/HDFS-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274072#comment-16274072
]
genericqa commented on HDFS-12876:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
33s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
46s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
48s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 11s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
0s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
58s{color} | {color:green} HDFS-7240 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 14s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
40s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 92m 27s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}161m 59s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ozone.web.client.TestKeys |
| | hadoop.fs.TestUnbuffer |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d11161b |
| JIRA Issue | HDFS-12876 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900148/HDFS-12876-HDFS-7240.000.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle cc |
| uname | Linux 6c09fb2f565b 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HDFS-12876) Ozone: moving NodeType from OzoneConsts to Ozone.proto
[
https://issues.apache.org/jira/browse/HDFS-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273229#comment-16273229
]
Xiaoyu Yao commented on HDFS-12876:
---
Thanks [~nandakumar131] for reporting the issue and posting the fix. The patch
looks good to me.
+1, pending Jenkins.
> Ozone: moving NodeType from OzoneConsts to Ozone.proto
> --
>
> Key: HDFS-12876
> URL: https://issues.apache.org/jira/browse/HDFS-12876
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Nanda kumar
>Assignee: Nanda kumar
> Attachments: HDFS-12876-HDFS-7240.000.patch
>
>
> Since we will be using {{NodeType}} in Service Discovery API - HDFS-12868,
> it's better to have the enum in Ozone.proto than OzoneConsts. We need
> {{NodeType}} in protobuf messages.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
