[jira] [Commented] (HDFS-13326) RBF: router webUI's MountTable tab doesn't show "readonly" info
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409940#comment-16409940
]
Íñigo Goiri commented on HDFS-13326:
{quote}
Agree. Let's add a "update" cmd there. BTW, it's ok to change context of this
Jira for the new task (adding "update"), right? Don't want to create another
Jira to overwhelm HDFS-12615.
{quote}
Sure, just make the title and the description general enough to take care of
both. Something like: Improve the interfaces to modify and view mount tables.
> RBF: router webUI's MountTable tab doesn't show "readonly" info
> ---
>
> Key: HDFS-13326
> URL: https://issues.apache.org/jira/browse/HDFS-13326
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> So currently in the MountTable tab, the "readonly" field always show empty,
> no matter whether the mount entry is readonly or not. From the code
> perspective, it tries to show:
> {code:java}
> {code}
> The federationhealth.html will load hadoop.css, however the hadoop.css
> doesn't have classes with a prefix "dfshealth-mount-read-only".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13326) RBF: router webUI's MountTable tab doesn't show "readonly" info
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409932#comment-16409932
]
Wei Yan commented on HDFS-13326:
{quote}The APIs already allow that so it should be a matter of tweaking the CLI.
{quote}
Agree. Let's add a "update" cmd there. BTW, it's ok to change context of this
Jira for the new task (adding "update"), right? Don't want to create another
Jira to overwhelm HDFS--12615.
> RBF: router webUI's MountTable tab doesn't show "readonly" info
> ---
>
> Key: HDFS-13326
> URL: https://issues.apache.org/jira/browse/HDFS-13326
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> So currently in the MountTable tab, the "readonly" field always show empty,
> no matter whether the mount entry is readonly or not. From the code
> perspective, it tries to show:
> {code:java}
> {code}
> The federationhealth.html will load hadoop.css, however the hadoop.css
> doesn't have classes with a prefix "dfshealth-mount-read-only".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13326) RBF: router webUI's MountTable tab doesn't show "readonly" info
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408875#comment-16408875
]
Íñigo Goiri commented on HDFS-13326:
Internally, I usually remove the entries for such cases but yes it makes sense
to have an explicit update option which allows this.
The APIs already allow that so it should be a matter of tweaking the CLI.
> RBF: router webUI's MountTable tab doesn't show "readonly" info
> ---
>
> Key: HDFS-13326
> URL: https://issues.apache.org/jira/browse/HDFS-13326
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> So currently in the MountTable tab, the "readonly" field always show empty,
> no matter whether the mount entry is readonly or not. From the code
> perspective, it tries to show:
> {code:java}
> {code}
> The federationhealth.html will load hadoop.css, however the hadoop.css
> doesn't have classes with a prefix "dfshealth-mount-read-only".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13326) RBF: router webUI's MountTable tab doesn't show "readonly" info
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408857#comment-16408857
]
Wei Yan commented on HDFS-13326:
{quote}-add option updates also.
{quote}
yes, I didn't scroll down to the see detailed implementation...
But one interesting thing here, we cannot "switching a mount entry from
readonly to non-readonly", or "removing a target path from a mount entry".
For readonly, currently it only supports updating from falst to true.
{code:java}
if (readonly) {
existingEntry.setReadOnly(true);
}{code}
For target path, it will always tries to add new target locations.
{code:java}
for (String nsId : nss) {
if (!existingEntry.addDestination(nsId, dest)) {
System.err.println("Cannot add destination at " + nsId + " " + dest);
}
}{code}
> RBF: router webUI's MountTable tab doesn't show "readonly" info
> ---
>
> Key: HDFS-13326
> URL: https://issues.apache.org/jira/browse/HDFS-13326
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> So currently in the MountTable tab, the "readonly" field always show empty,
> no matter whether the mount entry is readonly or not. From the code
> perspective, it tries to show:
> {code:java}
> {code}
> The federationhealth.html will load hadoop.css, however the hadoop.css
> doesn't have classes with a prefix "dfshealth-mount-read-only".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13326) RBF: router webUI's MountTable tab doesn't show "readonly" info
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408788#comment-16408788
]
Íñigo Goiri commented on HDFS-13326:
Oh sorry, I missunderstood.
-add option updates also.
We could make it explicit in the doc.
> RBF: router webUI's MountTable tab doesn't show "readonly" info
> ---
>
> Key: HDFS-13326
> URL: https://issues.apache.org/jira/browse/HDFS-13326
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> So currently in the MountTable tab, the "readonly" field always show empty,
> no matter whether the mount entry is readonly or not. From the code
> perspective, it tries to show:
> {code:java}
> {code}
> The federationhealth.html will load hadoop.css, however the hadoop.css
> doesn't have classes with a prefix "dfshealth-mount-read-only".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13326) RBF: router webUI's MountTable tab doesn't show "readonly" info
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408781#comment-16408781
]
Wei Yan commented on HDFS-13326:
Sorry, I didn't type it clearly. I mean the "update" command in dfsrouteradmin.
{code:java}
Federation Admin Tools:
[-add[-readonly] [-order
HASH|LOCAL|RANDOM|HASH_ALL] -owner -group -mode ]
[-rm ]
[-ls ]{code}
Currently it only supports -add and -rm, and no direct way to "update"...
> RBF: router webUI's MountTable tab doesn't show "readonly" info
> ---
>
> Key: HDFS-13326
> URL: https://issues.apache.org/jira/browse/HDFS-13326
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> So currently in the MountTable tab, the "readonly" field always show empty,
> no matter whether the mount entry is readonly or not. From the code
> perspective, it tries to show:
> {code:java}
> {code}
> The federationhealth.html will load hadoop.css, however the hadoop.css
> doesn't have classes with a prefix "dfshealth-mount-read-only".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13326) RBF: router webUI's MountTable tab doesn't show "readonly" info
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408764#comment-16408764
]
Íñigo Goiri commented on HDFS-13326:
{quote}
One more question, do u remember any story about "update mount entry" in the
RouterAdmin cmd? Didn't find it now, we forgot to add?
{quote}
There were a couple JIRAs related to that:
* HDFS-12988
* HDFS-13212
> RBF: router webUI's MountTable tab doesn't show "readonly" info
> ---
>
> Key: HDFS-13326
> URL: https://issues.apache.org/jira/browse/HDFS-13326
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> So currently in the MountTable tab, the "readonly" field always show empty,
> no matter whether the mount entry is readonly or not. From the code
> perspective, it tries to show:
> {code:java}
> {code}
> The federationhealth.html will load hadoop.css, however the hadoop.css
> doesn't have classes with a prefix "dfshealth-mount-read-only".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13326) RBF: router webUI's MountTable tab doesn't show "readonly" info
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408754#comment-16408754
]
Wei Yan commented on HDFS-13326:
[~elgoiri], sure, let me take a pass HDFS-13204.
{quote}Regarding the information, in the WebUI I think is easy to see these
things but the cmd might be a little overwhelming.
{quote}
Agree. let's leave the cmd as it is now.
One more question, do u remember any story about "update mount entry" in the
RouterAdmin cmd? Didn't find it now, we forgot to add?
> RBF: router webUI's MountTable tab doesn't show "readonly" info
> ---
>
> Key: HDFS-13326
> URL: https://issues.apache.org/jira/browse/HDFS-13326
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> So currently in the MountTable tab, the "readonly" field always show empty,
> no matter whether the mount entry is readonly or not. From the code
> perspective, it tries to show:
> {code:java}
> {code}
> The federationhealth.html will load hadoop.css, however the hadoop.css
> doesn't have classes with a prefix "dfshealth-mount-read-only".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13326) RBF: router webUI's MountTable tab doesn't show "readonly" info
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408749#comment-16408749
]
Íñigo Goiri commented on HDFS-13326:
[~ywskycn], in HDFS-13204, we are switching the icons a little.
Do you mind reviewing that one to see if we should move the icons to a
hadoop-hdfs-rbf css?
We can then add this icon in this JIRA.
Regarding the information, in the WebUI I think is easy to see these things but
the cmd might be a little overwhelming.
We may want to add a -d option to show the details.
> RBF: router webUI's MountTable tab doesn't show "readonly" info
> ---
>
> Key: HDFS-13326
> URL: https://issues.apache.org/jira/browse/HDFS-13326
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> So currently in the MountTable tab, the "readonly" field always show empty,
> no matter whether the mount entry is readonly or not. From the code
> perspective, it tries to show:
> {code:java}
> {code}
> The federationhealth.html will load hadoop.css, however the hadoop.css
> doesn't have classes with a prefix "dfshealth-mount-read-only".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13326) RBF: router webUI's MountTable tab doesn't show "readonly" info
[
https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408743#comment-16408743
]
Wei Yan commented on HDFS-13326:
Also, currently cmd "bin/hdfs dfsrouteradmin -ls" has less information than the
WebUI, like "readonly", "order", "date created"... Not sure whether we should
all more such information for better debuggability. Also, we don't want to
overwhelm the outputs of the cmd, for better visibility. Opinions, [~elgoiri]
[~linyiqun]?
> RBF: router webUI's MountTable tab doesn't show "readonly" info
> ---
>
> Key: HDFS-13326
> URL: https://issues.apache.org/jira/browse/HDFS-13326
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> So currently in the MountTable tab, the "readonly" field always show empty,
> no matter whether the mount entry is readonly or not. From the code
> perspective, it tries to show:
> {code:java}
> {code}
> The federationhealth.html will load hadoop.css, however the hadoop.css
> doesn't have classes with a prefix "dfshealth-mount-read-only".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
